Re: [PATCH v2] fs: claw back a few FMODE_* bits

From: Mark Brown <broonie@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: Christian Brauner <brauner@kernel.org>,
	linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Dave Chinner <david@fromorbit.com>,
	io-uring@vger.kernel.org, Aishwarya TCV <Aishwarya.TCV@arm.com>
Subject: Re: [PATCH v2] fs: claw back a few FMODE_* bits
Date: Thu, 4 Apr 2024 12:43:30 +0100	[thread overview]
Message-ID: <6fb750e5-650e-42dd-8786-3bf0b2199178@sirena.org.uk> (raw)
In-Reply-To: <20240404091215.kpphfowf5ktmouu7@quack3>

[-- Attachment #1: Type: text/plain, Size: 3914 bytes --]

On Thu, Apr 04, 2024 at 11:12:15AM +0200, Jan Kara wrote:
> On Wed 03-04-24 22:12:45, Mark Brown wrote:

> > For the past couple of days several LTP tests (open_by_handle_at0[12]
> > and name_to_handle_at01) have been failing on all the arm64 platforms
> > we're running these tests on.  I ran a bisect which came back to this

> Do you have some LTP logs / kernel logs available for the failing runs?

Actually it looks like the issue went away with today's -next, but FWIW
the logging for the open_by_handle_at0[12] failures was:

tst_test.c:1690: TINFO: LTP version: 20230929
tst_test.c:1574: TINFO: Timeout per run is 0h 01m 30s
tst_buffers.c:56: TINFO: Test is using guarded buffers
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (0): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (1): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (2): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (3): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (4): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (5): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (6): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (7): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (8): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (9): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (10): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (11): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (12): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (13): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (14): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (15): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (16): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (17): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (18): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (19): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (20): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (21): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (22): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (23): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (24): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (25): EFAULT (14)
name_to_handle_at01.c:94: TFAIL: open_by_handle_at() failed (26): EFAULT (14)

Summary:
passed   0
failed   27
broken   0
skipped  0
warnings 0

tst_test.c:1690: TINFO: LTP version: 20230929
tst_test.c:1574: TINFO: Timeout per run is 0h 01m 30s
tst_buffers.c:56: TINFO: Test is using guarded buffers
open_by_handle_at02.c:92: TFAIL: invalid-dfd: open_by_handle_at() should fail with EBADF: EFAULT (14)
open_by_handle_at02.c:92: TFAIL: stale-dfd: open_by_handle_at() should fail with ESTALE: EFAULT (14)
open_by_handle_at02.c:98: TPASS: invalid-file-handle: open_by_handle_at() failed as expected: EFAULT (14)
open_by_handle_at02.c:98: TPASS: high-file-handle-size: open_by_handle_at() failed as expected: EINVAL (22)
open_by_handle_at02.c:98: TPASS: zero-file-handle-size: open_by_handle_at() failed as expected: EINVAL (22)
tst_capability.c:29: TINFO: Dropping CAP_DAC_READ_SEARCH(2)
tst_capability.c:41: TINFO: Permitting CAP_DAC_READ_SEARCH(2)
open_by_handle_at02.c:98: TPASS: no-capability: open_by_handle_at() failed as expected: EPERM (1)
open_by_handle_at02.c:92: TFAIL: symlink: open_by_handle_at() should fail with ELOOP: EFAULT (14)

Summary:
passed   4
failed   3
broken   0
skipped  0
warnings 0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]