Re: [PATCH v3 3/4] arm64: add Airoha EN7581 platform

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, nbd@nbd.name, john@phrozen.org,
	devicetree@vger.kernel.org, dd@embedd.com,
	catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com,
	lorenzo.bianconi83@gmail.com
Subject: Re: [PATCH v3 3/4] arm64: add Airoha EN7581 platform
Date: Thu, 7 Mar 2024 12:37:09 +0100	[thread overview]
Message-ID: <6ff8ed9a-f70c-4ef5-97a7-37ddba4db7f6@collabora.com> (raw)
In-Reply-To: <b50faa94923389d435ac37c3094c269a46bddaea.1709768157.git.lorenzo@kernel.org>

Il 07/03/24 01:11, Lorenzo Bianconi ha scritto:
> From: Daniel Danzberger <dd@embedd.com>
> 
> Introduce the Kconfig entry for the Airoha EN7581 multicore architecture
> available in the Airoha EN7581 evaluation board.
> 
> Signed-off-by: Daniel Danzberger <dd@embedd.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>   arch/arm64/Kconfig.platforms | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 24335565bad5..bbe61e233034 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -8,6 +8,19 @@ config ARCH_ACTIONS
>   	help
>   	  This enables support for the Actions Semiconductor S900 SoC family.
>   
> +config ARCH_AIROHA
> +	bool "Airoha SoC Support"
> +	select ARM_AMBA

ARM_AMBA is selected by ARM64 already, you don't need that one here.

> +	select ARM_GIC
> +	select ARM_GIC_V3

ARM_GIC and ARM_GIC_v3 are also selected by ARM64

> +	select ARM_PSCI

ARM64 selects ARM_PSCI_FW (which should select ARM_PSCI, please verify)

> +	select HAVE_ARM_ARCH_TIMER
> +	select COMMON_CLK

ARM64 selects COMMON_CLK already.

> +	help
> +	  This enables support for Airoha EN7581 multicore architecture
> +	  available on the following SoCs:
> +	   - Airoha EN7581 Evaluation Board

You're not going to add one ARCH entry for each MTK Airoha platform, are you?

(if you are, that's wrong)

....so the help text must be refactored; you could say something like
"This enables support for the ARM64 based Airoha SoCs"

...also, I'm undecided whether MTK should be mentioned or not, here, as those
SoCs are (...at least the 7581 seems to be) really based on MediaTek router
chips, in many instances, sharing the same IPs.

Cheers,
Angelo