All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yi Zhang <yi.zhang@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>,
	Matthew Wilcox <willy@infradead.org>
Cc: "Shutemov, Kirill" <kirill.shutemov@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>,
	linux-nvdimm <linux-nvdimm@lists.01.org>,
	Vlastimil Babka <vbabka@suse.cz>
Subject: Re: mapcount corruption regression
Date: Thu, 3 Dec 2020 06:37:57 +0800	[thread overview]
Message-ID: <709287b1-dedf-3bff-e46a-8aa19ad774fb@redhat.com> (raw)
In-Reply-To: <CAPcyv4hxuzn9k-W_+iBsa=evL-FGijWyaxkyFLohUTqCCoJAig@mail.gmail.com>

Hi Dan
> diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c
> index dfd82f51ba66..7ed99314dcdf 100644
> --- a/arch/x86/mm/pgtable.c
> +++ b/arch/x86/mm/pgtable.c
> @@ -829,6 +829,7 @@ int pud_free_pmd_page(pud_t *pud, unsigned long addr)
>          }
>
>          free_page((unsigned long)pmd_sv);
> +       pgtable_pmd_page_dtor(virt_to_page(pmd));
>          free_page((unsigned long)pmd);
>
>          return 1;
>
> In 2013 Kirill noticed that he missed a pmd page table free site:
>
>      c283610e44ec x86, mm: do not leak page->ptl for pmd page tables
>
> In 2018 Toshi added a new pmd page table free site without the destructor:
>
>      28ee90fe6048 x86/mm: implement free pmd/pte page interfaces
>
> In 2020 Willy adds PG_table accounting that flags the missing
> pgtable_pmd_page_dtor()
>
> Yi, I would appreciate a confirmation that the fix works for you.
>
I applied the patch to v5.10-rc3 ~ v5.10-rc6, and cannot reproduce this 
issue with my regression test now, feel free to add:
Tested-by: Yi Zhang <yi.zhang@redhat.com>


Thanks
Yi
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: Yi Zhang <yi.zhang@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>,
	Matthew Wilcox <willy@infradead.org>
Cc: "Shutemov, Kirill" <kirill.shutemov@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>,
	linux-nvdimm <linux-nvdimm@lists.01.org>,
	Vlastimil Babka <vbabka@suse.cz>, Toshi Kani <toshi.kani@hpe.com>
Subject: Re: mapcount corruption regression
Date: Thu, 3 Dec 2020 06:37:57 +0800	[thread overview]
Message-ID: <709287b1-dedf-3bff-e46a-8aa19ad774fb@redhat.com> (raw)
In-Reply-To: <CAPcyv4hxuzn9k-W_+iBsa=evL-FGijWyaxkyFLohUTqCCoJAig@mail.gmail.com>

Hi Dan
> diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c
> index dfd82f51ba66..7ed99314dcdf 100644
> --- a/arch/x86/mm/pgtable.c
> +++ b/arch/x86/mm/pgtable.c
> @@ -829,6 +829,7 @@ int pud_free_pmd_page(pud_t *pud, unsigned long addr)
>          }
>
>          free_page((unsigned long)pmd_sv);
> +       pgtable_pmd_page_dtor(virt_to_page(pmd));
>          free_page((unsigned long)pmd);
>
>          return 1;
>
> In 2013 Kirill noticed that he missed a pmd page table free site:
>
>      c283610e44ec x86, mm: do not leak page->ptl for pmd page tables
>
> In 2018 Toshi added a new pmd page table free site without the destructor:
>
>      28ee90fe6048 x86/mm: implement free pmd/pte page interfaces
>
> In 2020 Willy adds PG_table accounting that flags the missing
> pgtable_pmd_page_dtor()
>
> Yi, I would appreciate a confirmation that the fix works for you.
>
I applied the patch to v5.10-rc3 ~ v5.10-rc6, and cannot reproduce this 
issue with my regression test now, feel free to add:
Tested-by: Yi Zhang <yi.zhang@redhat.com>


Thanks
Yi


  reply	other threads:[~2020-12-02 22:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  1:20 mapcount corruption regression Dan Williams
2020-12-01  1:20 ` Dan Williams
2020-12-01  1:20 ` Dan Williams
2020-12-01  1:46 ` Dan Williams
2020-12-01  1:46   ` Dan Williams
2020-12-01  1:46   ` Dan Williams
2020-12-01  2:24 ` Matthew Wilcox
2020-12-01  2:24   ` Matthew Wilcox
2020-12-01 20:42   ` Dan Williams
2020-12-01 20:42     ` Dan Williams
2020-12-01 20:42     ` Dan Williams
2020-12-01 20:49     ` Matthew Wilcox
2020-12-01 20:49       ` Matthew Wilcox
2020-12-02  2:28       ` Dan Williams
2020-12-02  2:28         ` Dan Williams
2020-12-02  2:28         ` Dan Williams
2020-12-02  3:43         ` Matthew Wilcox
2020-12-02  3:43           ` Matthew Wilcox
2020-12-02  5:07           ` Dan Williams
2020-12-02  5:07             ` Dan Williams
2020-12-02  5:07             ` Dan Williams
2020-12-02  8:49             ` Dan Williams
2020-12-02  8:49               ` Dan Williams
2020-12-02  8:49               ` Dan Williams
2020-12-02 22:37               ` Yi Zhang [this message]
2020-12-02 22:37                 ` Yi Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=709287b1-dedf-3bff-e46a-8aa19ad774fb@redhat.com \
    --to=yi.zhang@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=kirill.shutemov@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.