From: Samuel Holland <samuel@sholland.org>
To: Mark Brown <broonie@kernel.org>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Vasily Khoruzhick" <anarsoul@gmail.com>,
"Mylène Josserand" <mylene.josserand@free-electrons.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [RFC PATCH 08/34] ASoC: sun8i-codec: Fix direction of AIF1 outputs
Date: Mon, 17 Feb 2020 19:44:49 -0600 [thread overview]
Message-ID: <7108ff30-df7e-09bd-f895-2768347d45ba@sholland.org> (raw)
In-Reply-To: <20200217150935.GJ9304@sirena.org.uk>
On 2/17/20 9:09 AM, Mark Brown wrote:
> On Mon, Feb 17, 2020 at 12:42:24AM -0600, Samuel Holland wrote:
>> The naming convention for AIFs in this codec is to call the "DAC" the
>> path from the AIF into the codec, and the ADC the path from the codec
>> back to the AIF, regardless of if there is any analog path involved.
>
> This renames widgets but does not update any DAPM routes from those
> widgets which will break things if this patch is applied.
This commit doesn't change the widget name, only the widget type. My commit
message did not make that clear.
>> Cc: stable@kernel.org
>
> Why is this suitable for stable? It's a random textual cleanup.
This was one of the first patches I wrote. Now that I understand DAPM better, I
realize that it has no functional impact, and this shouldn't go to stable.
(snd_soc_dapm_aif_in and snd_soc_dapm_aif_out are handled exactly the same, so
fixing the widget type is, as you say, just a textual cleanup.)
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Holland <samuel@sholland.org>
To: Mark Brown <broonie@kernel.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, "Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Vasily Khoruzhick" <anarsoul@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Mylène Josserand" <mylene.josserand@free-electrons.com>,
stable@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 08/34] ASoC: sun8i-codec: Fix direction of AIF1 outputs
Date: Mon, 17 Feb 2020 19:44:49 -0600 [thread overview]
Message-ID: <7108ff30-df7e-09bd-f895-2768347d45ba@sholland.org> (raw)
In-Reply-To: <20200217150935.GJ9304@sirena.org.uk>
On 2/17/20 9:09 AM, Mark Brown wrote:
> On Mon, Feb 17, 2020 at 12:42:24AM -0600, Samuel Holland wrote:
>> The naming convention for AIFs in this codec is to call the "DAC" the
>> path from the AIF into the codec, and the ADC the path from the codec
>> back to the AIF, regardless of if there is any analog path involved.
>
> This renames widgets but does not update any DAPM routes from those
> widgets which will break things if this patch is applied.
This commit doesn't change the widget name, only the widget type. My commit
message did not make that clear.
>> Cc: stable@kernel.org
>
> Why is this suitable for stable? It's a random textual cleanup.
This was one of the first patches I wrote. Now that I understand DAPM better, I
realize that it has no functional impact, and this shouldn't go to stable.
(snd_soc_dapm_aif_in and snd_soc_dapm_aif_out are handled exactly the same, so
fixing the widget type is, as you say, just a textual cleanup.)
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Holland <samuel@sholland.org>
To: Mark Brown <broonie@kernel.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, "Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Chen-Yu Tsai" <wens@csie.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Mylène Josserand" <mylene.josserand@free-electrons.com>,
stable@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 08/34] ASoC: sun8i-codec: Fix direction of AIF1 outputs
Date: Mon, 17 Feb 2020 19:44:49 -0600 [thread overview]
Message-ID: <7108ff30-df7e-09bd-f895-2768347d45ba@sholland.org> (raw)
In-Reply-To: <20200217150935.GJ9304@sirena.org.uk>
On 2/17/20 9:09 AM, Mark Brown wrote:
> On Mon, Feb 17, 2020 at 12:42:24AM -0600, Samuel Holland wrote:
>> The naming convention for AIFs in this codec is to call the "DAC" the
>> path from the AIF into the codec, and the ADC the path from the codec
>> back to the AIF, regardless of if there is any analog path involved.
>
> This renames widgets but does not update any DAPM routes from those
> widgets which will break things if this patch is applied.
This commit doesn't change the widget name, only the widget type. My commit
message did not make that clear.
>> Cc: stable@kernel.org
>
> Why is this suitable for stable? It's a random textual cleanup.
This was one of the first patches I wrote. Now that I understand DAPM better, I
realize that it has no functional impact, and this shouldn't go to stable.
(snd_soc_dapm_aif_in and snd_soc_dapm_aif_out are handled exactly the same, so
fixing the widget type is, as you say, just a textual cleanup.)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-18 1:44 UTC|newest]
Thread overview: 207+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 6:42 [RFC PATCH 00/34] sun8i-codec fixes and new features Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 01/34] ASoC: dt-bindings: Add a separate compatible for the A64 codec Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 9:49 ` Chen-Yu Tsai
2020-02-17 9:49 ` Chen-Yu Tsai
2020-02-17 9:49 ` [alsa-devel] " Chen-Yu Tsai
2020-02-18 3:17 ` Samuel Holland
2020-02-18 3:17 ` Samuel Holland
2020-02-18 3:17 ` Samuel Holland
2020-02-26 15:18 ` Rob Herring
2020-02-26 15:18 ` Rob Herring
2020-02-26 15:18 ` Rob Herring
2020-02-17 6:42 ` [RFC PATCH 02/34] ASoC: sun8i-codec: LRCK is not inverted on A64 Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 9:50 ` Chen-Yu Tsai
2020-02-17 9:50 ` Chen-Yu Tsai
2020-02-17 9:50 ` [alsa-devel] " Chen-Yu Tsai
2020-02-17 14:43 ` Mark Brown
2020-02-17 14:43 ` Mark Brown
2020-02-17 14:43 ` [alsa-devel] " Mark Brown
2020-02-17 6:42 ` [RFC PATCH 03/34] arm64: dts: allwinner: a64: Fix the audio codec compatible Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 14:56 ` Mark Brown
2020-02-17 14:56 ` Mark Brown
2020-02-17 14:56 ` [alsa-devel] " Mark Brown
2020-02-17 6:42 ` [RFC PATCH 04/34] ASoC: sun8i-codec: Remove unused dev from codec struct Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 7:41 ` Chen-Yu Tsai
2020-02-17 7:41 ` Chen-Yu Tsai
2020-02-17 7:41 ` [alsa-devel] " Chen-Yu Tsai
2020-02-17 15:04 ` Mark Brown
2020-02-17 15:04 ` Mark Brown
2020-02-17 15:04 ` [alsa-devel] " Mark Brown
2020-02-21 14:21 ` Applied "ASoC: sun8i-codec: Remove unused dev from codec struct" to the asoc tree Mark Brown
2020-02-21 14:21 ` Mark Brown
2020-02-21 14:21 ` Mark Brown
2020-02-17 6:42 ` [RFC PATCH 05/34] ASoC: sun8i-codec: Remove incorrect SND_SOC_DAIFMT_DSP_B Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 8:19 ` Chen-Yu Tsai
2020-02-17 8:19 ` Chen-Yu Tsai
2020-02-17 8:19 ` [alsa-devel] " Chen-Yu Tsai
2020-02-17 15:02 ` Mark Brown
2020-02-17 15:02 ` Mark Brown
2020-02-17 15:02 ` [alsa-devel] " Mark Brown
2020-02-18 1:35 ` Samuel Holland
2020-02-18 1:35 ` Samuel Holland
2020-02-18 1:35 ` Samuel Holland
2020-02-18 11:32 ` Mark Brown
2020-02-18 11:32 ` Mark Brown
2020-02-18 11:32 ` Mark Brown
2020-02-17 6:42 ` [RFC PATCH 06/34] ASoC: sun8i-codec: Fix setting DAI data format Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 8:23 ` Chen-Yu Tsai
2020-02-17 8:23 ` Chen-Yu Tsai
2020-02-17 8:23 ` [alsa-devel] " Chen-Yu Tsai
2020-02-17 22:03 ` Applied "ASoC: sun8i-codec: Fix setting DAI data format" to the asoc tree Mark Brown
2020-02-17 22:03 ` Mark Brown
2020-02-17 22:03 ` Mark Brown
2020-02-17 6:42 ` [RFC PATCH 07/34] ASoC: sun8i-codec: Remove extraneous widgets Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 7:37 ` Chen-Yu Tsai
2020-02-17 7:37 ` Chen-Yu Tsai
2020-02-17 7:37 ` [alsa-devel] " Chen-Yu Tsai
2020-02-17 15:05 ` Mark Brown
2020-02-17 15:05 ` Mark Brown
2020-02-17 15:05 ` [alsa-devel] " Mark Brown
2020-02-17 6:42 ` [RFC PATCH 08/34] ASoC: sun8i-codec: Fix direction of AIF1 outputs Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 8:22 ` Chen-Yu Tsai
2020-02-17 8:22 ` Chen-Yu Tsai
2020-02-17 8:22 ` [alsa-devel] " Chen-Yu Tsai
2020-02-17 15:09 ` Mark Brown
2020-02-17 15:09 ` Mark Brown
2020-02-17 15:09 ` [alsa-devel] " Mark Brown
2020-02-18 1:44 ` Samuel Holland [this message]
2020-02-18 1:44 ` Samuel Holland
2020-02-18 1:44 ` Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 09/34] ASoC: sun8i-codec: Fix broken DAPM routing Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 15:24 ` Mark Brown
2020-02-17 15:24 ` Mark Brown
2020-02-17 15:24 ` [alsa-devel] " Mark Brown
2020-02-17 6:42 ` [RFC PATCH 10/34] ASoC: sun8i-codec: Advertise only hardware-supported rates Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 15:30 ` Mark Brown
2020-02-17 15:30 ` Mark Brown
2020-02-17 15:30 ` [alsa-devel] " Mark Brown
2020-02-18 1:55 ` Samuel Holland
2020-02-18 1:55 ` Samuel Holland
2020-02-18 1:55 ` Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 11/34] ASoC: sun8i-codec: Enforce parameter symmetry Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 12/34] ASoC: sun8i-codec: Fix AIF1 MODCLK widget name Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 8:06 ` Chen-Yu Tsai
2020-02-17 8:06 ` Chen-Yu Tsai
2020-02-17 8:06 ` [alsa-devel] " Chen-Yu Tsai
2020-02-17 6:42 ` [RFC PATCH 13/34] ASoC: sun8i-codec: Fix AIF1_ADCDAT_CTRL field names Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 7:58 ` Chen-Yu Tsai
2020-02-17 7:58 ` Chen-Yu Tsai
2020-02-17 7:58 ` [alsa-devel] " Chen-Yu Tsai
2020-02-17 6:42 ` [RFC PATCH 14/34] ASoC: sun8i-codec: Fix AIF1_MXR_SRC " Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 7:57 ` Chen-Yu Tsai
2020-02-17 7:57 ` Chen-Yu Tsai
2020-02-17 7:57 ` [alsa-devel] " Chen-Yu Tsai
2020-02-17 6:42 ` [RFC PATCH 15/34] ASoC: sun8i-codec: Fix ADC_DIG_CTRL field name Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 7:55 ` Chen-Yu Tsai
2020-02-17 7:55 ` Chen-Yu Tsai
2020-02-17 7:55 ` [alsa-devel] " Chen-Yu Tsai
2020-02-17 6:42 ` [RFC PATCH 16/34] ASoC: sun8i-codec: Fix field bit number indentation Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 7:54 ` Chen-Yu Tsai
2020-02-17 7:54 ` Chen-Yu Tsai
2020-02-17 7:54 ` [alsa-devel] " Chen-Yu Tsai
2020-02-17 6:42 ` [RFC PATCH 17/34] ASoC: sun8i-codec: Sort masks in a consistent order Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 7:59 ` Chen-Yu Tsai
2020-02-17 7:59 ` Chen-Yu Tsai
2020-02-17 7:59 ` [alsa-devel] " Chen-Yu Tsai
2020-02-17 6:42 ` [RFC PATCH 18/34] ASoC: sun8i-codec: Allow all clock inversion permutations Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 19/34] ASoC: sun8i-codec: Support mono DAI configurations Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 20/34] ASoC: sun8i-codec: Support 8/20/24-bit word sizes Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 21/34] ASoC: sun8i-codec: Clean up module/clock hierarchy Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 22/34] ASoC: sun8i-codec: Clean up AIF1 Slot 0 widgets Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 23/34] ASoC: sun8i-codec: Clean up DAC widgets Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 24/34] ASoC: sun8i-codec: Prepare to support multiple AIFs Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 25/34] ASoC: sun8i-codec: Add support for AIF2 Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 26/34] ASoC: sun8i-codec: Add support for AIF3 Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 27/34] ASoC: sun8i-codec: Add AIF mono/stereo controls Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 28/34] ASoC: sun8i-codec: Add AIF loopback controls Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 29/34] ASoC: sun8i-codec: Add AIF, ADC, and DAC volume controls Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 30/34] ASoC: dt-bindings: Bump sound-dai-cells on sun8i-codec Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-18 20:23 ` Rob Herring
2020-02-18 20:23 ` Rob Herring
2020-02-18 20:23 ` Rob Herring
2020-02-17 6:42 ` [RFC PATCH 31/34] ARM: dts: sun8i-a33: Allow using multiple codec DAIs Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 32/34] arm64: dts: allwinner: a64: " Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 33/34] arm64: dts: allwinner: a64: Allow multiple DAI links Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 6:42 ` [RFC PATCH 34/34] arm64: dts: allwinner: a64: Add pinmux for AIF2/AIF3 Samuel Holland
2020-02-17 6:42 ` Samuel Holland
2020-02-17 6:42 ` [alsa-devel] " Samuel Holland
2020-02-17 9:14 ` [RFC PATCH 00/34] sun8i-codec fixes and new features Maxime Ripard
2020-02-17 9:14 ` Maxime Ripard
2020-02-17 9:14 ` [alsa-devel] " Maxime Ripard
2020-02-17 9:44 ` Chen-Yu Tsai
2020-02-17 9:44 ` Chen-Yu Tsai
2020-02-17 9:44 ` [alsa-devel] " Chen-Yu Tsai
2020-02-17 12:07 ` Maxime Ripard
2020-02-17 12:07 ` Maxime Ripard
2020-02-17 12:07 ` [alsa-devel] " Maxime Ripard
2020-02-17 16:26 ` Mark Brown
2020-02-17 16:26 ` Mark Brown
2020-02-17 16:26 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7108ff30-df7e-09bd-f895-2768347d45ba@sholland.org \
--to=samuel@sholland.org \
--cc=alsa-devel@alsa-project.org \
--cc=anarsoul@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=mylene.josserand@free-electrons.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=stable@kernel.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.