From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Amey Narkhede <ameynarkhede03@gmail.com>
Cc: iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, Rob Clark <robdclark@gmail.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Krishna Reddy <vdumpa@nvidia.com>
Subject: Re: [PATCH] iommu: qcom: Revert "iommu/arm: Cleanup resources in case of probe error path"
Date: Tue, 6 Jul 2021 08:40:33 +0200 [thread overview]
Message-ID: <71106cbb-ff6d-02cb-7743-dfbd27bdaddf@samsung.com> (raw)
In-Reply-To: <20210705143054.nxy4ii6t6npj22ov@archlinux>
On 05.07.2021 16:30, Amey Narkhede wrote:
> On 21/07/05 08:56AM, Marek Szyprowski wrote:
>> QCOM IOMMU driver calls bus_set_iommu() for every IOMMU device controller,
>> what fails for the second and latter IOMMU devices. This is intended and
>> must be not fatal to the driver registration process. Also the cleanup
>> path should take care of the runtime PM state, what is missing in the
>> current patch. Revert relevant changes to the QCOM IOMMU driver until
>> a proper fix is prepared.
>>
> Apologies for the broken patch I don't have any arm machine to test the
> patches. Is this bug unique to qcom iommu?
Frankly, I have no idea. Just grep for bus_set_iommu() and check if the
caller might be executed more than once.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Amey Narkhede <ameynarkhede03@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] iommu: qcom: Revert "iommu/arm: Cleanup resources in case of probe error path"
Date: Tue, 6 Jul 2021 08:40:33 +0200 [thread overview]
Message-ID: <71106cbb-ff6d-02cb-7743-dfbd27bdaddf@samsung.com> (raw)
In-Reply-To: <20210705143054.nxy4ii6t6npj22ov@archlinux>
On 05.07.2021 16:30, Amey Narkhede wrote:
> On 21/07/05 08:56AM, Marek Szyprowski wrote:
>> QCOM IOMMU driver calls bus_set_iommu() for every IOMMU device controller,
>> what fails for the second and latter IOMMU devices. This is intended and
>> must be not fatal to the driver registration process. Also the cleanup
>> path should take care of the runtime PM state, what is missing in the
>> current patch. Revert relevant changes to the QCOM IOMMU driver until
>> a proper fix is prepared.
>>
> Apologies for the broken patch I don't have any arm machine to test the
> patches. Is this bug unique to qcom iommu?
Frankly, I have no idea. Just grep for bus_set_iommu() and check if the
caller might be executed more than once.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Amey Narkhede <ameynarkhede03@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
Rob Clark <robdclark@gmail.com>,
iommu@lists.linux-foundation.org, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] iommu: qcom: Revert "iommu/arm: Cleanup resources in case of probe error path"
Date: Tue, 6 Jul 2021 08:40:33 +0200 [thread overview]
Message-ID: <71106cbb-ff6d-02cb-7743-dfbd27bdaddf@samsung.com> (raw)
In-Reply-To: <20210705143054.nxy4ii6t6npj22ov@archlinux>
On 05.07.2021 16:30, Amey Narkhede wrote:
> On 21/07/05 08:56AM, Marek Szyprowski wrote:
>> QCOM IOMMU driver calls bus_set_iommu() for every IOMMU device controller,
>> what fails for the second and latter IOMMU devices. This is intended and
>> must be not fatal to the driver registration process. Also the cleanup
>> path should take care of the runtime PM state, what is missing in the
>> current patch. Revert relevant changes to the QCOM IOMMU driver until
>> a proper fix is prepared.
>>
> Apologies for the broken patch I don't have any arm machine to test the
> patches. Is this bug unique to qcom iommu?
Frankly, I have no idea. Just grep for bus_set_iommu() and check if the
caller might be executed more than once.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-06 6:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210705065703eucas1p2e89258a2fc286896b755047e06f514cb@eucas1p2.samsung.com>
2021-07-05 6:56 ` [PATCH] iommu: qcom: Revert "iommu/arm: Cleanup resources in case of probe error path" Marek Szyprowski
2021-07-05 6:56 ` Marek Szyprowski
2021-07-05 6:56 ` Marek Szyprowski
2021-07-05 14:30 ` Amey Narkhede
2021-07-05 14:30 ` Amey Narkhede
2021-07-05 14:30 ` Amey Narkhede
2021-07-06 6:40 ` Marek Szyprowski [this message]
2021-07-06 6:40 ` Marek Szyprowski
2021-07-06 6:40 ` Marek Szyprowski
2021-07-06 16:52 ` Will Deacon
2021-07-06 16:52 ` Will Deacon
2021-07-06 16:52 ` Will Deacon
2021-07-08 10:03 ` Joerg Roedel
2021-07-08 10:03 ` Joerg Roedel
2021-07-08 10:03 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71106cbb-ff6d-02cb-7743-dfbd27bdaddf@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=ameynarkhede03@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.