Re: [PATCH 08/12] arm64: dts: ti: k3-am64-evm: Fixup reference to phandles array

From: "Kumar, Udit" <u-kumar1@ti.com>
To: Nishanth Menon <nm@ti.com>, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Tero Kristo <kristo@kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>, <u-kumar1@ti.com>
Subject: Re: [PATCH 08/12] arm64: dts: ti: k3-am64-evm: Fixup reference to phandles array
Date: Mon, 5 Jun 2023 22:32:18 +0530	[thread overview]
Message-ID: <720c8c43-9a95-d7b5-3267-405ff0149eea@ti.com> (raw)
In-Reply-To: <20230601152636.858553-9-nm@ti.com>

Hi Nishanth

On 6/1/2023 8:56 PM, Nishanth Menon wrote:
> When referring to array of phandles, using <> to separate the array
> entries is better notation as it makes potential errors with phandle and
> cell arguments easier to catch. Fix the outliers to be consistent with
> the rest of the usage.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-am642-evm.dts | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> index 91bdc6026d1f..fef68a778ac9 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> @@ -467,8 +467,8 @@ &usb0 {
>   
>   &cpsw3g {
>   	pinctrl-names = "default";
> -	pinctrl-0 = <&rgmii1_pins_default
> -		     &rgmii2_pins_default>;
> +	pinctrl-0 = <&rgmii1_pins_default>,
> +		    <&rgmii2_pins_default>;

Please see, if  pinctrl-0 can be defined in one line, instead of two, to 
be inline with most of changes in this series.

> [..]