From: Arnd Bergmann <arnd@arndb.de>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Jon Medhurst <tixy@linaro.org>,
linux-pci <linux-pci@vger.kernel.org>,
device-tree <devicetree@vger.kernel.org>,
LAKML <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] PCI: Add quirk for PLDA's XpressRICH3 host bridge class.
Date: Fri, 09 Oct 2015 20:32:07 +0200 [thread overview]
Message-ID: <7335872.olmykfZgj7@wuerfel> (raw)
In-Reply-To: <1444409849-5685-3-git-send-email-Liviu.Dudau@arm.com>
On Friday 09 October 2015 17:57:26 Liviu Dudau wrote:
> +/*
> + * The PLDA's XpressRICH3 doesn't describe itself as a bridge. This is required
> + * for correct/normal enumeration.
> + */
> +static void xr3pci_quirk_class(struct pci_dev *pdev)
> +{
> + pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
> +}
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_PLDA, PCI_DEVICE_ID_XR3PCI, xr3pci_quirk_class);
>
Are you sure that this device ID is only used for the host bridge, not
for related devices in endpoint mode?
While we don't support PCIe endpoint drivers at the moment, it might
happen at some point and then things break when someone tries to
plug a machine with this ID into a Linux host.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] PCI: Add quirk for PLDA's XpressRICH3 host bridge class.
Date: Fri, 09 Oct 2015 20:32:07 +0200 [thread overview]
Message-ID: <7335872.olmykfZgj7@wuerfel> (raw)
In-Reply-To: <1444409849-5685-3-git-send-email-Liviu.Dudau@arm.com>
On Friday 09 October 2015 17:57:26 Liviu Dudau wrote:
> +/*
> + * The PLDA's XpressRICH3 doesn't describe itself as a bridge. This is required
> + * for correct/normal enumeration.
> + */
> +static void xr3pci_quirk_class(struct pci_dev *pdev)
> +{
> + pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
> +}
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_PLDA, PCI_DEVICE_ID_XR3PCI, xr3pci_quirk_class);
>
Are you sure that this device ID is only used for the host bridge, not
for related devices in endpoint mode?
While we don't support PCIe endpoint drivers at the moment, it might
happen at some point and then things break when someone tries to
plug a machine with this ID into a Linux host.
Arnd
next prev parent reply other threads:[~2015-10-09 18:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 16:57 [PATCH v2 0/5] arm64: Juno: Add support for PCIe on R1 board Liviu Dudau
2015-10-09 16:57 ` Liviu Dudau
2015-10-09 16:57 ` [PATCH v2 1/5] pci: Add PLDA's XpressRICH3 PCIe host bridge PCI ID Liviu Dudau
2015-10-09 16:57 ` Liviu Dudau
2015-10-09 16:57 ` Liviu Dudau
2015-10-09 16:57 ` [PATCH v2 2/5] PCI: Add quirk for PLDA's XpressRICH3 host bridge class Liviu Dudau
2015-10-09 16:57 ` Liviu Dudau
2015-10-09 18:32 ` Arnd Bergmann [this message]
2015-10-09 18:32 ` Arnd Bergmann
2015-10-12 8:57 ` Liviu Dudau
2015-10-12 8:57 ` Liviu Dudau
2015-10-12 8:57 ` Liviu Dudau
2015-10-09 16:57 ` [PATCH v2 3/5] of: Add vendor prefix for PLDA Liviu Dudau
2015-10-09 16:57 ` Liviu Dudau
2015-10-09 16:57 ` Liviu Dudau
2015-10-09 16:59 ` Mark Rutland
2015-10-09 16:59 ` Mark Rutland
2015-10-09 16:59 ` Mark Rutland
2015-10-09 17:04 ` Liviu Dudau
2015-10-09 17:04 ` Liviu Dudau
2015-10-09 16:57 ` [PATCH v2 4/5] arm64: Juno: Add support for the PCIe host bridge on Juno R1 Liviu Dudau
2015-10-09 16:57 ` Liviu Dudau
2015-10-09 16:57 ` Liviu Dudau
2015-10-09 17:04 ` Mark Rutland
2015-10-09 17:04 ` Mark Rutland
2015-10-09 17:49 ` Rob Herring
2015-10-09 17:49 ` Rob Herring
2015-10-09 16:57 ` [PATCH v2 5/5] arm64: defconfig: Enable PCI generic host bridge by default Liviu Dudau
2015-10-09 16:57 ` Liviu Dudau
2015-10-09 16:57 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7335872.olmykfZgj7@wuerfel \
--to=arnd@arndb.de \
--cc=Liviu.Dudau@arm.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tixy@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.