From: Hu Mingkai-B21284 <B21284@freescale.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: linuxppc-dev@ozlabs.org, Gala Kumar-B11780 <B11780@freescale.com>,
linux-mtd@lists.infradead.org,
Zang Roy-R61911 <R61911@freescale.com>,
spi-devel-general@lists.sourceforge.net
Subject: RE: [PATCH v3 2/7] spi/mpc8xxx: refactor the common code for SPI/eSPI controller
Date: Fri, 8 Oct 2010 14:37:00 +0800 [thread overview]
Message-ID: <73839B4A0818E747864426270AC332C3057F6272@zmy16exm20.fsl.freescale.net> (raw)
In-Reply-To: <20101001112212.GA17505@oksana.dev.rtsoft.ru>
> -----Original Message-----
> From: Anton Vorontsov [mailto:cbouatmailru@gmail.com]
> Sent: Friday, October 01, 2010 7:22 PM
> To: Hu Mingkai-B21284
> Cc: linuxppc-dev@ozlabs.org; spi-devel-general@lists.sourceforge.net; linux-
> mtd@lists.infradead.org; Gala Kumar-B11780; Zang Roy-R61911
> Subject: Re: [PATCH v3 2/7] spi/mpc8xxx: refactor the common code for SPI/eSPI
> controller
>
> On Thu, Sep 30, 2010 at 04:00:41PM +0800, Mingkai Hu wrote:
> [...]
> > -static void mpc8xxx_spi_change_mode(struct spi_device *spi)
> > +static void fsl_spi_change_mode(struct spi_device *spi)
> > {
> > struct mpc8xxx_spi *mspi = spi_master_get_devdata(spi->master);
> > struct spi_mpc8xxx_cs *cs = spi->controller_state;
> > - __be32 __iomem *mode = &mspi->base->mode;
> > + struct fsl_spi_reg *reg_base = (struct fsl_spi_reg *)mspi->reg_base;
>
> No need for these type casts (the same is for the whole patch).
>
Fix it.
Thanks,
Mingkai
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Hu Mingkai-B21284 <B21284@freescale.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: linuxppc-dev@ozlabs.org, Gala Kumar-B11780 <B11780@freescale.com>,
linux-mtd@lists.infradead.org,
Zang Roy-R61911 <R61911@freescale.com>,
spi-devel-general@lists.sourceforge.net
Subject: RE: [PATCH v3 2/7] spi/mpc8xxx: refactor the common code for SPI/eSPI controller
Date: Fri, 8 Oct 2010 14:37:00 +0800 [thread overview]
Message-ID: <73839B4A0818E747864426270AC332C3057F6272@zmy16exm20.fsl.freescale.net> (raw)
In-Reply-To: <20101001112212.GA17505@oksana.dev.rtsoft.ru>
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQW50b24gVm9yb250c292
IFttYWlsdG86Y2JvdWF0bWFpbHJ1QGdtYWlsLmNvbV0NCj4gU2VudDogRnJpZGF5LCBPY3RvYmVy
IDAxLCAyMDEwIDc6MjIgUE0NCj4gVG86IEh1IE1pbmdrYWktQjIxMjg0DQo+IENjOiBsaW51eHBw
Yy1kZXZAb3psYWJzLm9yZzsgc3BpLWRldmVsLWdlbmVyYWxAbGlzdHMuc291cmNlZm9yZ2UubmV0
OyBsaW51eC0NCj4gbXRkQGxpc3RzLmluZnJhZGVhZC5vcmc7IEdhbGEgS3VtYXItQjExNzgwOyBa
YW5nIFJveS1SNjE5MTENCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MyAyLzddIHNwaS9tcGM4eHh4
OiByZWZhY3RvciB0aGUgY29tbW9uIGNvZGUgZm9yIFNQSS9lU1BJDQo+IGNvbnRyb2xsZXINCj4g
DQo+IE9uIFRodSwgU2VwIDMwLCAyMDEwIGF0IDA0OjAwOjQxUE0gKzA4MDAsIE1pbmdrYWkgSHUg
d3JvdGU6DQo+IFsuLi5dDQo+ID4gLXN0YXRpYyB2b2lkIG1wYzh4eHhfc3BpX2NoYW5nZV9tb2Rl
KHN0cnVjdCBzcGlfZGV2aWNlICpzcGkpDQo+ID4gK3N0YXRpYyB2b2lkIGZzbF9zcGlfY2hhbmdl
X21vZGUoc3RydWN0IHNwaV9kZXZpY2UgKnNwaSkNCj4gPiAgew0KPiA+ICAJc3RydWN0IG1wYzh4
eHhfc3BpICptc3BpID0gc3BpX21hc3Rlcl9nZXRfZGV2ZGF0YShzcGktPm1hc3Rlcik7DQo+ID4g
IAlzdHJ1Y3Qgc3BpX21wYzh4eHhfY3MgKmNzID0gc3BpLT5jb250cm9sbGVyX3N0YXRlOw0KPiA+
IC0JX19iZTMyIF9faW9tZW0gKm1vZGUgPSAmbXNwaS0+YmFzZS0+bW9kZTsNCj4gPiArCXN0cnVj
dCBmc2xfc3BpX3JlZyAqcmVnX2Jhc2UgPSAoc3RydWN0IGZzbF9zcGlfcmVnICopbXNwaS0+cmVn
X2Jhc2U7DQo+IA0KPiBObyBuZWVkIGZvciB0aGVzZSB0eXBlIGNhc3RzICh0aGUgc2FtZSBpcyBm
b3IgdGhlIHdob2xlIHBhdGNoKS4NCj4gDQoNCkZpeCBpdC4NCg0KVGhhbmtzLA0KTWluZ2thaQ0K
WARNING: multiple messages have this Message-ID (diff)
From: Hu Mingkai-B21284 <B21284@freescale.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: linuxppc-dev@ozlabs.org, Gala Kumar-B11780 <B11780@freescale.com>,
linux-mtd@lists.infradead.org,
Zang Roy-R61911 <R61911@freescale.com>,
spi-devel-general@lists.sourceforge.net
Subject: RE: [PATCH v3 2/7] spi/mpc8xxx: refactor the common code for SPI/eSPI controller
Date: Fri, 8 Oct 2010 14:37:00 +0800 [thread overview]
Message-ID: <73839B4A0818E747864426270AC332C3057F6272@zmy16exm20.fsl.freescale.net> (raw)
In-Reply-To: <20101001112212.GA17505@oksana.dev.rtsoft.ru>
> -----Original Message-----
> From: Anton Vorontsov [mailto:cbouatmailru@gmail.com]
> Sent: Friday, October 01, 2010 7:22 PM
> To: Hu Mingkai-B21284
> Cc: linuxppc-dev@ozlabs.org; spi-devel-general@lists.sourceforge.net; linux-
> mtd@lists.infradead.org; Gala Kumar-B11780; Zang Roy-R61911
> Subject: Re: [PATCH v3 2/7] spi/mpc8xxx: refactor the common code for SPI/eSPI
> controller
>
> On Thu, Sep 30, 2010 at 04:00:41PM +0800, Mingkai Hu wrote:
> [...]
> > -static void mpc8xxx_spi_change_mode(struct spi_device *spi)
> > +static void fsl_spi_change_mode(struct spi_device *spi)
> > {
> > struct mpc8xxx_spi *mspi = spi_master_get_devdata(spi->master);
> > struct spi_mpc8xxx_cs *cs = spi->controller_state;
> > - __be32 __iomem *mode = &mspi->base->mode;
> > + struct fsl_spi_reg *reg_base = (struct fsl_spi_reg *)mspi->reg_base;
>
> No need for these type casts (the same is for the whole patch).
>
Fix it.
Thanks,
Mingkai
next prev parent reply other threads:[~2010-10-08 6:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 8:00 [PATCH v3 0/7] refactor spi_mpc8xxx.c and add eSPI controller support Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
2010-09-30 8:00 ` [PATCH v3 1/7] spi/mpc8xxx: rename spi_mpc8xxx.c to spi_fsl_spi.c Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
[not found] ` <1285833646-12006-2-git-send-email-Mingkai.hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-09-30 8:00 ` [PATCH v3 2/7] spi/mpc8xxx: refactor the common code for SPI/eSPI controller Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
2010-09-30 8:00 ` [PATCH v3 3/7] eSPI: add eSPI controller support Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
[not found] ` <1285833646-12006-4-git-send-email-Mingkai.hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-09-30 8:00 ` [PATCH v3 4/7] powerpc/of: add eSPI controller dts bindings and DTS modification Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
2010-09-30 8:00 ` [PATCH v3 5/7] mtd: m25p80: add support to parse the SPI flash's partitions Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
2010-09-30 8:00 ` [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
2010-09-30 8:00 ` [PATCH v3 7/7] DTS: add fsl,spi-quirk-trans-len-limit property Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
2010-09-30 8:00 ` Mingkai Hu
[not found] ` <1285833646-12006-7-git-send-email-Mingkai.hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-09-30 21:41 ` [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page Grant Likely
2010-09-30 21:41 ` Grant Likely
2010-09-30 21:41 ` Grant Likely
2010-09-30 21:34 ` [PATCH v3 5/7] mtd: m25p80: add support to parse the SPI flash's partitions Grant Likely
2010-09-30 21:34 ` Grant Likely
2010-09-30 21:34 ` Grant Likely
2010-10-08 2:42 ` Hu Mingkai-B21284
2010-10-08 2:42 ` Hu Mingkai-B21284
2010-10-01 11:22 ` [PATCH v3 3/7] eSPI: add eSPI controller support Anton Vorontsov
2010-10-08 6:35 ` Hu Mingkai-B21284
2010-10-08 6:35 ` Hu Mingkai-B21284
[not found] ` <1285833646-12006-3-git-send-email-Mingkai.hu-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-10-01 11:22 ` [PATCH v3 2/7] spi/mpc8xxx: refactor the common code for SPI/eSPI controller Anton Vorontsov
2010-10-01 11:22 ` Anton Vorontsov
2010-10-01 11:22 ` Anton Vorontsov
2010-10-08 6:37 ` Hu Mingkai-B21284 [this message]
2010-10-08 6:37 ` Hu Mingkai-B21284
2010-10-08 6:37 ` Hu Mingkai-B21284
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73839B4A0818E747864426270AC332C3057F6272@zmy16exm20.fsl.freescale.net \
--to=b21284@freescale.com \
--cc=B11780@freescale.com \
--cc=R61911@freescale.com \
--cc=cbouatmailru@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.