All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	broonie@kernel.org, srinivas.kandagatla@linaro.org,
	jank@cadence.com, slawomir.blauciak@intel.com,
	Sanyog Kale <sanyog.r.kale@intel.com>,
	Bard liao <yung-chuan.liao@linux.intel.com>,
	Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [alsa-devel] [PATCH v5 09/17] soundwire: intel: remove platform devices and use 'Master Devices' instead
Date: Tue, 21 Jan 2020 11:31:32 -0600	[thread overview]
Message-ID: <73907607-0763-576d-b24e-4773dfb15f0b@linux.intel.com> (raw)
In-Reply-To: <20200118071257.GY2818@vkoul-mobl>


> A rename away from probe will certainly be very helpful as
> you would also agree that terms 'probe' and 'remove' have a very
> special meaning in kernel, so let us avoid these

ok, so would the following be ok with you?

/**
  * struct sdw_md_driver - SoundWire 'Master Device' driver
  *
  * @init: allocations and initializations (hardware may not be enabled yet)
  * @startup: initialization handled after the hardware is enabled, all
  * clock/power dependencies are available
  * @shutdown: cleanups before hardware is disabled (optional)
  * @exit: free all remaining resources
  * @autonomous_clock_stop_enable: enable/disable driver control while
  * in clock-stop mode, typically in always-on/D0ix modes. When the driver
  * yields control, another entity in the system (typically firmware
  * running on an always-on microprocessor) is responsible to tracking
  * Slave-initiated wakes
  */
struct sdw_md_driver {
	int (*init)(struct sdw_master_device *md, void *link_ctx);
	int (*startup)(struct sdw_master_device *md);
	int (*shutdown)(struct sdw_master_device *md);
	int (*exit)(struct sdw_master_device *md);
	int (*autonomous_clock_stop_enable)(struct sdw_master_device *md,
					    bool state);
};

WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	broonie@kernel.org, srinivas.kandagatla@linaro.org,
	jank@cadence.com, slawomir.blauciak@intel.com,
	Sanyog Kale <sanyog.r.kale@intel.com>,
	Bard liao <yung-chuan.liao@linux.intel.com>,
	Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [alsa-devel] [PATCH v5 09/17] soundwire: intel: remove platform devices and use 'Master Devices' instead
Date: Tue, 21 Jan 2020 11:31:32 -0600	[thread overview]
Message-ID: <73907607-0763-576d-b24e-4773dfb15f0b@linux.intel.com> (raw)
In-Reply-To: <20200118071257.GY2818@vkoul-mobl>


> A rename away from probe will certainly be very helpful as
> you would also agree that terms 'probe' and 'remove' have a very
> special meaning in kernel, so let us avoid these

ok, so would the following be ok with you?

/**
  * struct sdw_md_driver - SoundWire 'Master Device' driver
  *
  * @init: allocations and initializations (hardware may not be enabled yet)
  * @startup: initialization handled after the hardware is enabled, all
  * clock/power dependencies are available
  * @shutdown: cleanups before hardware is disabled (optional)
  * @exit: free all remaining resources
  * @autonomous_clock_stop_enable: enable/disable driver control while
  * in clock-stop mode, typically in always-on/D0ix modes. When the driver
  * yields control, another entity in the system (typically firmware
  * running on an always-on microprocessor) is responsible to tracking
  * Slave-initiated wakes
  */
struct sdw_md_driver {
	int (*init)(struct sdw_master_device *md, void *link_ctx);
	int (*startup)(struct sdw_master_device *md);
	int (*shutdown)(struct sdw_master_device *md);
	int (*exit)(struct sdw_master_device *md);
	int (*autonomous_clock_stop_enable)(struct sdw_master_device *md,
					    bool state);
};
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2020-01-21 17:31 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 21:02 [PATCH v5 00/17] soundwire: intel: implement new ASoC interfaces Pierre-Louis Bossart
2019-12-17 21:02 ` [alsa-devel] " Pierre-Louis Bossart
2019-12-17 21:02 ` [PATCH v5 01/17] soundwire: renames to prepare support for master drivers/devices Pierre-Louis Bossart
2019-12-17 21:02   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-17 21:02 ` [PATCH v5 02/17] soundwire: rename dev_to_sdw_dev macro Pierre-Louis Bossart
2019-12-17 21:02   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-27  6:54   ` Vinod Koul
2019-12-27  6:54     ` [alsa-devel] " Vinod Koul
2019-12-17 21:03 ` [PATCH v5 03/17] soundwire: rename drv_to_sdw_slave_driver macro Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-27  7:00   ` Vinod Koul
2019-12-27  7:00     ` [alsa-devel] " Vinod Koul
2019-12-27 23:23     ` Pierre-Louis Bossart
2019-12-27 23:23       ` Pierre-Louis Bossart
2019-12-28 12:03       ` Vinod Koul
2019-12-28 12:03         ` Vinod Koul
2019-12-17 21:03 ` [PATCH v5 04/17] soundwire: bus_type: rename sdw_drv_ to sdw_slave_drv Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-17 21:03 ` [PATCH v5 05/17] soundwire: intel: rename res field as link_res Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-17 21:03 ` [PATCH v5 06/17] soundwire: add support for sdw_slave_type Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-27  7:03   ` Vinod Koul
2019-12-27  7:03     ` [alsa-devel] " Vinod Koul
2019-12-27 23:26     ` Pierre-Louis Bossart
2019-12-27 23:26       ` Pierre-Louis Bossart
2019-12-28 12:05       ` Vinod Koul
2019-12-28 12:05         ` Vinod Koul
2019-12-17 21:03 ` [PATCH v5 07/17] soundwire: slave: move uevent handling to slave device level Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-17 21:03 ` [PATCH v5 08/17] soundwire: add initial definitions for sdw_master_device Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-27  7:14   ` Vinod Koul
2019-12-27  7:14     ` [alsa-devel] " Vinod Koul
2019-12-27 23:38     ` Pierre-Louis Bossart
2019-12-27 23:38       ` Pierre-Louis Bossart
2019-12-28 12:09       ` Vinod Koul
2019-12-28 12:09         ` Vinod Koul
2020-01-02 17:36         ` Pierre-Louis Bossart
2020-01-02 17:36           ` Pierre-Louis Bossart
2020-01-06  5:32           ` Vinod Koul
2020-01-06  5:32             ` Vinod Koul
2019-12-17 21:03 ` [PATCH v5 09/17] soundwire: intel: remove platform devices and use 'Master Devices' instead Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-27  9:08   ` Vinod Koul
2019-12-27  9:08     ` [alsa-devel] " Vinod Koul
2019-12-28  0:13     ` Pierre-Louis Bossart
2019-12-28  0:13       ` Pierre-Louis Bossart
2020-01-06  5:42       ` Vinod Koul
2020-01-06  5:42         ` Vinod Koul
2020-01-06 14:51         ` Pierre-Louis Bossart
2020-01-06 14:51           ` Pierre-Louis Bossart
2020-01-10  6:43           ` Vinod Koul
2020-01-10  6:43             ` Vinod Koul
2020-01-10 16:08             ` Pierre-Louis Bossart
2020-01-10 16:08               ` Pierre-Louis Bossart
2020-01-13  5:18               ` Vinod Koul
2020-01-13  5:18                 ` Vinod Koul
2020-01-13 15:22                 ` Pierre-Louis Bossart
2020-01-13 15:22                   ` Pierre-Louis Bossart
2020-01-14  6:09   ` Vinod Koul
2020-01-14  6:09     ` [alsa-devel] " Vinod Koul
2020-01-14 16:01     ` Pierre-Louis Bossart
2020-01-14 16:01       ` Pierre-Louis Bossart
2020-01-18  7:12       ` Vinod Koul
2020-01-18  7:12         ` Vinod Koul
2020-01-21 17:31         ` Pierre-Louis Bossart [this message]
2020-01-21 17:31           ` Pierre-Louis Bossart
2020-01-28 10:50           ` Vinod Koul
2020-01-28 10:50             ` Vinod Koul
2020-01-28 16:02             ` Pierre-Louis Bossart
2020-01-28 16:02               ` Pierre-Louis Bossart
2020-01-29  5:08               ` Vinod Koul
2020-01-29  5:08                 ` Vinod Koul
2020-01-29 14:59                 ` Pierre-Louis Bossart
2020-01-29 14:59                   ` Pierre-Louis Bossart
2020-02-03 12:02                   ` Vinod Koul
2020-02-03 12:02                     ` Vinod Koul
2019-12-17 21:03 ` [PATCH v5 10/17] soundwire: register master device driver Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-17 21:03 ` [PATCH v5 11/17] soundwire: intel: add prepare support in sdw dai driver Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-17 21:03 ` [PATCH v5 12/17] soundwire: intel: add trigger " Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-17 21:03 ` [PATCH v5 13/17] soundwire: intel: add sdw_stream_setup helper for .startup callback Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-17 21:03 ` [PATCH v5 14/17] soundwire: intel: free all resources on hw_free() Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-17 21:03 ` [PATCH v5 15/17] soundwire: intel_init: add implementation of sdw_intel_enable_irq() Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-17 21:03 ` [PATCH v5 16/17] soundwire: intel_init: use EXPORT_SYMBOL_NS Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart
2019-12-17 21:03 ` [PATCH v5 17/17] soundwire: intel: " Pierre-Louis Bossart
2019-12-17 21:03   ` [alsa-devel] " Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73907607-0763-576d-b24e-4773dfb15f0b@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jank@cadence.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rander.wang@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=slawomir.blauciak@intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.