From: Florian Fainelli <f.fainelli@gmail.com>
To: Andre Przywara <andre.przywara@arm.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v2 3/6] ARM: dts: NSP: Fix SP804 compatible node
Date: Fri, 28 Aug 2020 10:12:59 -0700 [thread overview]
Message-ID: <73b35bcd-0e8c-0f62-ed2b-e0c64261f930@gmail.com> (raw)
In-Reply-To: <20200828142018.43298-4-andre.przywara@arm.com>
On 8/28/20 7:20 AM, Andre Przywara wrote:
> The DT binding for SP804 requires to have an "arm,primecell" compatible
> string.
> Add this string so that the Linux primecell bus driver picks the device
> up and activates the clock.
>
> Fixes: a0efb0d28b77 ("ARM: dts: NSP: Add SP804 Support to DT")
> Tested-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
This looks fine, however there is a ccbtimer1 instance that you missed,
can you resubmit with it included?
With that:
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Andre Przywara <andre.przywara@arm.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/6] ARM: dts: NSP: Fix SP804 compatible node
Date: Fri, 28 Aug 2020 10:12:59 -0700 [thread overview]
Message-ID: <73b35bcd-0e8c-0f62-ed2b-e0c64261f930@gmail.com> (raw)
In-Reply-To: <20200828142018.43298-4-andre.przywara@arm.com>
On 8/28/20 7:20 AM, Andre Przywara wrote:
> The DT binding for SP804 requires to have an "arm,primecell" compatible
> string.
> Add this string so that the Linux primecell bus driver picks the device
> up and activates the clock.
>
> Fixes: a0efb0d28b77 ("ARM: dts: NSP: Add SP804 Support to DT")
> Tested-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
This looks fine, however there is a ccbtimer1 instance that you missed,
can you resubmit with it included?
With that:
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-28 17:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 14:20 [PATCH v2 0/6] dt-bindings: Convert SP804 to Json-schema (and fix users) Andre Przywara
2020-08-28 14:20 ` Andre Przywara
2020-08-28 14:20 ` [PATCH v2 1/6] dt-bindings: timers: sp-804: Convert to json-schema Andre Przywara
2020-08-28 14:20 ` Andre Przywara
2020-09-08 17:28 ` Rob Herring
2020-09-08 17:28 ` Rob Herring
2020-09-09 10:07 ` André Przywara
2020-09-09 10:07 ` André Przywara
2020-08-28 14:20 ` [PATCH v2 2/6] ARM: dts: arm: Fix SP804 users Andre Przywara
2020-08-28 14:20 ` Andre Przywara
2020-08-28 14:20 ` [PATCH v2 3/6] ARM: dts: NSP: Fix SP804 compatible node Andre Przywara
2020-08-28 14:20 ` Andre Przywara
2020-08-28 17:12 ` Florian Fainelli [this message]
2020-08-28 17:12 ` Florian Fainelli
2020-09-01 23:04 ` Florian Fainelli
2020-09-01 23:04 ` Florian Fainelli
2020-09-04 1:04 ` André Przywara
2020-09-04 1:04 ` André Przywara
2020-09-04 20:54 ` Florian Fainelli
2020-09-04 20:54 ` Florian Fainelli
2020-08-28 14:20 ` [PATCH v2 4/6] ARM: dts: hisilicon: Fix SP804 users Andre Przywara
2020-08-28 14:20 ` Andre Przywara
2020-08-28 14:20 ` [PATCH v2 5/6] ARM: dts: nspire: " Andre Przywara
2020-08-28 14:20 ` Andre Przywara
2020-08-28 14:20 ` [PATCH v2 6/6] arm64: dts: lg: " Andre Przywara
2020-08-28 14:20 ` Andre Przywara
2020-08-28 14:54 ` [PATCH v2 0/6] dt-bindings: Convert SP804 to Json-schema (and fix users) Linus Walleij
2020-08-28 14:54 ` Linus Walleij
2020-08-28 15:44 ` André Przywara
2020-08-28 15:44 ` André Przywara
2020-09-01 6:42 ` Emmanuel Vadot
2020-09-01 6:42 ` Emmanuel Vadot
2020-09-08 12:48 ` Sudeep Holla
2020-09-08 12:48 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73b35bcd-0e8c-0f62-ed2b-e0c64261f930@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andre.przywara@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=haojian.zhuang@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.