Re: [PATCH 22/31] soc/tegra: Migrate to dev_pm_opp_set_config()

From: Dmitry Osipenko <digetx@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-pm@vger.kernel.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Rafael Wysocki <rjw@rjwysocki.net>,
	Stephen Boyd <sboyd@kernel.org>, Nishanth Menon <nm@ti.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 22/31] soc/tegra: Migrate to dev_pm_opp_set_config()
Date: Mon, 27 Jun 2022 01:14:54 +0300	[thread overview]
Message-ID: <73d39022-c6fc-0c21-cb68-9714846f02bf@gmail.com> (raw)
In-Reply-To: <20220624005700.oj4etaajbutvsym7@vireshk-i7>

24.06.2022 03:57, Viresh Kumar пишет:
> On 24-06-22, 06:18, Viresh Kumar wrote:
>> +       struct dev_pm_opp_config config = {
>> +               /*
>> +                * For some devices we don't have any OPP table in the DT, and
>> +                * in order to use the same code path for all the devices, we
>> +                * create a dummy OPP table for them via this. The dummy OPP
>> +                * table is only capable of doing clk_set_rate() on invocation
>> +                * of dev_pm_opp_set_rate() and doesn't provide any other
>> +                * functionality.
>> +                */
>> +               .clk_names = NULL,
>> +               .clk_count = 1,
>> +       };
> 
> Slight modification here, sorry about that. We just need to set the
> name as NULL and not the array itself.
> 
> diff --git a/drivers/soc/tegra/common.c b/drivers/soc/tegra/common.c
> index cd53e46c4058..6a099d764cce 100644
> --- a/drivers/soc/tegra/common.c
> +++ b/drivers/soc/tegra/common.c
> @@ -116,7 +116,7 @@ int devm_tegra_core_dev_init_opp_table(struct device *dev,
>                  * of dev_pm_opp_set_rate() and doesn't provide any other
>                  * functionality.
>                  */
> -               .clk_names = NULL,
> +               .clk_names = (const char *[]){ NULL },
>                 .clk_count = 1,
>         };
> 

Looks okay. If you'll solve the cpufreq problem where OPP config is set
by two drivers for the same cpu device and will keep the set_opp()
helper that is needed by the Tegra 3d driver, then it all should work
for Tegra. Looking forward to the next update of the OPP patches, thank you.