Re: [PATCH v2 3/3] glossary: add reachability bitmap description

From: Philip Oakley <philipoakley@iee.email>
To: Junio C Hamano <gitster@pobox.com>,
	Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Cc: GitList <git@vger.kernel.org>, Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH v2 3/3] glossary: add reachability bitmap description
Date: Mon, 24 Oct 2022 22:23:37 +0100	[thread overview]
Message-ID: <746491f4-fb41-92fe-7360-20a845dc21fc@iee.email> (raw)
In-Reply-To: <xmqq1qqxuqf0.fsf@gitster.g>

On 24/10/2022 17:39, Junio C Hamano wrote:
> Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com> writes:
>
>> Small correction here - A repository may have multiple bitmaps (one
>> for each selected commit from the preferred packfile or a
>> multi-pack-index) but it can have only one ".bitmap" file (as of now).
>> Bitmaps for the selected commits are stored in that ".bitmap" file.
>> So I think the below lines (or similar) will work  -
>>
>>     The bitmaps are stored in a ".bitmap" file. A repository may have
>>     at most one ".bitmap" file. The file may belong to either one pack, or the
>>     repository's multi-pack-index (if it exists).
>>
>> Feel free to rephrase it accordingly.
> Sounds good to me.  Or Philip's original can be tweaked minimally to
> say "... may have at most one bitmap file (which stores multiple
> bitmaps)".
>
Thanks both. I'll tweak the description in a day or so to allow Stolee
to comment if required.
P.