Re: [PATCH v2 1/1] doc add: renormalize is not idempotent for CRCRLF

From: Junio C Hamano <gitster@pobox.com>
To: Philip Oakley <philipoakley@iee.email>
Cc: git@vger.kernel.org, gitgitgadget@gmail.com, tboegi@web.de
Subject: Re: [PATCH v2 1/1] doc add: renormalize is not idempotent for CRCRLF
Date: Wed, 10 Aug 2022 10:42:18 -0700	[thread overview]
Message-ID: <xmqqh72km1vp.fsf@gitster.g> (raw)
In-Reply-To: <20220810144450.470-2-philipoakley@iee.email> (Philip Oakley's message of "Wed, 10 Aug 2022 15:44:50 +0100")

Philip Oakley <philipoakley@iee.email> writes:

> diff --git a/Documentation/git-add.txt b/Documentation/git-add.txt
> index 11eb70f16c..9b37f35654 100644
> --- a/Documentation/git-add.txt
> +++ b/Documentation/git-add.txt
> @@ -188,7 +188,9 @@ for "git add --no-all <pathspec>...", i.e. ignored removed files.
>  	forcibly add them again to the index.  This is useful after
>  	changing `core.autocrlf` configuration or the `text` attribute
>  	in order to correct files added with wrong CRLF/LF line endings.
> -	This option implies `-u`.
> +	This option implies `-u`. Lone CR characters are untouched, thus
> +	while a CRLF cleans to LF, a CRCRLF sequence is only partially
> +	cleaned to CRLF.

Looks perfetly readable and understandable to me.

Thanks, will replace.  Let's plan to merge it down soonish.