From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>,
Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
Cc: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: RE: [PATCH 4/5] ARM: tegra: paz00: add clocks required for usb operation
Date: Mon, 8 Aug 2011 09:57:52 -0700 [thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF049F1721C1@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <76f31183766f1edce1230a925ced1c986dbdf028.1312742856.git.marvin24-Mmb7MZpHnFY@public.gmane.org>
Marc Dietrich wrote at Sunday, August 07, 2011 1:01 PM:
> These clocks are required for usb operation.
...
> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
...
> @@ -145,6 +145,11 @@ static __initdata struct tegra_clk_init_table paz00_clk_init_table[] = {
> /* name parent rate enabled */
> { "uarta", "pll_p", 216000000, true },
> { "uartd", "pll_p", 216000000, true },
> +
> + { "pll_a", "pll_p_out1", 56448000, true },
> + { "pll_a_out0", "pll_a", 11289600, true },
Are you sure those two are required for USB operation; they're typically
used for audio. Of course, this might just be a bug in the commit
description:-) Although, if you are attempting to enable audio, there's
a bunch more stuff that'd need to be done, including some more clock
setup.
--
nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: swarren@nvidia.com (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ARM: tegra: paz00: add clocks required for usb operation
Date: Mon, 8 Aug 2011 09:57:52 -0700 [thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF049F1721C1@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <76f31183766f1edce1230a925ced1c986dbdf028.1312742856.git.marvin24@gmx.de>
Marc Dietrich wrote at Sunday, August 07, 2011 1:01 PM:
> These clocks are required for usb operation.
...
> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
...
> @@ -145,6 +145,11 @@ static __initdata struct tegra_clk_init_table paz00_clk_init_table[] = {
> /* name parent rate enabled */
> { "uarta", "pll_p", 216000000, true },
> { "uartd", "pll_p", 216000000, true },
> +
> + { "pll_a", "pll_p_out1", 56448000, true },
> + { "pll_a_out0", "pll_a", 11289600, true },
Are you sure those two are required for USB operation; they're typically
used for audio. Of course, this might just be a bug in the commit
description:-) Although, if you are attempting to enable audio, there's
a bunch more stuff that'd need to be done, including some more clock
setup.
--
nvpublic
next prev parent reply other threads:[~2011-08-08 16:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-07 19:00 [PATCH 0/5] ARM: tegra: paz00: updates for "for-next" Marc Dietrich
2011-08-07 19:00 ` Marc Dietrich
[not found] ` <cover.1312742856.git.marvin24-Mmb7MZpHnFY@public.gmane.org>
[not found] ` <cover.1312735430.git.marvin24-Mmb7MZpHnFY@public.gmane.org>
2011-08-07 19:00 ` [PATCH 1/5] ARM: tegra: paz00: add support serial port on JP1 Marc Dietrich
2011-08-07 19:00 ` Marc Dietrich
2011-08-07 19:00 ` [PATCH 2/5] ARM: tegra: paz00: enable rfkill for internal wifi card Marc Dietrich
2011-08-07 19:00 ` Marc Dietrich
2011-08-07 19:00 ` [PATCH 3/5] ARM: tegra: paz00: enable wifi led Marc Dietrich
2011-08-07 19:00 ` Marc Dietrich
2011-08-07 19:00 ` [PATCH 4/5] ARM: tegra: paz00: add clocks required for usb operation Marc Dietrich
2011-08-07 19:00 ` Marc Dietrich
[not found] ` <76f31183766f1edce1230a925ced1c986dbdf028.1312742856.git.marvin24-Mmb7MZpHnFY@public.gmane.org>
2011-08-08 16:57 ` Stephen Warren [this message]
2011-08-08 16:57 ` Stephen Warren
2011-08-08 17:18 ` [PATCH 4/5] ARM: tegra: paz00: add clocks required for usboperation Marc Dietrich
2011-08-08 17:18 ` Marc Dietrich
[not found] ` <201108081919.07647.marc.dietrich-wkdnK3oF/XPYtB+G+YtuwQgYPMzSbZxj@public.gmane.org>
2011-08-08 17:38 ` Stephen Warren
2011-08-08 17:38 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF049F1721DE-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-08-08 21:15 ` [PATCH 4/5] ARM: tegra: paz00: add clocks required forusboperation Marc Dietrich
2011-08-08 21:15 ` Marc Dietrich
2011-08-09 18:29 ` [PATCH 4/5 V2] ARM: tegra: paz00: add clocks required for usb operation Marc Dietrich
2011-08-09 18:29 ` Marc Dietrich
[not found] ` <201108092029.17546.marvin24-Mmb7MZpHnFY@public.gmane.org>
2011-08-09 18:30 ` Olof Johansson
2011-08-09 18:30 ` Olof Johansson
[not found] ` <CAOesGMiV-jrcGFUXBf=5H__-gXvwgxUias7WGouYTvAy+k=oMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-09 19:18 ` Marc Dietrich
2011-08-09 19:18 ` Marc Dietrich
[not found] ` <201108092118.43724.marvin24-Mmb7MZpHnFY@public.gmane.org>
2011-08-09 19:24 ` Olof Johansson
2011-08-09 19:24 ` Olof Johansson
2011-08-09 18:35 ` Stephen Warren
2011-08-09 18:35 ` Stephen Warren
2011-08-07 19:00 ` [PATCH 5/5] ARM: tegra: paz00: reorder the SDHCI channel init Marc Dietrich
2011-08-07 19:00 ` Marc Dietrich
2011-08-09 19:35 ` [PATCH 0/5] ARM: tegra: paz00: updates for "for-next" Olof Johansson
2011-08-09 19:35 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74CDBE0F657A3D45AFBB94109FB122FF049F1721C1@HQMAIL01.nvidia.com \
--to=swarren-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.