From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Belisko Marek <marek.belisko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
Erik Gilling <konkers-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: [RFC PATCH 08/12] gpio/tegra: Add device tree support
Date: Mon, 15 Aug 2011 08:47:27 -0700 [thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF04AEA25048@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <CAAfyv34kOtwjerB0gMhEKNTwGd9w-LCE52MCUuvzTyYkXLY-dg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Belisko Marek wrote at Saturday, August 13, 2011 3:49 AM:
> On Sat, Aug 13, 2011 at 12:54 AM, Stephen Warren <swarren@nvidia.com> wrote:
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
> > ---
> > drivers/gpio/gpio-tegra.c | 31 +++++++++++++++++++++++++++++++
> > 1 files changed, 31 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
...
> > +static void __init tegra_gpio_probe_dt(struct platform_device *pdev)
> > +{
> > + const __be32 *gpios;
> > + u32 gpioslen;
> > + int i;
> > +
> > + gpios = of_get_property(pdev->dev.of_node, "nvidia,gpios", &gpioslen);
> > + if (gpios == NULL)
> > + return;
> > +
> > + gpioslen /= sizeof(*gpios);
> > + for (i = 0; i < gpioslen; i++, gpios++) {
> > + u32 gpio = be32_to_cpup(gpios);
> > + dev_err(&pdev->dev, "Enabling GPIO %d\n", gpio);
>
> Is really necessary to print all enabled gpio's to console? Also seen
> same in pinmux probe.
Oops, that's certainly not necessary. That was debugging code, and I meant
to convert to dev_dbg before posting.
--
nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@nvidia.com>
To: Belisko Marek <marek.belisko@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Colin Cross <ccross@android.com>,
Erik Gilling <konkers@android.com>,
Olof Johansson <olof@lixom.net>,
Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH 08/12] gpio/tegra: Add device tree support
Date: Mon, 15 Aug 2011 08:47:27 -0700 [thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF04AEA25048@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <CAAfyv34kOtwjerB0gMhEKNTwGd9w-LCE52MCUuvzTyYkXLY-dg@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1364 bytes --]
Belisko Marek wrote at Saturday, August 13, 2011 3:49 AM:
> On Sat, Aug 13, 2011 at 12:54 AM, Stephen Warren <swarren@nvidia.com> wrote:
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
> > ---
> > Â drivers/gpio/gpio-tegra.c | Â 31 +++++++++++++++++++++++++++++++
> > Â 1 files changed, 31 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
...
> > +static void __init tegra_gpio_probe_dt(struct platform_device *pdev)
> > +{
> > + Â Â Â const __be32 *gpios;
> > + Â Â Â u32 gpioslen;
> > + Â Â Â int i;
> > +
> > + Â Â Â gpios = of_get_property(pdev->dev.of_node, "nvidia,gpios", &gpioslen);
> > + Â Â Â if (gpios == NULL)
> > + Â Â Â Â Â Â Â return;
> > +
> > + Â Â Â gpioslen /= sizeof(*gpios);
> > + Â Â Â for (i = 0; i < gpioslen; i++, gpios++) {
> > + Â Â Â Â Â Â Â u32 gpio = be32_to_cpup(gpios);
> > + Â Â Â Â Â Â Â dev_err(&pdev->dev, "Enabling GPIO %d\n", gpio);
>
> Is really necessary to print all enabled gpio's to console? Also seen
> same in pinmux probe.
Oops, that's certainly not necessary. That was debugging code, and I meant
to convert to dev_dbg before posting.
--
nvpublic
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
WARNING: multiple messages have this Message-ID (diff)
From: swarren@nvidia.com (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 08/12] gpio/tegra: Add device tree support
Date: Mon, 15 Aug 2011 08:47:27 -0700 [thread overview]
Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF04AEA25048@HQMAIL01.nvidia.com> (raw)
In-Reply-To: <CAAfyv34kOtwjerB0gMhEKNTwGd9w-LCE52MCUuvzTyYkXLY-dg@mail.gmail.com>
Belisko Marek wrote at Saturday, August 13, 2011 3:49 AM:
> On Sat, Aug 13, 2011 at 12:54 AM, Stephen Warren <swarren@nvidia.com> wrote:
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
> > ---
> > ?drivers/gpio/gpio-tegra.c | ? 31 +++++++++++++++++++++++++++++++
> > ?1 files changed, 31 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
...
> > +static void __init tegra_gpio_probe_dt(struct platform_device *pdev)
> > +{
> > + ? ? ? const __be32 *gpios;
> > + ? ? ? u32 gpioslen;
> > + ? ? ? int i;
> > +
> > + ? ? ? gpios = of_get_property(pdev->dev.of_node, "nvidia,gpios", &gpioslen);
> > + ? ? ? if (gpios == NULL)
> > + ? ? ? ? ? ? ? return;
> > +
> > + ? ? ? gpioslen /= sizeof(*gpios);
> > + ? ? ? for (i = 0; i < gpioslen; i++, gpios++) {
> > + ? ? ? ? ? ? ? u32 gpio = be32_to_cpup(gpios);
> > + ? ? ? ? ? ? ? dev_err(&pdev->dev, "Enabling GPIO %d\n", gpio);
>
> Is really necessary to print all enabled gpio's to console? Also seen
> same in pinmux probe.
Oops, that's certainly not necessary. That was debugging code, and I meant
to convert to dev_dbg before posting.
--
nvpublic
next prev parent reply other threads:[~2011-08-15 15:47 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 22:54 [RFC PATCH 00/12] arm/tegra: Initialize GPIO & pinmux from DT Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` Stephen Warren
[not found] ` <1313189697-21287-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-08-12 22:54 ` [RFC PATCH 01/12] dt: Add of_find_child_node_by_name() Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` [RFC PATCH 02/12] arm/tegra: Prep boards for gpio/pinmux conversion to pdevs Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` [RFC PATCH 03/12] arm/tegra: Avoid duplicate gpio/pinmux devices with dt Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` [RFC PATCH 04/12] arm/tegra: board-dt: Add AUXDATA for tegra-gpio and tegra-pinmux Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` [RFC PATCH 05/12] arm/dt: Tegra: Add nvidia, gpios property to GPIO controller Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` [RFC PATCH 05/12] arm/dt: Tegra: Add nvidia,gpios " Stephen Warren
[not found] ` <1313189697-21287-6-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-08-14 7:01 ` Olof Johansson
2011-08-14 7:01 ` Olof Johansson
2011-08-14 7:01 ` Olof Johansson
[not found] ` <CAOesGMj8firxDz-kqkh=jwsbC_QRW+YSFpf7dh3WaOhseCg91w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-15 16:15 ` Stephen Warren
2011-08-15 16:15 ` Stephen Warren
2011-08-15 16:15 ` Stephen Warren
2011-08-12 22:54 ` [RFC PATCH 06/12] arm/dt: Tegra: Add pinmux node Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` Stephen Warren
[not found] ` <1313189697-21287-7-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-08-14 7:24 ` Olof Johansson
2011-08-14 7:24 ` Olof Johansson
2011-08-14 7:24 ` Olof Johansson
[not found] ` <CAOesGMheuUfSe1uUA6LxZ71V0-DR3XX7bEJqhVxJ-ZqrWWa1bA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-15 16:41 ` Stephen Warren
2011-08-15 16:41 ` Stephen Warren
2011-08-15 16:41 ` Stephen Warren
2011-08-12 22:54 ` [RFC PATCH 07/12] gpio/tegra: Convert to a platform device Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` [RFC PATCH 08/12] gpio/tegra: Add device tree support Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` Stephen Warren
[not found] ` <1313189697-21287-9-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-08-13 9:49 ` Belisko Marek
2011-08-13 9:49 ` Belisko Marek
2011-08-13 9:49 ` Belisko Marek
[not found] ` <CAAfyv34kOtwjerB0gMhEKNTwGd9w-LCE52MCUuvzTyYkXLY-dg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-15 15:47 ` Stephen Warren [this message]
2011-08-15 15:47 ` Stephen Warren
2011-08-15 15:47 ` Stephen Warren
2011-08-12 22:54 ` [RFC PATCH 09/12] arm/tegra: Convert pinmux driver to a platform device Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` [RFC PATCH 10/12] arm/tegra: Add device tree support to pinmux driver Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` Stephen Warren
[not found] ` <1313189697-21287-11-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-08-13 10:43 ` Jamie Iles
2011-08-13 10:43 ` Jamie Iles
2011-08-13 10:43 ` Jamie Iles
2011-08-13 10:48 ` Jamie Iles
2011-08-13 10:48 ` Jamie Iles
2011-08-13 10:48 ` Jamie Iles
[not found] ` <20110813104850.GD2643-apL1N+EY0C9YtYNIL7UdTEEOCMrvLtNR@public.gmane.org>
2011-08-15 16:09 ` Stephen Warren
2011-08-15 16:09 ` Stephen Warren
2011-08-15 16:09 ` Stephen Warren
2011-08-15 20:07 ` Jamie Iles
2011-08-15 20:07 ` Jamie Iles
2011-08-15 20:07 ` Jamie Iles
2011-08-15 20:36 ` Jamie Iles
2011-08-15 20:36 ` Jamie Iles
2011-08-15 20:36 ` Jamie Iles
2011-08-15 20:44 ` Stephen Warren
2011-08-15 20:44 ` Stephen Warren
2011-08-15 20:44 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF04AEA25174-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-08-15 20:50 ` Jamie Iles
2011-08-15 20:50 ` Jamie Iles
2011-08-15 20:50 ` Jamie Iles
2011-08-12 22:54 ` [RFC PATCH 11/12] arm/tegra: board-dt: Remove dependency on non-dt pinmux functions Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` [RFC PATCH 12/12] arm/tegra: Remove temporary gpio/pinmux registration workaround Stephen Warren
2011-08-12 22:54 ` Stephen Warren
2011-08-12 22:54 ` Stephen Warren
[not found] ` <1313189697-21287-13-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-08-15 11:12 ` Sergei Shtylyov
2011-08-15 11:12 ` Sergei Shtylyov
2011-08-15 11:12 ` Sergei Shtylyov
[not found] ` <4E48FF29.1030208-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2011-08-15 16:03 ` Stephen Warren
2011-08-15 16:03 ` Stephen Warren
2011-08-15 16:03 ` Stephen Warren
2011-08-13 13:08 ` [RFC PATCH 00/12] arm/tegra: Initialize GPIO & pinmux from DT Shawn Guo
2011-08-13 13:08 ` Shawn Guo
2011-08-13 13:08 ` Shawn Guo
[not found] ` <20110813130858.GC7244-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-08-15 16:07 ` Stephen Warren
2011-08-15 16:07 ` Stephen Warren
2011-08-15 16:07 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74CDBE0F657A3D45AFBB94109FB122FF04AEA25048@HQMAIL01.nvidia.com \
--to=swarren-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=konkers-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marek.belisko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.