From: Waiman Long <longman@redhat.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Mimi Zohar <zohar@linux.ibm.com>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org,
Sumit Garg <sumit.garg@linaro.org>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Roberto Sassu <roberto.sassu@huawei.com>,
Chris von Recklinghausen <crecklin@redhat.com>
Subject: Re: [PATCH v3 3/3] KEYS: Use kvmalloc() to better handle large buffer allocation
Date: Sun, 15 Mar 2020 22:01:51 +0000 [thread overview]
Message-ID: <74ec00b8-d7a7-0035-d650-710415660926@redhat.com> (raw)
In-Reply-To: <20200315215253.GG224162@linux.intel.com>
On 3/15/20 5:52 PM, Jarkko Sakkinen wrote:
> On Fri, Mar 13, 2020 at 01:49:57PM -0400, Waiman Long wrote:
>>>> if (!tmpbuf || unlikely(ret > tmpbuflen)) {
>>>> if (unlikely(tmpbuf))
>>>> - kzfree(tmpbuf);
>>>> + __kvzfree(tmpbuf, tmpbuflen);
>>> Both kzfree() and __kvzfree() handle a NULL pointer, so there's no need for the
>>> NULL check first.
>>>
>> I would like to keep this one because of the unlikely annotation.
> What (measurable) gain does it bring anyway?
It is not a performance issue. I just want to indicate that the need to
free should not happen at all. It match the unlikely tag in the if
condition above.
Cheers,
Longman
WARNING: multiple messages have this Message-ID (diff)
From: Waiman Long <longman@redhat.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Mimi Zohar <zohar@linux.ibm.com>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org,
Sumit Garg <sumit.garg@linaro.org>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Roberto Sassu <roberto.sassu@huawei.com>,
Chris von Recklinghausen <crecklin@redhat.com>
Subject: Re: [PATCH v3 3/3] KEYS: Use kvmalloc() to better handle large buffer allocation
Date: Sun, 15 Mar 2020 18:01:51 -0400 [thread overview]
Message-ID: <74ec00b8-d7a7-0035-d650-710415660926@redhat.com> (raw)
In-Reply-To: <20200315215253.GG224162@linux.intel.com>
On 3/15/20 5:52 PM, Jarkko Sakkinen wrote:
> On Fri, Mar 13, 2020 at 01:49:57PM -0400, Waiman Long wrote:
>>>> if (!tmpbuf || unlikely(ret > tmpbuflen)) {
>>>> if (unlikely(tmpbuf))
>>>> - kzfree(tmpbuf);
>>>> + __kvzfree(tmpbuf, tmpbuflen);
>>> Both kzfree() and __kvzfree() handle a NULL pointer, so there's no need for the
>>> NULL check first.
>>>
>> I would like to keep this one because of the unlikely annotation.
> What (measurable) gain does it bring anyway?
It is not a performance issue. I just want to indicate that the need to
free should not happen at all. It match the unlikely tag in the if
condition above.
Cheers,
Longman
next prev parent reply other threads:[~2020-03-15 22:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 15:20 [PATCH v3 0/3] KEYS: Read keys to internal buffer & then copy to userspace Waiman Long
2020-03-13 15:20 ` Waiman Long
2020-03-13 15:21 ` [PATCH v3 1/3] KEYS: Don't write out to userspace while holding key semaphore Waiman Long
2020-03-13 15:21 ` Waiman Long
2020-03-15 19:21 ` Jarkko Sakkinen
2020-03-15 19:21 ` Jarkko Sakkinen
2020-03-15 21:27 ` Jarkko Sakkinen
2020-03-15 21:27 ` Jarkko Sakkinen
2020-03-16 11:22 ` David Howells
2020-03-16 13:53 ` Jarkko Sakkinen
2020-03-16 13:53 ` Jarkko Sakkinen
2020-03-16 16:33 ` Waiman Long
2020-03-16 16:33 ` Waiman Long
2020-03-17 18:10 ` Waiman Long
2020-03-17 18:10 ` Waiman Long
2020-03-16 11:34 ` David Howells
2020-03-13 15:21 ` [PATCH v3 2/3] KEYS: Avoid false positive ENOMEM error on key read Waiman Long
2020-03-13 15:21 ` Waiman Long
2020-03-15 21:32 ` Jarkko Sakkinen
2020-03-15 21:32 ` Jarkko Sakkinen
2020-03-17 18:36 ` Waiman Long
2020-03-17 18:36 ` Waiman Long
2020-03-13 15:21 ` [PATCH v3 3/3] KEYS: Use kvmalloc() to better handle large buffer allocation Waiman Long
2020-03-13 15:21 ` Waiman Long
2020-03-13 16:43 ` Eric Biggers
2020-03-13 16:43 ` Eric Biggers
2020-03-13 17:49 ` Waiman Long
2020-03-13 17:49 ` Waiman Long
2020-03-15 21:52 ` Jarkko Sakkinen
2020-03-15 21:52 ` Jarkko Sakkinen
2020-03-15 22:01 ` Waiman Long [this message]
2020-03-15 22:01 ` Waiman Long
2020-03-16 11:50 ` [PATCH v3 1/3] KEYS: Don't write out to userspace while holding key semaphore David Howells
2020-03-17 18:09 ` Waiman Long
2020-03-17 18:09 ` Waiman Long
2020-03-16 14:24 ` [PATCH v3 3/3] KEYS: Use kvmalloc() to better handle large buffer allocation David Howells
2020-03-16 15:21 ` Waiman Long
2020-03-16 15:21 ` Waiman Long
2020-03-16 22:19 ` Jarkko Sakkinen
2020-03-16 22:19 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74ec00b8-d7a7-0035-d650-710415660926@redhat.com \
--to=longman@redhat.com \
--cc=crecklin@redhat.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.