From: Suman Anna <s-anna@ti.com> To: Tero Kristo <t-kristo@ti.com>, bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, linux-omap@vger.kernel.org Subject: Re: [PATCHv3 09/15] remoteproc/omap: Remove the omap_rproc_reserve_cma declaration Date: Thu, 19 Dec 2019 20:47:37 -0600 [thread overview] Message-ID: <75420692-ecbc-f7cd-f7bc-9df0849d91dc@ti.com> (raw) In-Reply-To: <20191213125537.11509-10-t-kristo@ti.com> Hi Tero, On 12/13/19 6:55 AM, Tero Kristo wrote: > From: Suman Anna <s-anna@ti.com> > > The omap_rproc_reserve_cma() function is not defined at the moment. > This prototype was to be used to define a function to declare a > remoteproc device-specific CMA pool. > > The remoteproc devices will be defined through DT going forward. A > device specific CMA pool will be defined under the reserved-memory > node, and will be associated with the appropriate remoteproc device > node. This function prototype will no longer be needed and has > therefore been cleaned up. > > Signed-off-by: Suman Anna <s-anna@ti.com> > Signed-off-by: Tero Kristo <t-kristo@ti.com> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> With the structure removed, you can actually drop the file altogether. regards Suman > --- > include/linux/platform_data/remoteproc-omap.h | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/include/linux/platform_data/remoteproc-omap.h b/include/linux/platform_data/remoteproc-omap.h > index 6bea01e199fe..49c78805916f 100644 > --- a/include/linux/platform_data/remoteproc-omap.h > +++ b/include/linux/platform_data/remoteproc-omap.h > @@ -21,16 +21,4 @@ struct omap_rproc_pdata { > int (*device_shutdown)(struct platform_device *pdev); > }; > > -#if defined(CONFIG_OMAP_REMOTEPROC) || defined(CONFIG_OMAP_REMOTEPROC_MODULE) > - > -void __init omap_rproc_reserve_cma(void); > - > -#else > - > -static inline void __init omap_rproc_reserve_cma(void) > -{ > -} > - > -#endif > - > #endif /* _PLAT_REMOTEPROC_H */ >
WARNING: multiple messages have this Message-ID (diff)
From: Suman Anna <s-anna@ti.com> To: Tero Kristo <t-kristo@ti.com>, <bjorn.andersson@linaro.org>, <ohad@wizery.com>, <linux-remoteproc@vger.kernel.org> Cc: <linux-kernel@vger.kernel.org>, <mathieu.poirier@linaro.org>, <linux-omap@vger.kernel.org> Subject: Re: [PATCHv3 09/15] remoteproc/omap: Remove the omap_rproc_reserve_cma declaration Date: Thu, 19 Dec 2019 20:47:37 -0600 [thread overview] Message-ID: <75420692-ecbc-f7cd-f7bc-9df0849d91dc@ti.com> (raw) In-Reply-To: <20191213125537.11509-10-t-kristo@ti.com> Hi Tero, On 12/13/19 6:55 AM, Tero Kristo wrote: > From: Suman Anna <s-anna@ti.com> > > The omap_rproc_reserve_cma() function is not defined at the moment. > This prototype was to be used to define a function to declare a > remoteproc device-specific CMA pool. > > The remoteproc devices will be defined through DT going forward. A > device specific CMA pool will be defined under the reserved-memory > node, and will be associated with the appropriate remoteproc device > node. This function prototype will no longer be needed and has > therefore been cleaned up. > > Signed-off-by: Suman Anna <s-anna@ti.com> > Signed-off-by: Tero Kristo <t-kristo@ti.com> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> With the structure removed, you can actually drop the file altogether. regards Suman > --- > include/linux/platform_data/remoteproc-omap.h | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/include/linux/platform_data/remoteproc-omap.h b/include/linux/platform_data/remoteproc-omap.h > index 6bea01e199fe..49c78805916f 100644 > --- a/include/linux/platform_data/remoteproc-omap.h > +++ b/include/linux/platform_data/remoteproc-omap.h > @@ -21,16 +21,4 @@ struct omap_rproc_pdata { > int (*device_shutdown)(struct platform_device *pdev); > }; > > -#if defined(CONFIG_OMAP_REMOTEPROC) || defined(CONFIG_OMAP_REMOTEPROC_MODULE) > - > -void __init omap_rproc_reserve_cma(void); > - > -#else > - > -static inline void __init omap_rproc_reserve_cma(void) > -{ > -} > - > -#endif > - > #endif /* _PLAT_REMOTEPROC_H */ >
next prev parent reply other threads:[~2019-12-20 2:47 UTC|newest] Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-13 12:55 [PATCHv3 00/15] remoteproc: updates for omap remoteproc support Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-13 12:55 ` [PATCHv3 01/15] dt-bindings: remoteproc: Add OMAP remoteproc bindings Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-20 3:38 ` Suman Anna 2019-12-20 3:38 ` Suman Anna 2019-12-13 12:55 ` [PATCHv3 02/15] remoteproc/omap: Add device tree support Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-17 23:01 ` Mathieu Poirier 2019-12-19 11:54 ` Tero Kristo 2019-12-19 11:54 ` Tero Kristo 2019-12-20 2:08 ` Suman Anna 2019-12-20 2:08 ` Suman Anna 2019-12-20 9:36 ` Tero Kristo 2019-12-20 9:36 ` Tero Kristo 2019-12-20 18:17 ` Suman Anna 2019-12-20 18:17 ` Suman Anna 2019-12-13 12:55 ` [PATCHv3 03/15] remoteproc/omap: Add a sanity check for DSP boot address alignment Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-13 12:55 ` [PATCHv3 04/15] remoteproc/omap: Add support to parse internal memories from DT Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-18 0:22 ` Mathieu Poirier 2019-12-19 12:31 ` Tero Kristo 2019-12-19 12:31 ` Tero Kristo 2019-12-19 17:37 ` Mathieu Poirier 2019-12-20 2:15 ` Suman Anna 2019-12-20 2:15 ` Suman Anna 2019-12-13 12:55 ` [PATCHv3 05/15] remoteproc/omap: Add the rproc ops .da_to_va() implementation Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-18 0:38 ` Mathieu Poirier 2019-12-19 13:18 ` Tero Kristo 2019-12-19 13:18 ` Tero Kristo 2019-12-20 0:12 ` Mathieu Poirier 2019-12-20 2:34 ` Suman Anna 2019-12-20 2:34 ` Suman Anna 2019-12-20 22:15 ` Mathieu Poirier 2019-12-13 12:55 ` [PATCHv3 06/15] remoteproc/omap: Initialize and assign reserved memory node Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-13 12:55 ` [PATCHv3 07/15] remoteproc/omap: Add support for DRA7xx remote processors Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-18 21:31 ` Mathieu Poirier 2019-12-19 13:29 ` Tero Kristo 2019-12-19 13:29 ` Tero Kristo 2019-12-13 12:55 ` [PATCHv3 08/15] remoteproc/omap: Remove the unused fields from platform data Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-20 2:44 ` Suman Anna 2019-12-20 2:44 ` Suman Anna 2019-12-20 9:48 ` Tero Kristo 2019-12-20 9:48 ` Tero Kristo 2019-12-13 12:55 ` [PATCHv3 09/15] remoteproc/omap: Remove the omap_rproc_reserve_cma declaration Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-20 2:47 ` Suman Anna [this message] 2019-12-20 2:47 ` Suman Anna 2019-12-20 9:49 ` Tero Kristo 2019-12-20 9:49 ` Tero Kristo 2019-12-13 12:55 ` [PATCHv3 10/15] remoteproc/omap: Check for undefined mailbox messages Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-13 12:55 ` [PATCHv3 11/15] remoteproc/omap: Request a timer(s) for remoteproc usage Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-18 22:43 ` Mathieu Poirier 2019-12-19 13:43 ` Tero Kristo 2019-12-19 13:43 ` Tero Kristo 2019-12-13 12:55 ` [PATCHv3 12/15] remoteproc/omap: add support for system suspend/resume Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-19 21:46 ` Mathieu Poirier 2019-12-20 3:11 ` Suman Anna 2019-12-20 3:11 ` Suman Anna 2019-12-20 11:04 ` Tero Kristo 2019-12-20 11:04 ` Tero Kristo 2019-12-20 18:23 ` Suman Anna 2019-12-20 18:23 ` Suman Anna 2019-12-20 21:58 ` Mathieu Poirier 2019-12-13 12:55 ` [PATCHv3 13/15] remoteproc/omap: add support for runtime auto-suspend/resume Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-19 23:43 ` Mathieu Poirier 2019-12-20 3:24 ` Suman Anna 2019-12-20 3:24 ` Suman Anna 2019-12-20 11:24 ` Tero Kristo 2019-12-20 11:24 ` Tero Kristo 2019-12-20 18:44 ` Suman Anna 2019-12-20 18:44 ` Suman Anna 2020-01-02 12:50 ` Tero Kristo 2020-01-02 12:50 ` Tero Kristo 2019-12-20 11:08 ` Tero Kristo 2019-12-20 11:08 ` Tero Kristo 2019-12-13 12:55 ` [PATCHv3 14/15] remoteproc/omap: report device exceptions and trigger recovery Tero Kristo 2019-12-13 12:55 ` Tero Kristo 2019-12-13 12:55 ` [PATCHv3 15/15] remoteproc/omap: add watchdog functionality for remote processors Tero Kristo 2019-12-13 12:55 ` Tero Kristo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=75420692-ecbc-f7cd-f7bc-9df0849d91dc@ti.com \ --to=s-anna@ti.com \ --cc=bjorn.andersson@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=ohad@wizery.com \ --cc=t-kristo@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.