Re: [PATCH 9/9] RFC: Everything else

From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 9/9] RFC: Everything else
Date: Thu, 30 Mar 2023 12:16:54 +0200	[thread overview]
Message-ID: <758615c4-bee6-32fd-0475-0c3c3bb7debe@suse.com> (raw)
In-Reply-To: <20230329205137.323253-10-andrew.cooper3@citrix.com>

On 29.03.2023 22:51, Andrew Cooper wrote:
> Looking at this diff, I'm wondering whether keeping
> 
>     union {
>         struct cpu_policy *cpuid;
>         struct cpu_policy *cpu_policy;
>     };
> 
> permentantly might be a good idea, because d->arch.cpuid->$X reads rather
> better than d->arch.cpu_policy->$X
> 
> Thoughts?

I'm not overly fussed, but perhaps yes. Nevertheless e.g. ...

> --- a/tools/fuzz/x86_instruction_emulator/fuzz-emul.c
> +++ b/tools/fuzz/x86_instruction_emulator/fuzz-emul.c
> @@ -893,7 +893,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data_p, size_t size)
>      struct x86_emulate_ctxt ctxt = {
>          .data = &state,
>          .regs = &input.regs,
> -        .cpuid = &cp,
> +        .cpu_policy = &cp,

... this and ...

> --- a/tools/tests/x86_emulator/test_x86_emulator.c
> +++ b/tools/tests/x86_emulator/test_x86_emulator.c
> @@ -909,7 +909,7 @@ int main(int argc, char **argv)
>  
>      ctxt.regs = &regs;
>      ctxt.force_writeback = 0;
> -    ctxt.cpuid     = &cp;
> +    ctxt.cpu_policy = &cp;

... this imo want keeping as you have it here.

Jan