From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 8/9] x86: Drop struct old_cpu_policy
Date: Thu, 30 Mar 2023 12:57:35 +0100 [thread overview]
Message-ID: <85202e61-a5fd-e0a0-84be-2f56e5defe00@citrix.com> (raw)
In-Reply-To: <03feb32e-4318-37cc-cb08-16402d4ea430@suse.com>
On 30/03/2023 11:08 am, Jan Beulich wrote:
> On 29.03.2023 22:51, Andrew Cooper wrote:
>> --- a/tools/libs/guest/xg_cpuid_x86.c
>> +++ b/tools/libs/guest/xg_cpuid_x86.c
>> @@ -868,9 +868,7 @@ bool xc_cpu_policy_is_compatible(xc_interface *xch, xc_cpu_policy_t *host,
>> xc_cpu_policy_t *guest)
>> {
>> struct cpu_policy_errors err = INIT_CPU_POLICY_ERRORS;
>> - struct old_cpu_policy h = { &host->policy, &host->policy };
>> - struct old_cpu_policy g = { &guest->policy, &guest->policy };
>> - int rc = x86_cpu_policies_are_compatible(&h, &g, &err);
>> + int rc = x86_cpu_policies_are_compatible(&host->policy, &host->policy, &err);
> One of the two surely wants to be &guest->policy?
Ah, yes it does. The second, specifically.
(One of the problems of having an API that's not used by anything
interesting yet.)
~Andrew
next prev parent reply other threads:[~2023-03-30 11:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 20:51 [PATCH RFC 0/9] x86: Merge cpuid and msr policy Andrew Cooper
2023-03-29 20:51 ` [PATCH 1/9] x86: Rename struct cpu_policy to struct old_cpuid_policy Andrew Cooper
2023-03-29 20:51 ` [PATCH 2/9] x86: Rename {domctl,sysctl}.cpu_policy.{cpuid,msr_policy} fields Andrew Cooper
2023-03-29 20:51 ` [PATCH 3/9] x86: Rename struct cpuid_policy to struct cpu_policy Andrew Cooper
2023-03-29 20:51 ` [PATCH 4/9] x86: Merge struct msr_policy into " Andrew Cooper
2023-03-30 9:30 ` Jan Beulich
2023-03-30 11:11 ` Andrew Cooper
2023-03-30 11:15 ` Jan Beulich
2023-03-29 20:51 ` [PATCH 5/9] x86: Merge the system {cpuid,msr} policy objects Andrew Cooper
2023-03-30 9:40 ` Jan Beulich
2023-03-30 11:19 ` Andrew Cooper
2023-03-29 20:51 ` [PATCH 6/9] x86: Merge a domain's " Andrew Cooper
2023-03-30 10:00 ` Jan Beulich
2023-03-30 11:14 ` Andrew Cooper
2023-03-29 20:51 ` [PATCH 7/9] x86: Merge xc_cpu_policy's cpuid and msr objects Andrew Cooper
2023-03-30 10:04 ` Jan Beulich
2023-03-30 11:56 ` Andrew Cooper
2023-03-29 20:51 ` [PATCH 8/9] x86: Drop struct old_cpu_policy Andrew Cooper
2023-03-30 10:08 ` Jan Beulich
2023-03-30 11:57 ` Andrew Cooper [this message]
2023-03-29 20:51 ` [PATCH 9/9] RFC: Everything else Andrew Cooper
2023-03-30 10:16 ` Jan Beulich
2023-03-30 12:01 ` Andrew Cooper
2023-03-30 12:06 ` Jan Beulich
2023-03-30 12:31 ` Andrew Cooper
2023-03-30 12:55 ` Jan Beulich
2023-03-30 10:18 ` [PATCH RFC 0/9] x86: Merge cpuid and msr policy Jan Beulich
2023-03-30 12:08 ` Andrew Cooper
2023-03-30 11:07 ` Roger Pau Monné
2023-03-30 12:59 ` Andrew Cooper
2023-03-30 14:43 ` Roger Pau Monné
2023-04-03 10:55 ` Andrew Cooper
2023-04-03 11:47 ` Roger Pau Monné
2023-04-03 11:48 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85202e61-a5fd-e0a0-84be-2f56e5defe00@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.