All of lore.kernel.org
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Matthias Brugger" <matthias.bgg@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org, kernel@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Jyri Sarha <jyri.sarha@iki.fi>
Subject: Re: [PATCH v2 07/12] drm/mediatek: Convert to platform remove callback returning void
Date: Tue, 1 Aug 2023 14:59:32 +0200	[thread overview]
Message-ID: <75ebcfa1-2413-76b0-4573-0ebf70fa59ad@collabora.com> (raw)
In-Reply-To: <20230801110239.831099-8-u.kleine-koenig@pengutronix.de>

Il 01/08/23 13:02, Uwe Kleine-König ha scritto:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert the mediatek drm drivers from always returning zero in
> the remove callback to the void returning variant.
> 
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reviewed-by: Jyri Sarha <jyri.sarha@iki.fi>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>




WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Matthias Brugger" <matthias.bgg@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org, kernel@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Jyri Sarha <jyri.sarha@iki.fi>
Subject: Re: [PATCH v2 07/12] drm/mediatek: Convert to platform remove callback returning void
Date: Tue, 1 Aug 2023 14:59:32 +0200	[thread overview]
Message-ID: <75ebcfa1-2413-76b0-4573-0ebf70fa59ad@collabora.com> (raw)
In-Reply-To: <20230801110239.831099-8-u.kleine-koenig@pengutronix.de>

Il 01/08/23 13:02, Uwe Kleine-König ha scritto:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert the mediatek drm drivers from always returning zero in
> the remove callback to the void returning variant.
> 
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reviewed-by: Jyri Sarha <jyri.sarha@iki.fi>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Matthias Brugger" <matthias.bgg@gmail.com>
Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Jyri Sarha <jyri.sarha@iki.fi>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 07/12] drm/mediatek: Convert to platform remove callback returning void
Date: Tue, 1 Aug 2023 14:59:32 +0200	[thread overview]
Message-ID: <75ebcfa1-2413-76b0-4573-0ebf70fa59ad@collabora.com> (raw)
In-Reply-To: <20230801110239.831099-8-u.kleine-koenig@pengutronix.de>

Il 01/08/23 13:02, Uwe Kleine-König ha scritto:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert the mediatek drm drivers from always returning zero in
> the remove callback to the void returning variant.
> 
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reviewed-by: Jyri Sarha <jyri.sarha@iki.fi>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



  reply	other threads:[~2023-08-01 12:59 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01 11:02 [Nouveau] [PATCH v2 00/12] drm: Convert to platform remove callback returning void Uwe Kleine-König
2023-08-01 11:02 ` Uwe Kleine-König
2023-08-01 11:02 ` Uwe Kleine-König
2023-08-01 11:02 ` [PATCH v2 01/12] drm/armada: " Uwe Kleine-König
2023-08-01 11:02 ` [PATCH v2 02/12] drm/etnaviv: " Uwe Kleine-König
2023-09-09 18:49   ` Christian Gmeiner
2023-08-01 11:02 ` [PATCH v2 03/12] drm/imx/dcss: " Uwe Kleine-König
2023-08-01 11:02   ` Uwe Kleine-König
2023-08-01 11:02 ` [PATCH v2 04/12] drm/imx/ipuv3: " Uwe Kleine-König
2023-08-01 11:02   ` Uwe Kleine-König
2023-08-01 11:02 ` [PATCH v2 05/12] drm/ingenic: " Uwe Kleine-König
2023-08-01 11:02   ` Uwe Kleine-König
2023-08-01 11:02 ` [PATCH v2 06/12] drm/kmb: " Uwe Kleine-König
2023-08-01 11:02 ` [PATCH v2 07/12] drm/mediatek: " Uwe Kleine-König
2023-08-01 11:02   ` Uwe Kleine-König
2023-08-01 11:02   ` Uwe Kleine-König
2023-08-01 12:59   ` AngeloGioacchino Del Regno [this message]
2023-08-01 12:59     ` AngeloGioacchino Del Regno
2023-08-01 12:59     ` AngeloGioacchino Del Regno
2023-08-01 11:02 ` [PATCH v2 08/12] drm/msm: " Uwe Kleine-König
2023-08-01 11:02   ` Uwe Kleine-König
2023-08-01 11:02 ` [Nouveau] [PATCH v2 09/12] drm/nouveau: " Uwe Kleine-König
2023-08-01 11:02   ` Uwe Kleine-König
2023-08-01 11:02 ` [PATCH v2 10/12] drm/shmobile: " Uwe Kleine-König
2023-08-01 11:02   ` Uwe Kleine-König
2023-08-01 11:02 ` [PATCH v2 11/12] drm/sprd: " Uwe Kleine-König
2023-08-01 11:02 ` [PATCH v2 12/12] drm/arcpgu: " Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75ebcfa1-2413-76b0-4573-0ebf70fa59ad@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=airlied@gmail.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jyri.sarha@iki.fi \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=tzimmermann@suse.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.