From: Marc Gonzalez <marc.w.gonzalez@free.fr> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Stephen Boyd <sboyd@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, Russell King <linux@armlinux.org.uk>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Guenter Roeck <linux@roeck-us.net>, Bjorn Andersson <bjorn.andersson@linaro.org>, Robin Murphy <robin.murphy@arm.com>, Arnd Bergmann <arnd@arndb.de>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rafael Wysocki <rjw@rjwysocki.net>, Suzuki Poulose <suzuki.poulose@arm.com>, Mark Rutland <mark.rutland@arm.com>, linux-clk <linux-clk@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [RFC PATCH v4 2/2] clk: Use devm_add in managed functions Date: Mon, 2 Mar 2020 11:01:45 +0100 [thread overview] Message-ID: <7622db71-b1f4-62b4-86ee-78e00d5bd52c@free.fr> (raw) In-Reply-To: <CAMuHMdUZfR6pYG-hourZCKT-jhh1t+x-ySF4JnEPJjscGAQT+A@mail.gmail.com> On 27/02/2020 14:36, Geert Uytterhoeven wrote: > Hi Marc, > > Thanks for your patch! > > On Wed, Feb 26, 2020 at 4:55 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote: >> Using the helper produces simpler code, and smaller object size. >> E.g. with gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu: >> >> text data bss dec hex filename >> - 1708 80 0 1788 6fc drivers/clk/clk-devres.o >> + 1524 80 0 1604 644 drivers/clk/clk-devres.o > > And the size reduction could have been even more ;-) I'll see what I can do! ;-) I have another patch with even smaller object code, but it requires C11 to be well-defined (memcmp the whole struct, which requires zeros in the padding holes). >> --- a/drivers/clk/clk-devres.c >> +++ b/drivers/clk/clk-devres.c > >> @@ -55,25 +51,17 @@ static void devm_clk_bulk_release(struct device *dev, void *res) >> static int __devm_clk_bulk_get(struct device *dev, int num_clks, >> struct clk_bulk_data *clks, bool optional) >> { >> - struct clk_bulk_devres *devres; >> int ret; >> >> - devres = devres_alloc(devm_clk_bulk_release, >> - sizeof(*devres), GFP_KERNEL); >> - if (!devres) >> - return -ENOMEM; >> - >> if (optional) >> ret = clk_bulk_get_optional(dev, num_clks, clks); >> else >> ret = clk_bulk_get(dev, num_clks, clks); >> - if (!ret) { >> - devres->clks = clks; >> - devres->num_clks = num_clks; >> - devres_add(dev, devres); >> - } else { >> - devres_free(devres); >> - } >> + >> + if (ret) >> + return ret; >> + >> + ret = devm_vadd(dev, my_clk_bulk_put, clk_bulk_args, num_clks, clks); >> >> return ret; > > return devm_vadd(...); If you think that makes it look better, I'll make the change! >> @@ -128,30 +109,22 @@ static int devm_clk_match(struct device *dev, void *res, void *data) >> >> void devm_clk_put(struct device *dev, struct clk *clk) >> { >> - int ret; >> - >> - ret = devres_release(dev, devm_clk_release, devm_clk_match, clk); >> - >> - WARN_ON(ret); >> + WARN_ON(devres_release(dev, my_clk_put, devm_clk_match, clk)); > > Getting rid of "ret" is an unrelated change, which actually increases > kernel size, as the WARN_ON() parameter is stringified for the warning > message. Weird... Are you sure about that? I built the preprocessed file, and it didn't appear to be so. #ifndef WARN_ON #define WARN_ON(condition) ({ \ int __ret_warn_on = !!(condition); \ if (unlikely(__ret_warn_on)) \ __WARN(); \ unlikely(__ret_warn_on); \ }) #endif Maybe you were thinking of i915's WARN_ON? #define WARN_ON(x) WARN((x), "%s", "WARN_ON(" __stringify(x) ")") Regards.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Gonzalez <marc.w.gonzalez@free.fr> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Mark Rutland <mark.rutland@arm.com>, linux-clk <linux-clk@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Stephen Boyd <sboyd@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Michael Turquette <mturquette@baylibre.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Rafael Wysocki <rjw@rjwysocki.net>, Russell King <linux@armlinux.org.uk>, Bjorn Andersson <bjorn.andersson@linaro.org>, Suzuki Poulose <suzuki.poulose@arm.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Robin Murphy <robin.murphy@arm.com>, Sudip Mukherjee <sudipm.mukherjee@gmail.com>, Guenter Roeck <linux@roeck-us.net> Subject: Re: [RFC PATCH v4 2/2] clk: Use devm_add in managed functions Date: Mon, 2 Mar 2020 11:01:45 +0100 [thread overview] Message-ID: <7622db71-b1f4-62b4-86ee-78e00d5bd52c@free.fr> (raw) In-Reply-To: <CAMuHMdUZfR6pYG-hourZCKT-jhh1t+x-ySF4JnEPJjscGAQT+A@mail.gmail.com> On 27/02/2020 14:36, Geert Uytterhoeven wrote: > Hi Marc, > > Thanks for your patch! > > On Wed, Feb 26, 2020 at 4:55 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote: >> Using the helper produces simpler code, and smaller object size. >> E.g. with gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu: >> >> text data bss dec hex filename >> - 1708 80 0 1788 6fc drivers/clk/clk-devres.o >> + 1524 80 0 1604 644 drivers/clk/clk-devres.o > > And the size reduction could have been even more ;-) I'll see what I can do! ;-) I have another patch with even smaller object code, but it requires C11 to be well-defined (memcmp the whole struct, which requires zeros in the padding holes). >> --- a/drivers/clk/clk-devres.c >> +++ b/drivers/clk/clk-devres.c > >> @@ -55,25 +51,17 @@ static void devm_clk_bulk_release(struct device *dev, void *res) >> static int __devm_clk_bulk_get(struct device *dev, int num_clks, >> struct clk_bulk_data *clks, bool optional) >> { >> - struct clk_bulk_devres *devres; >> int ret; >> >> - devres = devres_alloc(devm_clk_bulk_release, >> - sizeof(*devres), GFP_KERNEL); >> - if (!devres) >> - return -ENOMEM; >> - >> if (optional) >> ret = clk_bulk_get_optional(dev, num_clks, clks); >> else >> ret = clk_bulk_get(dev, num_clks, clks); >> - if (!ret) { >> - devres->clks = clks; >> - devres->num_clks = num_clks; >> - devres_add(dev, devres); >> - } else { >> - devres_free(devres); >> - } >> + >> + if (ret) >> + return ret; >> + >> + ret = devm_vadd(dev, my_clk_bulk_put, clk_bulk_args, num_clks, clks); >> >> return ret; > > return devm_vadd(...); If you think that makes it look better, I'll make the change! >> @@ -128,30 +109,22 @@ static int devm_clk_match(struct device *dev, void *res, void *data) >> >> void devm_clk_put(struct device *dev, struct clk *clk) >> { >> - int ret; >> - >> - ret = devres_release(dev, devm_clk_release, devm_clk_match, clk); >> - >> - WARN_ON(ret); >> + WARN_ON(devres_release(dev, my_clk_put, devm_clk_match, clk)); > > Getting rid of "ret" is an unrelated change, which actually increases > kernel size, as the WARN_ON() parameter is stringified for the warning > message. Weird... Are you sure about that? I built the preprocessed file, and it didn't appear to be so. #ifndef WARN_ON #define WARN_ON(condition) ({ \ int __ret_warn_on = !!(condition); \ if (unlikely(__ret_warn_on)) \ __WARN(); \ unlikely(__ret_warn_on); \ }) #endif Maybe you were thinking of i915's WARN_ON? #define WARN_ON(x) WARN((x), "%s", "WARN_ON(" __stringify(x) ")") Regards. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-02 10:01 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-26 15:44 [RFC PATCH v4 0/2] Small devm helper for devm implementations Marc Gonzalez 2020-02-26 15:44 ` Marc Gonzalez 2020-02-26 15:49 ` [RFC PATCH v4 1/2] devres: Provide new helper for devm functions Marc Gonzalez 2020-02-26 15:49 ` Marc Gonzalez 2020-02-27 13:28 ` Geert Uytterhoeven 2020-02-27 13:28 ` Geert Uytterhoeven 2020-02-26 15:51 ` [RFC PATCH v4 2/2] clk: Use devm_add in managed functions Marc Gonzalez 2020-02-26 15:51 ` Marc Gonzalez 2020-02-27 13:36 ` Geert Uytterhoeven 2020-02-27 13:36 ` Geert Uytterhoeven 2020-03-02 10:01 ` Marc Gonzalez [this message] 2020-03-02 10:01 ` Marc Gonzalez 2020-03-02 10:14 ` Geert Uytterhoeven 2020-03-02 10:14 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7622db71-b1f4-62b4-86ee-78e00d5bd52c@free.fr \ --to=marc.w.gonzalez@free.fr \ --cc=ard.biesheuvel@linaro.org \ --cc=arnd@arndb.de \ --cc=bjorn.andersson@linaro.org \ --cc=dmitry.torokhov@gmail.com \ --cc=geert@linux-m68k.org \ --cc=gregkh@linuxfoundation.org \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=linux@roeck-us.net \ --cc=mark.rutland@arm.com \ --cc=mturquette@baylibre.com \ --cc=rjw@rjwysocki.net \ --cc=robin.murphy@arm.com \ --cc=sboyd@kernel.org \ --cc=sudipm.mukherjee@gmail.com \ --cc=suzuki.poulose@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.