Re: [PATCH i-g-t 3/4] igt_kms: Do not reset plane position on assigning a fb

From: "Konduru, Chandra" <chandra.konduru@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	"Intel-gfx@lists.freedesktop.org"
	<Intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t 3/4] igt_kms: Do not reset plane position on assigning a fb
Date: Wed, 6 May 2015 19:02:00 +0000	[thread overview]
Message-ID: <76A9B330A4D78C4D99CB292C4CC06C0E36FC71BE@fmsmsx101.amr.corp.intel.com> (raw)
In-Reply-To: <1430819603-492-3-git-send-email-tvrtko.ursulin@linux.intel.com>

> diff --git a/lib/igt_kms.c b/lib/igt_kms.c index b5ba273..0665d70 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1765,9 +1765,7 @@ void igt_plane_set_fb(igt_plane_t *plane, struct
> igt_fb *fb)
>  	plane->fb = fb;
>  	/* hack to keep tests working that don't call igt_plane_set_size() */
>  	if (fb) {
> -		/* set default plane pos/size as fb size */
> -		plane->crtc_x = 0;
> -		plane->crtc_y = 0;
Reason for doing this is to make existing kms tests to run without modification.
Otherwise every existing test has to explicitly call igt_plane_set_position to make
sure it works. Can you make sure removing above 2 lines doesn't break existing tests?

By the way, instead of this, did you look at the option of changing kms_rotation_crc 
to set plane position to whatever required when fb is changed.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx