Re: [PATCH i-g-t 2/4] igt_kms: Merge condition in igt_plane_set_fb

From: "Konduru, Chandra" <chandra.konduru@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	"Intel-gfx@lists.freedesktop.org"
	<Intel-gfx@lists.freedesktop.org>
Cc: "Wood, Thomas" <thomas.wood@intel.com>
Subject: Re: [PATCH i-g-t 2/4] igt_kms: Merge condition in igt_plane_set_fb
Date: Wed, 6 May 2015 20:56:30 +0000	[thread overview]
Message-ID: <76A9B330A4D78C4D99CB292C4CC06C0E36FC7484@fmsmsx101.amr.corp.intel.com> (raw)
In-Reply-To: <1430819603-492-2-git-send-email-tvrtko.ursulin@linux.intel.com>

> @@ -1765,14 +1765,6 @@ void igt_plane_set_fb(igt_plane_t *plane, struct
> igt_fb *fb)
>  	plane->fb = fb;
>  	/* hack to keep tests working that don't call igt_plane_set_size() */
>  	if (fb) {
> -		plane->crtc_w = fb->width;
> -		plane->crtc_h = fb->height;
> -	} else {
> -		plane->crtc_w = 0;
> -		plane->crtc_h = 0;
> -	}
> -
> -	if (fb) {
>  		/* set default plane pos/size as fb size */
>  		plane->crtc_x = 0;
>  		plane->crtc_y = 0;
> @@ -1784,6 +1776,9 @@ void igt_plane_set_fb(igt_plane_t *plane, struct
> igt_fb *fb)
>  		fb->src_y = 0;
>  		fb->src_w = fb->width;
>  		fb->src_h = fb->height;
> +	} else {
> +		plane->crtc_w = 0;
> +		plane->crtc_h = 0;
>  	}
Existing code is simply setting fb src position and plane crtc position to 0s (top left)
and src size as fb size and crtc size as plane size to start a fb with a plane. Then individual
test can change them to whatever fb position/size and plane position/size as it wants.
As I commented to 3/4 patch, if these initializations are removed, then all tests to be
updated to explicitly set them.

As a side note, is there any reason for having two patches 2/4 and 3/4 modifying
same lines of code instead of a single patch?

> 
>  	plane->fb_changed = true;
> --
> 2.3.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx