Re: [Qemu-devel] [RFC 3/6] vhost-net: Expose vhost_net_get_fd

From: Jason Wang <jasowang@redhat.com>
To: Sameeh Jubran <sameeh@daynix.com>, qemu-devel@nongnu.org
Cc: Yan Vugenfirer <yan@daynix.com>
Subject: Re: [Qemu-devel] [RFC 3/6] vhost-net: Expose vhost_net_get_fd
Date: Mon, 3 Sep 2018 11:24:39 +0800	[thread overview]
Message-ID: <76fd34e6-3055-1832-0b6c-4728d583a284@redhat.com> (raw)
In-Reply-To: <20180830142708.14311-4-sameeh@daynix.com>

On 2018年08月30日 22:27, Sameeh Jubran wrote:
> From: Sameeh Jubran <sjubran@redhat.com>
>
> Signed-off-by: Sameeh Jubran <sjubran@redhat.com>

Better explain the motivation in the commit log.

Thanks

> ---
>   hw/net/vhost_net.c             | 2 +-
>   include/hw/virtio/virtio-net.h | 2 ++
>   2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index e037db63a3..c0bff725c9 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -129,7 +129,7 @@ uint64_t vhost_net_get_acked_features(VHostNetState *net)
>       return net->dev.acked_features;
>   }
>   
> -static int vhost_net_get_fd(NetClientState *backend)
> +int vhost_net_get_fd(NetClientState *backend)
>   {
>       switch (backend->info->type) {
>       case NET_CLIENT_DRIVER_TAP:
> diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h
> index 02484dc94c..a7b53edc96 100644
> --- a/include/hw/virtio/virtio-net.h
> +++ b/include/hw/virtio/virtio-net.h
> @@ -107,4 +107,6 @@ typedef struct VirtIONet {
>   void virtio_net_set_netclient_name(VirtIONet *n, const char *name,
>                                      const char *type);
>   
> +int vhost_net_get_fd(NetClientState *backend);
> +
>   #endif