Re: [Qemu-devel] [RFC 1/6] Add bpf support to qemu

From: Sameeh Jubran <sameeh@daynix.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Yan Vugenfirer" <yan@daynix.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC 1/6] Add bpf support to qemu
Date: Mon, 3 Sep 2018 15:28:05 +0300	[thread overview]
Message-ID: <CAKPgXcEdD9uJVYK8rFLEs_g1=+tNW_LiSy9p4wySkhsnC_rZCQ@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA8HATZQqawAX3=OPmas6uzp0UAciK7QXo=uuRbCfvUjaQ@mail.gmail.com>

On Mon, Sep 3, 2018 at 3:24 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 3 September 2018 at 12:59, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
>>>  ##########################################
>>> +# check for usable bpf system call
>>> +if test "$bpf" = "yes"; then
>>
>> if test "x$bpf" != "xno"; then
>
> We don't use the leading-x thingy elsewhere in configure,
> why is this condition special?
> (We can assume we don't have a broken shell, and we
> know that $bpf won't be a string starting with a hyphen.)
That's what Daniel suggested and I though it should be good for the
reasons above. You have good points as well. Both approaches are okay
with me :)
>
> thanks
> -- PMM


-- 
Respectfully,
Sameeh Jubran
Linkedin
Software Engineer @ Daynix.