From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Bjorn Andersson <andersson@kernel.org>,
<linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>,
Yongqin Liu <yongqin.liu@linaro.org>
Subject: Re: [PATCH 1/2] drm/msm/dpu: do not enable color-management if DSPPs are not available
Date: Mon, 12 Jun 2023 11:42:18 -0700 [thread overview]
Message-ID: <7723b34b-b55b-5bcc-beb5-645ccf54d216@quicinc.com> (raw)
In-Reply-To: <20230612182534.3345805-1-dmitry.baryshkov@linaro.org>
On 6/12/2023 11:25 AM, Dmitry Baryshkov wrote:
> We can not support color management without DSPP blocks being provided
> in the HW catalog. Do not enable color management for CRTCs if num_dspps
> is 0.
>
> Fixes: 4259ff7ae509 ("drm/msm/dpu: add support for pcc color block in dpu driver")
> Reported-by: Yongqin Liu <yongqin.liu@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
LGTM,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
WARNING: multiple messages have this Message-ID (diff)
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
dri-devel@lists.freedesktop.org,
Stephen Boyd <swboyd@chromium.org>,
Yongqin Liu <yongqin.liu@linaro.org>
Subject: Re: [PATCH 1/2] drm/msm/dpu: do not enable color-management if DSPPs are not available
Date: Mon, 12 Jun 2023 11:42:18 -0700 [thread overview]
Message-ID: <7723b34b-b55b-5bcc-beb5-645ccf54d216@quicinc.com> (raw)
In-Reply-To: <20230612182534.3345805-1-dmitry.baryshkov@linaro.org>
On 6/12/2023 11:25 AM, Dmitry Baryshkov wrote:
> We can not support color management without DSPP blocks being provided
> in the HW catalog. Do not enable color management for CRTCs if num_dspps
> is 0.
>
> Fixes: 4259ff7ae509 ("drm/msm/dpu: add support for pcc color block in dpu driver")
> Reported-by: Yongqin Liu <yongqin.liu@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
LGTM,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
next prev parent reply other threads:[~2023-06-12 18:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 18:25 [PATCH 1/2] drm/msm/dpu: do not enable color-management if DSPPs are not available Dmitry Baryshkov
2023-06-12 18:25 ` Dmitry Baryshkov
2023-06-12 18:25 ` [PATCH 2/2] drm/msm/dpu/catalog: define DSPP blocks found on sdm845 Dmitry Baryshkov
2023-06-12 18:25 ` Dmitry Baryshkov
2023-06-12 19:35 ` Abhinav Kumar
2023-06-12 19:35 ` Abhinav Kumar
2023-06-12 19:39 ` Dmitry Baryshkov
2023-06-12 19:39 ` Dmitry Baryshkov
2023-06-12 23:11 ` Marijn Suijten
2023-06-12 23:11 ` Marijn Suijten
2023-06-14 7:51 ` [Freedreno] " Sumit Semwal
2023-06-14 7:51 ` Sumit Semwal
2023-06-12 18:42 ` Abhinav Kumar [this message]
2023-06-12 18:42 ` [PATCH 1/2] drm/msm/dpu: do not enable color-management if DSPPs are not available Abhinav Kumar
2023-06-12 23:09 ` Marijn Suijten
2023-06-12 23:09 ` Marijn Suijten
2023-06-14 7:49 ` [Freedreno] " Sumit Semwal
2023-06-14 7:49 ` Sumit Semwal
2023-06-15 6:28 ` Yongqin Liu
2023-06-15 6:28 ` Yongqin Liu
2023-06-15 11:31 ` Dmitry Baryshkov
2023-06-15 11:31 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7723b34b-b55b-5bcc-beb5-645ccf54d216@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=yongqin.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.