From: Florian Fainelli <f.fainelli@gmail.com> To: Krzysztof Kozlowski <krzk@kernel.org>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Markus Mayer <mmayer@broadcom.com>, Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>, Vladimir Zapolskiy <vz@mleia.com>, Kukjin Kim <kgene@kernel.org>, Lukasz Luba <lukasz.luba@arm.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de> Subject: Re: [RFT 12/16] memory: brcmstb_dpfe: Add separate entry for compile test Date: Fri, 24 Jul 2020 11:40:09 -0700 [thread overview] Message-ID: <7797a55e-bbf0-ef0f-daec-d56326167586@gmail.com> (raw) In-Reply-To: <20200724182328.3348-13-krzk@kernel.org> On 7/24/20 11:23 AM, Krzysztof Kozlowski wrote: > Add separate entry for Broadcom STB DPFE driver, selected by platforms > by default. This allows further customization and compile testing. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > > I have other changes around drivers/memory/Kconfig pending. Sending them > together would avoid conflicts. > > --- > arch/arm/mach-bcm/Kconfig | 1 + > arch/arm64/Kconfig.platforms | 1 + > drivers/memory/Kconfig | 11 +++++++++++ > drivers/memory/Makefile | 2 +- > 4 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > index 1df0ee01ee02..b0c45238e69b 100644 > --- a/arch/arm/mach-bcm/Kconfig > +++ b/arch/arm/mach-bcm/Kconfig > @@ -208,6 +208,7 @@ config ARCH_BRCMSTB > select ARM_GIC > select ARM_ERRATA_798181 if SMP > select HAVE_ARM_ARCH_TIMER > + select BRCMSTB_DPFE > select BRCMSTB_L2_IRQ > select BCM7120_L2_IRQ > select ARCH_HAS_HOLES_MEMORYMODEL > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index ddc3bf75257f..f7791ed0ed6d 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -68,6 +68,7 @@ config ARCH_BRCMSTB > bool "Broadcom Set-Top-Box SoCs" > select ARCH_HAS_RESET_CONTROLLER > select BCM7038_L1_IRQ > + select BRCMSTB_DPFE The select is probably not warranted, see below. > select BRCMSTB_L2_IRQ > select GENERIC_IRQ_CHIP > select PINCTRL > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig > index cd4fc93b50df..fef6f0873fda 100644 > --- a/drivers/memory/Kconfig > +++ b/drivers/memory/Kconfig > @@ -54,6 +54,17 @@ config ATMEL_EBI > tree is used. This bus supports NANDs, external ethernet controller, > SRAMs, ATA devices, etc. > > +config BRCMSTB_DPFE > + bool "Broadcom STB DPFE driver" if COMPILE_TEST > + depends on ARCH_BRCMSTB || COMPILE_TEST Can you make it default ARCH_BRCMSTB and remove the select above? With that: Acked-by: Florian Fainelli <f.fainelli@gmail.com> > + help > + This driver provides access to the DPFE interface of Broadcom > + STB SoCs. The firmware running on the DCPU inside the DDR PHY can > + provide current information about the system's RAM, for instance > + the DRAM refresh rate. This can be used as an indirect indicator > + for the DRAM's temperature. Slower refresh rate means cooler RAM, > + higher refresh rate means hotter RAM. > + > config BT1_L2_CTL > bool "Baikal-T1 CM2 L2-RAM Cache Control Block" > depends on MIPS_BAIKAL_T1 || COMPILE_TEST > diff --git a/drivers/memory/Makefile b/drivers/memory/Makefile > index b4533ffff2bc..e71cf7b99641 100644 > --- a/drivers/memory/Makefile > +++ b/drivers/memory/Makefile > @@ -10,7 +10,7 @@ endif > obj-$(CONFIG_ARM_PL172_MPMC) += pl172.o > obj-$(CONFIG_ATMEL_SDRAMC) += atmel-sdramc.o > obj-$(CONFIG_ATMEL_EBI) += atmel-ebi.o > -obj-$(CONFIG_ARCH_BRCMSTB) += brcmstb_dpfe.o > +obj-$(CONFIG_BRCMSTB_DPFE) += brcmstb_dpfe.o > obj-$(CONFIG_BT1_L2_CTL) += bt1-l2-ctl.o > obj-$(CONFIG_TI_AEMIF) += ti-aemif.o > obj-$(CONFIG_TI_EMIF) += emif.o > -- Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com> To: Krzysztof Kozlowski <krzk@kernel.org>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Markus Mayer <mmayer@broadcom.com>, Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>, Vladimir Zapolskiy <vz@mleia.com>, Kukjin Kim <kgene@kernel.org>, Lukasz Luba <lukasz.luba@arm.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de> Subject: Re: [RFT 12/16] memory: brcmstb_dpfe: Add separate entry for compile test Date: Fri, 24 Jul 2020 11:40:09 -0700 [thread overview] Message-ID: <7797a55e-bbf0-ef0f-daec-d56326167586@gmail.com> (raw) In-Reply-To: <20200724182328.3348-13-krzk@kernel.org> On 7/24/20 11:23 AM, Krzysztof Kozlowski wrote: > Add separate entry for Broadcom STB DPFE driver, selected by platforms > by default. This allows further customization and compile testing. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > > I have other changes around drivers/memory/Kconfig pending. Sending them > together would avoid conflicts. > > --- > arch/arm/mach-bcm/Kconfig | 1 + > arch/arm64/Kconfig.platforms | 1 + > drivers/memory/Kconfig | 11 +++++++++++ > drivers/memory/Makefile | 2 +- > 4 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > index 1df0ee01ee02..b0c45238e69b 100644 > --- a/arch/arm/mach-bcm/Kconfig > +++ b/arch/arm/mach-bcm/Kconfig > @@ -208,6 +208,7 @@ config ARCH_BRCMSTB > select ARM_GIC > select ARM_ERRATA_798181 if SMP > select HAVE_ARM_ARCH_TIMER > + select BRCMSTB_DPFE > select BRCMSTB_L2_IRQ > select BCM7120_L2_IRQ > select ARCH_HAS_HOLES_MEMORYMODEL > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index ddc3bf75257f..f7791ed0ed6d 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -68,6 +68,7 @@ config ARCH_BRCMSTB > bool "Broadcom Set-Top-Box SoCs" > select ARCH_HAS_RESET_CONTROLLER > select BCM7038_L1_IRQ > + select BRCMSTB_DPFE The select is probably not warranted, see below. > select BRCMSTB_L2_IRQ > select GENERIC_IRQ_CHIP > select PINCTRL > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig > index cd4fc93b50df..fef6f0873fda 100644 > --- a/drivers/memory/Kconfig > +++ b/drivers/memory/Kconfig > @@ -54,6 +54,17 @@ config ATMEL_EBI > tree is used. This bus supports NANDs, external ethernet controller, > SRAMs, ATA devices, etc. > > +config BRCMSTB_DPFE > + bool "Broadcom STB DPFE driver" if COMPILE_TEST > + depends on ARCH_BRCMSTB || COMPILE_TEST Can you make it default ARCH_BRCMSTB and remove the select above? With that: Acked-by: Florian Fainelli <f.fainelli@gmail.com> > + help > + This driver provides access to the DPFE interface of Broadcom > + STB SoCs. The firmware running on the DCPU inside the DDR PHY can > + provide current information about the system's RAM, for instance > + the DRAM refresh rate. This can be used as an indirect indicator > + for the DRAM's temperature. Slower refresh rate means cooler RAM, > + higher refresh rate means hotter RAM. > + > config BT1_L2_CTL > bool "Baikal-T1 CM2 L2-RAM Cache Control Block" > depends on MIPS_BAIKAL_T1 || COMPILE_TEST > diff --git a/drivers/memory/Makefile b/drivers/memory/Makefile > index b4533ffff2bc..e71cf7b99641 100644 > --- a/drivers/memory/Makefile > +++ b/drivers/memory/Makefile > @@ -10,7 +10,7 @@ endif > obj-$(CONFIG_ARM_PL172_MPMC) += pl172.o > obj-$(CONFIG_ATMEL_SDRAMC) += atmel-sdramc.o > obj-$(CONFIG_ATMEL_EBI) += atmel-ebi.o > -obj-$(CONFIG_ARCH_BRCMSTB) += brcmstb_dpfe.o > +obj-$(CONFIG_BRCMSTB_DPFE) += brcmstb_dpfe.o > obj-$(CONFIG_BT1_L2_CTL) += bt1-l2-ctl.o > obj-$(CONFIG_TI_AEMIF) += ti-aemif.o > obj-$(CONFIG_TI_EMIF) += emif.o > -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-24 18:40 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-24 18:23 [PATCH 00/16] memory: Further cleanups Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 01/16] memory: bt1-l2-ctl: Add blank lines after declarations Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-27 8:16 ` Krzysztof Kozlowski 2020-07-27 8:16 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 02/16] memory: mvebu-devbus: Add missing braces to all arms of if statement Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-27 8:16 ` Krzysztof Kozlowski 2020-07-27 8:16 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 03/16] memory: mvebu-devbus: Align with open parenthesis Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-27 8:16 ` Krzysztof Kozlowski 2020-07-27 8:16 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 04/16] memory: omap-gpmc: Correct kerneldoc Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-27 8:16 ` Krzysztof Kozlowski 2020-07-27 8:16 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 05/16] memory: omap-gpmc: Enclose macro argument usage in parenthesis Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-27 8:16 ` Krzysztof Kozlowski 2020-07-27 8:16 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 06/16] memory: omap-gpmc: Use 'unsigned int' for consistency Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-27 8:15 ` Krzysztof Kozlowski 2020-07-27 8:15 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 07/16] memory: omap-gpmc: Correct white space issues Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-27 8:15 ` Krzysztof Kozlowski 2020-07-27 8:15 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [RFT 08/16] memory: omap-gpmc: Use WARN() instead of BUG() on wrong free Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-08-17 18:36 ` Krzysztof Kozlowski 2020-08-17 18:36 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 09/16] memory: omap-gpmc: Fix language typo Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-27 8:15 ` Krzysztof Kozlowski 2020-07-27 8:15 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 10/16] memory: omap-gpmc: Consistently use !res for NULL checks Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-08-17 18:37 ` Krzysztof Kozlowski 2020-08-17 18:37 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 11/16] memory: brcmstb_dpfe: Fix language typo Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-24 18:38 ` Florian Fainelli 2020-07-24 18:38 ` Florian Fainelli 2020-07-27 8:14 ` Krzysztof Kozlowski 2020-07-27 8:14 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [RFT 12/16] memory: brcmstb_dpfe: Add separate entry for compile test Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-24 18:40 ` Florian Fainelli [this message] 2020-07-24 18:40 ` Florian Fainelli 2020-07-24 18:42 ` Krzysztof Kozlowski 2020-07-24 18:42 ` Krzysztof Kozlowski 2020-08-17 18:38 ` Krzysztof Kozlowski 2020-08-17 18:38 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 13/16] memory: of: Correct kerneldoc Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-27 8:09 ` Krzysztof Kozlowski 2020-07-27 8:09 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 14/16] memory: pl172: Enclose macro argument usage in parenthesis Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-27 8:09 ` Krzysztof Kozlowski 2020-07-27 8:09 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 15/16] memory: samsung: exynos-srom: Correct alignment Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-07-24 18:23 ` [PATCH 16/16] memory: samsung: exynos5422-dmc: Correct white space issues Krzysztof Kozlowski 2020-07-24 18:23 ` Krzysztof Kozlowski 2020-08-18 8:22 ` Lukasz Luba 2020-08-18 8:22 ` Lukasz Luba
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7797a55e-bbf0-ef0f-daec-d56326167586@gmail.com \ --to=f.fainelli@gmail.com \ --cc=arnd@arndb.de \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=catalin.marinas@arm.com \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=lukasz.luba@arm.com \ --cc=mmayer@broadcom.com \ --cc=olof@lixom.net \ --cc=rjui@broadcom.com \ --cc=rogerq@ti.com \ --cc=sbranden@broadcom.com \ --cc=tony@atomide.com \ --cc=vz@mleia.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.