Re: [PATCH] selftests: Fix arm64 test installation

From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
	Mark Brown <broonie@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Anders Roxell <anders.roxell@linaro.org>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Ryan Roberts <ryan.roberts@arm.com>
Cc: <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] selftests: Fix arm64 test installation
Date: Thu, 13 Jul 2023 13:16:55 -0700	[thread overview]
Message-ID: <785e1c1c-84d8-e87d-f22f-9a53d27f30f6@nvidia.com> (raw)
In-Reply-To: <8d944238-1a9a-e93e-fdab-54e74fa12e11@linuxfoundation.org>

On 7/13/23 13:02, Shuah Khan wrote:
> On 7/10/23 08:04, Mark Brown wrote:
...
>> -kernel_header_files:
>> -    @ls $(KHDR_DIR)/linux/*.h >/dev/null 2>/dev/null;                      \
>> -    if [ $$? -ne 0 ]; then                                                 \
>> -            RED='\033[1;31m';                                                  \
>> -            NOCOLOR='\033[0m';                                                 \
>> -            echo;                                                              \
>> -            echo -e "$${RED}error$${NOCOLOR}: missing kernel header files.";   \
>> -            echo "Please run this and try again:";                             \
>> -            echo;                                                              \
>> -            echo "    cd $(top_srcdir)";                                       \
>> -            echo "    make headers";                                           \
>> -            echo;                                                              \
>> -        exit 1; \
>> -    fi
>> -
>> -.PHONY: kernel_header_files
>> +all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES)
>>   define RUN_TESTS
>>       BASE_DIR="$(selfdir)";            \
>>
>> ---
>> base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
>> change-id: 20230710-kselftest-fix-arm64-c023160018d7
>>
>> Best regards,
> 
> Thank you. Will apply the patch for the next rc
> 
> thanks,
> -- Shuah

Hi Shuah,

Actually, I was hoping that my two fixes [1], [2] could be used, instead
of reverting the feature.

[1] https://lore.kernel.org/all/20230711005629.2547838-1-jhubbard@nvidia.com/

[2] https://lore.kernel.org/all/20230712193514.740033-1-jhubbard@nvidia.com/

thanks,
-- 
John Hubbard
NVIDIA