Re: [PATCH 4/6 v2] MOST: cdev: rename 'mod_init' & 'mod_exit' functions to be module-specific

From: <Christian.Gromm@microchip.com>
To: <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org>
Cc: <linux-x25@vger.kernel.org>, <ms@dev.tdt.de>, <mpm@selenic.com>,
	<linux@armlinux.org.uk>, <wireguard@lists.zx2c4.com>,
	<Jason@zx2c4.com>, <khc@pm.waw.pl>, <kuba@kernel.org>,
	<dilinger@queued.net>, <linux-arm-kernel@lists.infradead.org>,
	<gregkh@linuxfoundation.org>, <netdev@vger.kernel.org>,
	<davem@davemloft.net>, <arnd@arndb.de>,
	<herbert@gondor.apana.org.au>, <linux-geode@lists.infradead.org>,
	<linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 4/6 v2] MOST: cdev: rename 'mod_init' & 'mod_exit' functions to be module-specific
Date: Mon, 19 Jul 2021 06:45:35 +0000	[thread overview]
Message-ID: <787d71b4cb5174bda5a35d5ea44777d994b85e59.camel@microchip.com> (raw)
In-Reply-To: <20210711223148.5250-5-rdunlap@infradead.org>


On Sun, 2021-07-11 at 15:31 -0700, Randy Dunlap wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Rename module_init & module_exit functions that are named
> "mod_init" and "mod_exit" so that they are unique in both the
> System.map file and in initcall_debug output instead of showing
> up as almost anonymous "mod_init".
> 
> This is helpful for debugging and in determining how long certain
> module_init calls take to execute.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Christian Gromm <christian.gromm@microchip.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> v2: no change
> 
>  drivers/most/most_cdev.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> --- linux-next-20210708.orig/drivers/most/most_cdev.c
> +++ linux-next-20210708/drivers/most/most_cdev.c
> @@ -486,7 +486,7 @@ static struct cdev_component comp = {
>         },
>  };
> 
> -static int __init mod_init(void)
> +static int __init most_cdev_init(void)
>  {
>         int err;
> 
> @@ -518,7 +518,7 @@ dest_ida:
>         return err;
>  }
> 
> -static void __exit mod_exit(void)
> +static void __exit most_cdev_exit(void)
>  {
>         struct comp_channel *c, *tmp;
> 
> @@ -534,8 +534,8 @@ static void __exit mod_exit(void)
>         class_destroy(comp.class);
>  }
> 
> -module_init(mod_init);
> -module_exit(mod_exit);
> +module_init(most_cdev_init);
> +module_exit(most_cdev_exit);
>  MODULE_AUTHOR("Christian Gromm <christian.gromm@microchip.com>");
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("character device component for mostcore");

Acked-by: Christian Gromm (christian.gromm@microchip.com)