Re: [PATCH] drm/i915: Allow set context SSEU on platforms after gen 11

From: "Summers, Stuart" <stuart.summers@intel.com>
To: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Allow set context SSEU on platforms after gen 11
Date: Fri, 20 Sep 2019 21:09:46 +0000	[thread overview]
Message-ID: <794c7d3a4b88d6ff53dc186b342da99575510f86.camel@intel.com> (raw)
In-Reply-To: <9b3a76d3-f961-95d3-7396-8b638a1cc935@linux.intel.com>

[-- Attachment #1.1: Type: text/plain, Size: 1576 bytes --]

On Thu, 2019-09-19 at 08:00 +0100, Tvrtko Ursulin wrote:
> On 18/09/2019 18:31, Stuart Summers wrote:
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110559
> 
> Unless there was some discussion I missed we can't just turn it on
> to 
> work around a SKIP in IGT. Feature was deliberately limited to
> Icelake 
> and even there just to a sub-set of possible configurations.

No conversation was missed, or at least none I was a part of. Is there
a reason we don't allow this on future platforms?

We do claim powergate support on TGL, so I assumed it would be good to
take this path on that platform. Maybe I'm misunderstanding something
here though.

Thanks,
Stuart

> 
> Regards,
> 
> Tvrtko
> 
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Signed-off-by: Stuart Summers <stuart.summers@intel.com>
> > ---
> >   drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > index f1c0e5d958f3..39af4c81b29a 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > @@ -1310,7 +1310,7 @@ static int set_sseu(struct i915_gem_context
> > *ctx,
> >   	if (args->size < sizeof(user_sseu))
> >   		return -EINVAL;
> >   
> > -	if (!IS_GEN(i915, 11))
> > +	if (INTEL_GEN(i915) < 11)
> >   		return -ENODEV;
> >   
> >   	if (copy_from_user(&user_sseu, u64_to_user_ptr(args->value),
> > 

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx