Re: [PATCH 1/3] x86/treewide: Switch bool_t to bool

From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "George Dunlap" <George.Dunlap@citrix.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Wei Liu" <wl@xen.org>, "Julien Grall" <julien@xen.org>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/3] x86/treewide: Switch bool_t to bool
Date: Wed, 22 Nov 2023 10:07:53 +0000	[thread overview]
Message-ID: <7959b2cf-aa0d-4d40-bc03-c0bb37eac94d@citrix.com> (raw)
In-Reply-To: <ec2cda2a-3997-42d8-b059-fc202cad5b35@suse.com>

On 22/11/2023 10:05 am, Jan Beulich wrote:
> On 20.11.2023 15:56, Andrew Cooper wrote:
>> @@ -798,11 +799,11 @@ ept_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t mfn,
>>      unsigned int i, target = order / EPT_TABLE_ORDER;
>>      unsigned long fn_mask = !mfn_eq(mfn, INVALID_MFN) ? (gfn | mfn_x(mfn)) : gfn;
>>      int ret, rc = 0;
>> -    bool_t entry_written = 0;
>> -    bool_t need_modify_vtd_table = 1;
>> -    bool_t vtd_pte_present = 0;
>> +    bool entry_written = false;
>> +    bool need_modify_vtd_table = true;
>> +    bool vtd_pte_present = false;
>>      unsigned int iommu_flags = p2m_get_iommu_flags(p2mt, p2ma, mfn);
>> -    bool_t needs_sync = 1;
>> +    bool needs_sync = false;
> Coverity has just (indirectly) spotted this mistake. I hope no others are
> lurking anywhere.

:-/

Now I want to figure out why my side-by-side builds didn't show up a
change...

But yes - that was clearly a mistake.  Sorry.

~Andrew