Re: [PATCH 1/3] x86/treewide: Switch bool_t to bool

From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "George Dunlap" <George.Dunlap@citrix.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Wei Liu" <wl@xen.org>, "Julien Grall" <julien@xen.org>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/3] x86/treewide: Switch bool_t to bool
Date: Mon, 20 Nov 2023 17:17:14 +0100	[thread overview]
Message-ID: <c52b9fe8-d894-4a58-9d4e-9935e8044e90@suse.com> (raw)
In-Reply-To: <20231120145623.167383-2-andrew.cooper3@citrix.com>

On 20.11.2023 15:56, Andrew Cooper wrote:
> ... as part of cleaning up the types used.  Minor style cleanup on some
> altered lines.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

One small request and a nit, though:

> --- a/xen/arch/x86/include/asm/apic.h
> +++ b/xen/arch/x86/include/asm/apic.h
> @@ -139,7 +139,7 @@ static __inline void apic_icr_write(u32 low, u32 dest)
>      }
>  }
>  
> -static __inline bool_t apic_isr_read(u8 vector)
> +static __inline bool apic_isr_read(u8 vector)

Would be nice to also switch to uint8_t at this occasion.

> --- a/xen/arch/x86/include/asm/hvm/io.h
> +++ b/xen/arch/x86/include/asm/hvm/io.h
> @@ -54,7 +54,7 @@ typedef int (*hvm_io_write_t)(const struct hvm_io_handler *handler,
>                                uint64_t addr,
>                                uint32_t size,
>                                uint64_t data);
> -typedef bool_t (*hvm_io_accept_t)(const struct hvm_io_handler *handler,
> +typedef bool (*hvm_io_accept_t)(const struct hvm_io_handler *handler,
>                                    const ioreq_t *p);

Nit: Failed to re-indent the 2nd line.

Jan