From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Joel Stanley <joel@jms.id.au>
Cc: Jeremy Kerr <jk@ozlabs.org>,
Alistar Popple <alistair@popple.id.au>,
Eddie James <eajames@linux.ibm.com>,
Andrew Jeffery <andrew@aj.id.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
linux-fsi@lists.ozlabs.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>
Subject: Re: [PATCH v3] fsi: Aspeed: Fix a potential double free
Date: Mon, 21 Feb 2022 19:08:32 +0100 [thread overview]
Message-ID: <79bdf543-4882-360e-567f-493e84f09d6b@wanadoo.fr> (raw)
In-Reply-To: <CACPK8XfxZRXtU0Bn+f0=B3CGUE8A8i9Ob_a9=2t=TzLc5a+75w@mail.gmail.com>
Le 21/02/2022 à 10:24, Joel Stanley a écrit :
> Hi Christophe,
>
> Thanks for the patch.
>
> On Sun, 9 Jan 2022 at 21:56, Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
>>
>> A struct device can never be devm_alloc()'ed.
>> Here, it is embedded in "struct fsi_master", and "struct fsi_master" is
>> embedded in "struct fsi_master_aspeed".
>>
>> Since "struct device" is embedded, the data structure embedding it must be
>> released with the release function, as is already done here.
>>
>> So use kzalloc() instead of devm_kzalloc() when allocating "aspeed" and
>> update all error handling branches accordingly.
>
> This looks like a problem with the design of the fsi master structure.
> It's a common pattern to devm_alloc the platform devices as they are
> probed, the fsi masters all embed a copy of struct fsi_master, which
> as you say embeds struct device.
>
> Can we learn from other bus drivers (eg i2c?) how we should lay out
> these structures?
>
Hi,
I won't do it myself.
This goes beyond my knowledge and without the possibility to test it, it
would be just some random trial and error (as I did in the first broken
version of this patch).
CJ
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Joel Stanley <joel@jms.id.au>
Cc: Jeremy Kerr <jk@ozlabs.org>,
Alistar Popple <alistair@popple.id.au>,
Eddie James <eajames@linux.ibm.com>,
Andrew Jeffery <andrew@aj.id.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
linux-fsi@lists.ozlabs.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>
Subject: Re: [PATCH v3] fsi: Aspeed: Fix a potential double free
Date: Mon, 21 Feb 2022 19:08:32 +0100 [thread overview]
Message-ID: <79bdf543-4882-360e-567f-493e84f09d6b@wanadoo.fr> (raw)
In-Reply-To: <CACPK8XfxZRXtU0Bn+f0=B3CGUE8A8i9Ob_a9=2t=TzLc5a+75w@mail.gmail.com>
Le 21/02/2022 à 10:24, Joel Stanley a écrit :
> Hi Christophe,
>
> Thanks for the patch.
>
> On Sun, 9 Jan 2022 at 21:56, Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
>>
>> A struct device can never be devm_alloc()'ed.
>> Here, it is embedded in "struct fsi_master", and "struct fsi_master" is
>> embedded in "struct fsi_master_aspeed".
>>
>> Since "struct device" is embedded, the data structure embedding it must be
>> released with the release function, as is already done here.
>>
>> So use kzalloc() instead of devm_kzalloc() when allocating "aspeed" and
>> update all error handling branches accordingly.
>
> This looks like a problem with the design of the fsi master structure.
> It's a common pattern to devm_alloc the platform devices as they are
> probed, the fsi masters all embed a copy of struct fsi_master, which
> as you say embeds struct device.
>
> Can we learn from other bus drivers (eg i2c?) how we should lay out
> these structures?
>
Hi,
I won't do it myself.
This goes beyond my knowledge and without the possibility to test it, it
would be just some random trial and error (as I did in the first broken
version of this patch).
CJ
next prev parent reply other threads:[~2022-02-21 18:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 21:56 [PATCH v3] fsi: Aspeed: Fix a potential double free Christophe JAILLET
2022-01-09 21:56 ` Christophe JAILLET
2022-01-10 17:01 ` Guenter Roeck
2022-01-10 17:01 ` Guenter Roeck
2022-02-21 9:24 ` Joel Stanley
2022-02-21 9:24 ` Joel Stanley
2022-02-21 18:08 ` Christophe JAILLET [this message]
2022-02-21 18:08 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79bdf543-4882-360e-567f-493e84f09d6b@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=alistair@popple.id.au \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.