All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Codrin.Ciubotariu@microchip.com>
To: <arnd@kernel.org>, <lgirdwood@gmail.com>, <broonie@kernel.org>,
	<perex@perex.cz>, <tiwai@suse.com>, <Nicolas.Ferre@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<Ludovic.Desroches@microchip.com>
Cc: <arnd@arndb.de>, <alsa-devel@alsa-project.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: atmel: mchp-spdifrx needs COMMON_CLK
Date: Fri, 4 Dec 2020 09:11:40 +0000	[thread overview]
Message-ID: <7a0f2513-b694-e5c7-6048-b1eba915bba5@microchip.com> (raw)
In-Reply-To: <20201203223815.1353451-1-arnd@kernel.org>

On 04.12.2020 00:38, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Compile-testing this driver on an older platform without CONFIG_COMMON_CLK fails with
> 
> ERROR: modpost: "clk_set_min_rate" [sound/soc/atmel/snd-soc-mchp-spdifrx.ko] undefined!
> 
> Make this is a strict dependency.
> 
> Fixes: ef265c55c1ac ("ASoC: mchp-spdifrx: add driver for SPDIF RX")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Thanks!

> ---
>   sound/soc/atmel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index bd8854bfd2ee..142373ec411a 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -148,6 +148,7 @@ config SND_MCHP_SOC_SPDIFTX
>   config SND_MCHP_SOC_SPDIFRX
>          tristate "Microchip ASoC driver for boards using S/PDIF RX"
>          depends on OF && (ARCH_AT91 || COMPILE_TEST)
> +       depends on COMMON_CLK
>          select SND_SOC_GENERIC_DMAENGINE_PCM
>          select REGMAP_MMIO
>          help
> --
> 2.27.0
> 


WARNING: multiple messages have this Message-ID (diff)
From: <Codrin.Ciubotariu@microchip.com>
To: <arnd@kernel.org>, <lgirdwood@gmail.com>, <broonie@kernel.org>,
	<perex@perex.cz>, <tiwai@suse.com>, <Nicolas.Ferre@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<Ludovic.Desroches@microchip.com>
Cc: alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: atmel: mchp-spdifrx needs COMMON_CLK
Date: Fri, 4 Dec 2020 09:11:40 +0000	[thread overview]
Message-ID: <7a0f2513-b694-e5c7-6048-b1eba915bba5@microchip.com> (raw)
In-Reply-To: <20201203223815.1353451-1-arnd@kernel.org>

On 04.12.2020 00:38, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Compile-testing this driver on an older platform without CONFIG_COMMON_CLK fails with
> 
> ERROR: modpost: "clk_set_min_rate" [sound/soc/atmel/snd-soc-mchp-spdifrx.ko] undefined!
> 
> Make this is a strict dependency.
> 
> Fixes: ef265c55c1ac ("ASoC: mchp-spdifrx: add driver for SPDIF RX")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Thanks!

> ---
>   sound/soc/atmel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index bd8854bfd2ee..142373ec411a 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -148,6 +148,7 @@ config SND_MCHP_SOC_SPDIFTX
>   config SND_MCHP_SOC_SPDIFRX
>          tristate "Microchip ASoC driver for boards using S/PDIF RX"
>          depends on OF && (ARCH_AT91 || COMPILE_TEST)
> +       depends on COMMON_CLK
>          select SND_SOC_GENERIC_DMAENGINE_PCM
>          select REGMAP_MMIO
>          help
> --
> 2.27.0
> 


WARNING: multiple messages have this Message-ID (diff)
From: <Codrin.Ciubotariu@microchip.com>
To: <arnd@kernel.org>, <lgirdwood@gmail.com>, <broonie@kernel.org>,
	<perex@perex.cz>, <tiwai@suse.com>, <Nicolas.Ferre@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<Ludovic.Desroches@microchip.com>
Cc: alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: atmel: mchp-spdifrx needs COMMON_CLK
Date: Fri, 4 Dec 2020 09:11:40 +0000	[thread overview]
Message-ID: <7a0f2513-b694-e5c7-6048-b1eba915bba5@microchip.com> (raw)
In-Reply-To: <20201203223815.1353451-1-arnd@kernel.org>

On 04.12.2020 00:38, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Compile-testing this driver on an older platform without CONFIG_COMMON_CLK fails with
> 
> ERROR: modpost: "clk_set_min_rate" [sound/soc/atmel/snd-soc-mchp-spdifrx.ko] undefined!
> 
> Make this is a strict dependency.
> 
> Fixes: ef265c55c1ac ("ASoC: mchp-spdifrx: add driver for SPDIF RX")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Thanks!

> ---
>   sound/soc/atmel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index bd8854bfd2ee..142373ec411a 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -148,6 +148,7 @@ config SND_MCHP_SOC_SPDIFTX
>   config SND_MCHP_SOC_SPDIFRX
>          tristate "Microchip ASoC driver for boards using S/PDIF RX"
>          depends on OF && (ARCH_AT91 || COMPILE_TEST)
> +       depends on COMMON_CLK
>          select SND_SOC_GENERIC_DMAENGINE_PCM
>          select REGMAP_MMIO
>          help
> --
> 2.27.0
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-12-04  9:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 22:38 [PATCH] ASoC: atmel: mchp-spdifrx needs COMMON_CLK Arnd Bergmann
2020-12-03 22:38 ` Arnd Bergmann
2020-12-03 22:38 ` Arnd Bergmann
2020-12-04  9:11 ` Codrin.Ciubotariu [this message]
2020-12-04  9:11   ` Codrin.Ciubotariu
2020-12-04  9:11   ` Codrin.Ciubotariu
2020-12-04 23:30 ` Mark Brown
2020-12-04 23:30   ` Mark Brown
2020-12-04 23:30   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a0f2513-b694-e5c7-6048-b1eba915bba5@microchip.com \
    --to=codrin.ciubotariu@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.