From: Amit Kachhap <amit.kachhap@arm.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: Shuah Khan <shuah@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Gabor Kertesz <gabor.kertesz@arm.com>
Subject: Re: [PATCH 4/6] kselftest/arm64: Fix check_mmap_options test
Date: Tue, 27 Oct 2020 16:01:16 +0530 [thread overview]
Message-ID: <7a719ad9-0eef-5f7a-be5a-f2194d774d74@arm.com> (raw)
In-Reply-To: <20201026121248.2340-5-vincenzo.frascino@arm.com>
On 10/26/20 5:42 PM, Vincenzo Frascino wrote:
> The check_mmap_options test reports the error below because the test
> plan is not declared correctly:
>
> # Planned tests != run tests (0 != 22)
>
> Fix the test adding the correct test plan declaration.
This change is required and got missed earlier.
Acked by: Amit Daniel Kachhap <amit.kachhap@arm.com>
>
> Fixes: 53ec81d23213 ("kselftest/arm64: Verify all different mmap MTE options")
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Gabor Kertesz <gabor.kertesz@arm.com>
> Cc: Amit Daniel Kachhap <amit.kachhap@arm.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
> tools/testing/selftests/arm64/mte/check_mmap_options.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/selftests/arm64/mte/check_mmap_options.c b/tools/testing/selftests/arm64/mte/check_mmap_options.c
> index 33b13b86199b..a04b12c21ac9 100644
> --- a/tools/testing/selftests/arm64/mte/check_mmap_options.c
> +++ b/tools/testing/selftests/arm64/mte/check_mmap_options.c
> @@ -205,7 +205,11 @@ int main(int argc, char *argv[])
> mte_register_signal(SIGBUS, mte_default_handler);
> mte_register_signal(SIGSEGV, mte_default_handler);
>
> + /* Set test plan */
> + ksft_set_plan(22);
> +
> mte_enable_pstate_tco();
> +
> evaluate_test(check_anonymous_memory_mapping(USE_MMAP, MTE_SYNC_ERR, MAP_PRIVATE, TAG_CHECK_OFF),
> "Check anonymous memory with private mapping, sync error mode, mmap memory and tag check off\n");
> evaluate_test(check_file_memory_mapping(USE_MPROTECT, MTE_SYNC_ERR, MAP_PRIVATE, TAG_CHECK_OFF),
>
WARNING: multiple messages have this Message-ID (diff)
From: Amit Kachhap <amit.kachhap@arm.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Shuah Khan <shuah@kernel.org>,
Gabor Kertesz <gabor.kertesz@arm.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH 4/6] kselftest/arm64: Fix check_mmap_options test
Date: Tue, 27 Oct 2020 16:01:16 +0530 [thread overview]
Message-ID: <7a719ad9-0eef-5f7a-be5a-f2194d774d74@arm.com> (raw)
In-Reply-To: <20201026121248.2340-5-vincenzo.frascino@arm.com>
On 10/26/20 5:42 PM, Vincenzo Frascino wrote:
> The check_mmap_options test reports the error below because the test
> plan is not declared correctly:
>
> # Planned tests != run tests (0 != 22)
>
> Fix the test adding the correct test plan declaration.
This change is required and got missed earlier.
Acked by: Amit Daniel Kachhap <amit.kachhap@arm.com>
>
> Fixes: 53ec81d23213 ("kselftest/arm64: Verify all different mmap MTE options")
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Gabor Kertesz <gabor.kertesz@arm.com>
> Cc: Amit Daniel Kachhap <amit.kachhap@arm.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
> tools/testing/selftests/arm64/mte/check_mmap_options.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/selftests/arm64/mte/check_mmap_options.c b/tools/testing/selftests/arm64/mte/check_mmap_options.c
> index 33b13b86199b..a04b12c21ac9 100644
> --- a/tools/testing/selftests/arm64/mte/check_mmap_options.c
> +++ b/tools/testing/selftests/arm64/mte/check_mmap_options.c
> @@ -205,7 +205,11 @@ int main(int argc, char *argv[])
> mte_register_signal(SIGBUS, mte_default_handler);
> mte_register_signal(SIGSEGV, mte_default_handler);
>
> + /* Set test plan */
> + ksft_set_plan(22);
> +
> mte_enable_pstate_tco();
> +
> evaluate_test(check_anonymous_memory_mapping(USE_MMAP, MTE_SYNC_ERR, MAP_PRIVATE, TAG_CHECK_OFF),
> "Check anonymous memory with private mapping, sync error mode, mmap memory and tag check off\n");
> evaluate_test(check_file_memory_mapping(USE_MPROTECT, MTE_SYNC_ERR, MAP_PRIVATE, TAG_CHECK_OFF),
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-27 10:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 12:12 [PATCH 0/6] kselftest/arm64: MTE fixes Vincenzo Frascino
2020-10-26 12:12 ` Vincenzo Frascino
2020-10-26 12:12 ` [PATCH 1/6] kselftest/arm64: Fix check_buffer_fill test Vincenzo Frascino
2020-10-26 12:12 ` Vincenzo Frascino
2020-10-27 10:25 ` Amit Kachhap
2020-10-27 10:25 ` Amit Kachhap
2020-10-26 12:12 ` [PATCH 2/6] kselftest/arm64: Fix check_tags_inclusion test Vincenzo Frascino
2020-10-26 12:12 ` Vincenzo Frascino
2020-10-27 10:27 ` Amit Kachhap
2020-10-27 10:27 ` Amit Kachhap
2020-10-26 12:12 ` [PATCH 3/6] kselftest/arm64: Fix check_child_memory test Vincenzo Frascino
2020-10-26 12:12 ` Vincenzo Frascino
2020-10-27 10:29 ` Amit Kachhap
2020-10-27 10:29 ` Amit Kachhap
2020-10-26 12:12 ` [PATCH 4/6] kselftest/arm64: Fix check_mmap_options test Vincenzo Frascino
2020-10-26 12:12 ` Vincenzo Frascino
2020-10-27 10:31 ` Amit Kachhap [this message]
2020-10-27 10:31 ` Amit Kachhap
2020-10-26 12:12 ` [PATCH 5/6] kselftest/arm64: Fix check_ksm_options test Vincenzo Frascino
2020-10-26 12:12 ` Vincenzo Frascino
2020-10-27 10:33 ` Amit Kachhap
2020-10-27 10:33 ` Amit Kachhap
2020-10-26 12:12 ` [PATCH 6/6] kselftest/arm64: Fix check_user_mem test Vincenzo Frascino
2020-10-26 12:12 ` Vincenzo Frascino
2020-10-27 10:34 ` Amit Kachhap
2020-10-27 10:34 ` Amit Kachhap
2020-10-28 15:12 ` [PATCH 0/6] kselftest/arm64: MTE fixes Will Deacon
2020-10-28 15:12 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a719ad9-0eef-5f7a-be5a-f2194d774d74@arm.com \
--to=amit.kachhap@arm.com \
--cc=catalin.marinas@arm.com \
--cc=gabor.kertesz@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.