Re: [PATCH v3 0/2] mmc: meson-gx: add SDIO interrupt support

From: Heiner Kallweit <hkallweit1@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
	Neil Armstrong <narmstrong@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH v3 0/2] mmc: meson-gx: add SDIO interrupt support
Date: Mon, 29 Aug 2022 20:23:48 +0200	[thread overview]
Message-ID: <7b66d876-aabe-7f07-7e54-0be28a25ed3f@gmail.com> (raw)
In-Reply-To: <CAPDyKFqqtHUtGshE=JYaLK09P28EeenYAsvnDkROvMHb7i2bDg@mail.gmail.com>

On 29.08.2022 16:21, Ulf Hansson wrote:
> On Mon, 29 Aug 2022 at 15:29, Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> On 29/08/2022 14:07, Ulf Hansson wrote:
>>> On Mon, 29 Aug 2022 at 09:42, Neil Armstrong <narmstrong@baylibre.com> wrote:
>>>>
>>>> Hi Uffe, Heiner,
>>>>
>>>> On 26/08/2022 11:16, Ulf Hansson wrote:
>>>>> On Thu, 25 Aug 2022 at 21:52, Heiner Kallweit <hkallweit1@gmail.com> wrote:
>>>>>>
>>>>>> Add SDIO interrupt support. Successfully tested on a S905X4-based
>>>>>> system (V3 register layout) with a BRCM4334 SDIO wifi module
>>>>>> (brcmfmac driver).
>>>>>>
>>>>>> v2:
>>>>>> - use new SDIO interrupt API
>>>>>> v3:
>>>>>> - don't duplicate checking mmc->sdio_irq_pending
>>>>>>
>>>>>> Heiner Kallweit (2):
>>>>>>     mmc: meson: adjust and re-use constant IRQ_EN_MASK
>>>>>>     mmc: meson-gx: add SDIO interrupt support
>>>>>>
>>>>>>    drivers/mmc/host/meson-gx-mmc.c | 84 +++++++++++++++++++++++++--------
>>>>>>    1 file changed, 65 insertions(+), 19 deletions(-)
>>>>>>
>>>>>
>>>>> Applied for next, thanks!
>>>>
>>>> Thanks for applying, but I was off (like many of reviewers) and I would have like
>>>> this patchset to be tested on earlier SoCs aswell, or only enabled on S4 for now.
>>>
>>> To actually make use of the new code, an update to the corresponding
>>> DTS files are needed to set the cap-sdio-irq property.
>>
>> I know but it changed the IRQ handling, let's hope we don't see any regressions.
> 
> Right. Let's encourage people to test this!
> 
> I noticed that $subject patch sets the CLK_IRQ_SDIO_SLEEP bit, no
> matter whether the SDIO IRQs has been enabled. Don't know if that is
> intentional and/or could be a problem? Heiner?
> 
This bit enables SDIO interrupts in sleep mode too. I experienced no difference
in behavior if SDIO interrupts aren't enabled.

> [...]
> 
> Kind regards
> Uffe