From: Andrzej Hajda <a.hajda@samsung.com>
To: Adrian Ratiu <adrian.ratiu@collabora.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-imx@nxp.com,
kernel@collabora.com, linux-stm32@st-md-mailman.stormreply.com,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v5 0/5] Genericize DW MIPI DSI bridge and add i.MX 6 driver
Date: Mon, 6 Apr 2020 16:23:49 +0200 [thread overview]
Message-ID: <7b95e129-8035-df7f-3d50-2ae3c2e8af8d@samsung.com> (raw)
In-Reply-To: <20200330113542.181752-1-adrian.ratiu@collabora.com>
Hi Adrian,
Due to different ways of work I use different mail client, so forgive me
if there are some misconfugrations.
W dniu 30.03.2020 o 13:35, Adrian Ratiu pisze:
> Hello everyone,
>
> The v5 series is a significantly cleaned up version from v4,
> started by Ezequiel Garcia's suggestion of splitting out the
> regmap infrastructure from the drivers (thank you!).
>
> Turns out no changes are required to the existing drivers and
> the bridge can transparently take care of the layout logic,
> so there's no need to expose the regmap via plat_data anymore.
>
> Starting from this version I also opted to add per-patch
> changelogs. All review comments up to now have been addressed.
>
> Tested on IMX6DL.
>
> Adrian Ratiu (5):
> drm: bridge: dw_mipi_dsi: add initial regmap infrastructure
> drm: bridge: dw_mipi_dsi: abstract register access using reg_fields
> drm: bridge: synopsis: add dsi v1.01 support
> drm: imx: Add i.MX 6 MIPI DSI host platform driver
> dt-bindings: display: add i.MX6 MIPI DSI host controller doc
>
> .../display/imx/fsl,mipi-dsi-imx6.yaml | 134 ++++
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 683 +++++++++++++-----
So we have above 400 lines more just to add slightly different register
layout of v1.01.
Quite big linecount for apparently small (?) functional change - I was
too lazy to check how many reg fields are really used (some are not used
at all), but it does not seem to be big enough to justyfy so big change IMO.
I will add more comments in specific patches.
Regards
Andrzej
> drivers/gpu/drm/imx/Kconfig | 7 +
> drivers/gpu/drm/imx/Makefile | 1 +
> drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c | 399 ++++++++++
> 5 files changed, 1049 insertions(+), 175 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml
> create mode 100644 drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c
>
WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Adrian Ratiu
<adrian.ratiu-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Jernej Skrabec <jernej.skrabec-gGgVlfcn5nU@public.gmane.org>,
Jonas Karlman <jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-imx-3arQi8VN3Tc@public.gmane.org,
kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org,
linux-stm32-XDFAJ8BFU24N7RejjzZ/Li2xQDfSxrLKVpNB7YpNyf8@public.gmane.org,
Laurent Pinchart
<Laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
Subject: Re: [PATCH v5 0/5] Genericize DW MIPI DSI bridge and add i.MX 6 driver
Date: Mon, 6 Apr 2020 16:23:49 +0200 [thread overview]
Message-ID: <7b95e129-8035-df7f-3d50-2ae3c2e8af8d@samsung.com> (raw)
In-Reply-To: <20200330113542.181752-1-adrian.ratiu-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Hi Adrian,
Due to different ways of work I use different mail client, so forgive me
if there are some misconfugrations.
W dniu 30.03.2020 o 13:35, Adrian Ratiu pisze:
> Hello everyone,
>
> The v5 series is a significantly cleaned up version from v4,
> started by Ezequiel Garcia's suggestion of splitting out the
> regmap infrastructure from the drivers (thank you!).
>
> Turns out no changes are required to the existing drivers and
> the bridge can transparently take care of the layout logic,
> so there's no need to expose the regmap via plat_data anymore.
>
> Starting from this version I also opted to add per-patch
> changelogs. All review comments up to now have been addressed.
>
> Tested on IMX6DL.
>
> Adrian Ratiu (5):
> drm: bridge: dw_mipi_dsi: add initial regmap infrastructure
> drm: bridge: dw_mipi_dsi: abstract register access using reg_fields
> drm: bridge: synopsis: add dsi v1.01 support
> drm: imx: Add i.MX 6 MIPI DSI host platform driver
> dt-bindings: display: add i.MX6 MIPI DSI host controller doc
>
> .../display/imx/fsl,mipi-dsi-imx6.yaml | 134 ++++
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 683 +++++++++++++-----
So we have above 400 lines more just to add slightly different register
layout of v1.01.
Quite big linecount for apparently small (?) functional change - I was
too lazy to check how many reg fields are really used (some are not used
at all), but it does not seem to be big enough to justyfy so big change IMO.
I will add more comments in specific patches.
Regards
Andrzej
> drivers/gpu/drm/imx/Kconfig | 7 +
> drivers/gpu/drm/imx/Makefile | 1 +
> drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c | 399 ++++++++++
> 5 files changed, 1049 insertions(+), 175 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml
> create mode 100644 drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c
>
WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Hajda <a.hajda@samsung.com>
To: Adrian Ratiu <adrian.ratiu@collabora.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-imx@nxp.com,
kernel@collabora.com, linux-stm32@st-md-mailman.stormreply.com,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v5 0/5] Genericize DW MIPI DSI bridge and add i.MX 6 driver
Date: Mon, 6 Apr 2020 16:23:49 +0200 [thread overview]
Message-ID: <7b95e129-8035-df7f-3d50-2ae3c2e8af8d@samsung.com> (raw)
In-Reply-To: <20200330113542.181752-1-adrian.ratiu@collabora.com>
Hi Adrian,
Due to different ways of work I use different mail client, so forgive me
if there are some misconfugrations.
W dniu 30.03.2020 o 13:35, Adrian Ratiu pisze:
> Hello everyone,
>
> The v5 series is a significantly cleaned up version from v4,
> started by Ezequiel Garcia's suggestion of splitting out the
> regmap infrastructure from the drivers (thank you!).
>
> Turns out no changes are required to the existing drivers and
> the bridge can transparently take care of the layout logic,
> so there's no need to expose the regmap via plat_data anymore.
>
> Starting from this version I also opted to add per-patch
> changelogs. All review comments up to now have been addressed.
>
> Tested on IMX6DL.
>
> Adrian Ratiu (5):
> drm: bridge: dw_mipi_dsi: add initial regmap infrastructure
> drm: bridge: dw_mipi_dsi: abstract register access using reg_fields
> drm: bridge: synopsis: add dsi v1.01 support
> drm: imx: Add i.MX 6 MIPI DSI host platform driver
> dt-bindings: display: add i.MX6 MIPI DSI host controller doc
>
> .../display/imx/fsl,mipi-dsi-imx6.yaml | 134 ++++
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 683 +++++++++++++-----
So we have above 400 lines more just to add slightly different register
layout of v1.01.
Quite big linecount for apparently small (?) functional change - I was
too lazy to check how many reg fields are really used (some are not used
at all), but it does not seem to be big enough to justyfy so big change IMO.
I will add more comments in specific patches.
Regards
Andrzej
> drivers/gpu/drm/imx/Kconfig | 7 +
> drivers/gpu/drm/imx/Makefile | 1 +
> drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c | 399 ++++++++++
> 5 files changed, 1049 insertions(+), 175 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml
> create mode 100644 drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Hajda <a.hajda@samsung.com>
To: Adrian Ratiu <adrian.ratiu@collabora.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-imx@nxp.com,
kernel@collabora.com, linux-stm32@st-md-mailman.stormreply.com,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v5 0/5] Genericize DW MIPI DSI bridge and add i.MX 6 driver
Date: Mon, 6 Apr 2020 16:23:49 +0200 [thread overview]
Message-ID: <7b95e129-8035-df7f-3d50-2ae3c2e8af8d@samsung.com> (raw)
In-Reply-To: <20200330113542.181752-1-adrian.ratiu@collabora.com>
Hi Adrian,
Due to different ways of work I use different mail client, so forgive me
if there are some misconfugrations.
W dniu 30.03.2020 o 13:35, Adrian Ratiu pisze:
> Hello everyone,
>
> The v5 series is a significantly cleaned up version from v4,
> started by Ezequiel Garcia's suggestion of splitting out the
> regmap infrastructure from the drivers (thank you!).
>
> Turns out no changes are required to the existing drivers and
> the bridge can transparently take care of the layout logic,
> so there's no need to expose the regmap via plat_data anymore.
>
> Starting from this version I also opted to add per-patch
> changelogs. All review comments up to now have been addressed.
>
> Tested on IMX6DL.
>
> Adrian Ratiu (5):
> drm: bridge: dw_mipi_dsi: add initial regmap infrastructure
> drm: bridge: dw_mipi_dsi: abstract register access using reg_fields
> drm: bridge: synopsis: add dsi v1.01 support
> drm: imx: Add i.MX 6 MIPI DSI host platform driver
> dt-bindings: display: add i.MX6 MIPI DSI host controller doc
>
> .../display/imx/fsl,mipi-dsi-imx6.yaml | 134 ++++
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 683 +++++++++++++-----
So we have above 400 lines more just to add slightly different register
layout of v1.01.
Quite big linecount for apparently small (?) functional change - I was
too lazy to check how many reg fields are really used (some are not used
at all), but it does not seem to be big enough to justyfy so big change IMO.
I will add more comments in specific patches.
Regards
Andrzej
> drivers/gpu/drm/imx/Kconfig | 7 +
> drivers/gpu/drm/imx/Makefile | 1 +
> drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c | 399 ++++++++++
> 5 files changed, 1049 insertions(+), 175 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml
> create mode 100644 drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-06 14:23 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200330113455eucas1p1441dc79d44de5081e9d90079e2020ca0@eucas1p1.samsung.com>
2020-03-30 11:35 ` [PATCH v5 0/5] Genericize DW MIPI DSI bridge and add i.MX 6 driver Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-03-30 11:35 ` [PATCH v5 1/5] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-03-30 15:58 ` adrian61
2020-03-30 15:58 ` adrian61
2020-03-30 15:58 ` adrian61
2020-03-30 16:13 ` adrian61
2020-03-30 16:13 ` adrian61
2020-03-30 16:13 ` adrian61
2020-03-30 21:16 ` Adrian Ratiu
2020-03-30 21:16 ` Adrian Ratiu
2020-03-30 21:16 ` Adrian Ratiu
2020-03-30 21:16 ` Adrian Ratiu
2020-03-30 11:35 ` [PATCH v5 2/5] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-04-06 15:39 ` Andrzej Hajda
2020-04-06 15:39 ` Andrzej Hajda
2020-04-06 15:39 ` Andrzej Hajda
2020-04-10 10:22 ` Adrian Ratiu
2020-04-10 10:22 ` Adrian Ratiu
2020-04-10 10:22 ` Adrian Ratiu
2020-04-10 10:22 ` Adrian Ratiu
2020-03-30 11:35 ` [PATCH v5 3/5] drm: bridge: synopsis: add dsi v1.01 support Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-03-30 16:08 ` adrian61
2020-03-30 16:08 ` adrian61
2020-03-30 16:08 ` adrian61
2020-03-30 16:08 ` adrian61
2020-03-30 21:18 ` Adrian Ratiu
2020-03-30 21:18 ` Adrian Ratiu
2020-03-30 21:18 ` Adrian Ratiu
2020-03-30 11:35 ` [PATCH v5 4/5] drm: imx: Add i.MX 6 MIPI DSI host platform driver Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-03-30 11:49 ` Fabio Estevam
2020-03-30 11:49 ` Fabio Estevam
2020-03-30 11:49 ` Fabio Estevam
2020-03-30 11:49 ` Fabio Estevam
2020-03-30 13:51 ` Ezequiel Garcia
2020-03-30 13:51 ` Ezequiel Garcia
2020-03-30 13:51 ` Ezequiel Garcia
2020-03-30 13:51 ` Ezequiel Garcia
2020-03-30 21:31 ` Adrian Ratiu
2020-03-30 21:31 ` Adrian Ratiu
2020-03-30 21:31 ` Adrian Ratiu
2020-03-30 21:31 ` Adrian Ratiu
2020-03-31 4:05 ` Ezequiel Garcia
2020-03-31 4:05 ` Ezequiel Garcia
2020-03-31 4:05 ` Ezequiel Garcia
2020-03-31 4:05 ` Ezequiel Garcia
2020-03-31 7:19 ` Adrian Ratiu
2020-03-31 7:19 ` Adrian Ratiu
2020-03-31 7:19 ` Adrian Ratiu
2020-03-31 7:19 ` Adrian Ratiu
2020-03-30 21:20 ` Adrian Ratiu
2020-03-30 21:20 ` Adrian Ratiu
2020-03-30 21:20 ` Adrian Ratiu
2020-03-30 21:20 ` Adrian Ratiu
2020-03-30 11:35 ` [PATCH v5 5/5] dt-bindings: display: add i.MX6 MIPI DSI host controller doc Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-03-30 11:35 ` Adrian Ratiu
2020-03-30 11:52 ` Fabio Estevam
2020-03-30 11:52 ` Fabio Estevam
2020-03-30 11:52 ` Fabio Estevam
2020-03-30 11:52 ` Fabio Estevam
2020-03-30 15:44 ` Rob Herring
2020-03-30 15:44 ` Rob Herring
2020-03-30 15:44 ` Rob Herring
2020-03-30 15:44 ` Rob Herring
2020-04-06 14:23 ` Andrzej Hajda [this message]
2020-04-06 14:23 ` [PATCH v5 0/5] Genericize DW MIPI DSI bridge and add i.MX 6 driver Andrzej Hajda
2020-04-06 14:23 ` Andrzej Hajda
2020-04-06 14:23 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b95e129-8035-df7f-3d50-2ae3c2e8af8d@samsung.com \
--to=a.hajda@samsung.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=adrian.ratiu@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.