From: Chao Yu <chao@kernel.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>,
linux-erofs@lists.ozlabs.org, Liu Bo <bo.liu@linux.alibaba.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] erofs: fix double free of 'copied'
Date: Wed, 25 Aug 2021 20:16:31 +0800 [thread overview]
Message-ID: <7b9600f5-c968-3d97-af36-382fa6f0df32@kernel.org> (raw)
In-Reply-To: <20210825120757.11034-1-hsiangkao@linux.alibaba.com>
On 2021/8/25 20:07, Gao Xiang wrote:
> Dan reported a new smatch warning [1]
> "fs/erofs/inode.c:210 erofs_read_inode() error: double free of 'copied'"
>
> Due to new chunk-based format handling logic, the error path can be
> called after kfree(copied).
>
> Set "copied = NULL" after kfree(copied) to fix this.
>
> [1] https://lore.kernel.org/r/202108251030.bELQozR7-lkp@intel.com
> Fixes: c5aa903a59db ("erofs: support reading chunk-based uncompressed files")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>,
linux-erofs@lists.ozlabs.org, Liu Bo <bo.liu@linux.alibaba.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] erofs: fix double free of 'copied'
Date: Wed, 25 Aug 2021 20:16:31 +0800 [thread overview]
Message-ID: <7b9600f5-c968-3d97-af36-382fa6f0df32@kernel.org> (raw)
In-Reply-To: <20210825120757.11034-1-hsiangkao@linux.alibaba.com>
On 2021/8/25 20:07, Gao Xiang wrote:
> Dan reported a new smatch warning [1]
> "fs/erofs/inode.c:210 erofs_read_inode() error: double free of 'copied'"
>
> Due to new chunk-based format handling logic, the error path can be
> called after kfree(copied).
>
> Set "copied = NULL" after kfree(copied) to fix this.
>
> [1] https://lore.kernel.org/r/202108251030.bELQozR7-lkp@intel.com
> Fixes: c5aa903a59db ("erofs: support reading chunk-based uncompressed files")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
next prev parent reply other threads:[~2021-08-25 12:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 12:07 [PATCH] erofs: fix double free of 'copied' Gao Xiang
2021-08-25 12:07 ` Gao Xiang
2021-08-25 12:16 ` Chao Yu [this message]
2021-08-25 12:16 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b9600f5-c968-3d97-af36-382fa6f0df32@kernel.org \
--to=chao@kernel.org \
--cc=bo.liu@linux.alibaba.com \
--cc=dan.carpenter@oracle.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.