From: Joe Mario <jmario@redhat.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ali Saidi <alisaidi@amazon.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, german.gomez@arm.com,
benh@kernel.crashing.org, Nick.Forrington@arm.com,
alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com,
james.clark@arm.com, john.garry@huawei.com,
Jiri Olsa <jolsa@kernel.org>,
kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com,
mathieu.poirier@linaro.org, mingo@redhat.com,
namhyung@kernel.org, peterz@infradead.org, will@kernel.org
Subject: Re: [PATCH v8 0/4] perf: arm-spe: Decode SPE source and use for perf c2c
Date: Mon, 23 May 2022 13:24:32 -0400 [thread overview]
Message-ID: <7bf021df-2755-6937-629f-b3ed9281804d@redhat.com> (raw)
In-Reply-To: <20220522061533.GA715382@leoy-ThinkPad-X240s>
On 5/22/22 2:15 AM, Leo Yan wrote:
> Hi Joe,
>
> On Thu, May 19, 2022 at 11:16:53AM -0400, Joe Mario wrote:
>
> [SNIP]
>
>> Last Comment:
>> There's a row in the Pareto table that has incorrect column alignment.
>> Look at row 80 below in the truncated snipit of output. It has an extra field inserted in it at the beginning.
>> I also show what the corrected output should look like.
>>
>> Incorrect row 80:
>> 71 =================================================
>> 72 Shared Cache Line Distribution Pareto
>> 73 =================================================
>> 74 #
>> 75 # ----- HITM ----- Snoop ------- Store Refs ------ ------- CL --------
>> 76 # RmtHitm LclHitm Peer L1 Hit L1 Miss N/A Off Node PA cnt Code address
>> 77 # ....... ....... ....... ....... ....... ....... ..... .... ...... ..................
>> 78 #
>> 79 -------------------------------------------------------------------------------
>> 80 0 0 0 4648 0 0 11572 0x422140
>> 81 -------------------------------------------------------------------------------
>> 82 0.00% 0.00% 0.00% 0.00% 0.00% 44.47% 0x0 N/A 0 0x400ce8
>> 83 0.00% 0.00% 10.26% 0.00% 0.00% 0.00% 0x0 N/A 0 0x400e48
>> 84 0.00% 0.00% 0.00% 0.00% 0.00% 55.53% 0x0 N/A 0 0x400e54
>> 85 0.00% 0.00% 89.74% 0.00% 0.00% 0.00% 0x8 N/A 0 0x401038
>>
>>
>> Corrected row 80:
>> 71 =================================================
>> 72 Shared Cache Line Distribution Pareto
>> 73 =================================================
>> 74 #
>> 75 # ----- HITM ----- Snoop ------- Store Refs ----- ------- CL --------
>> 76 # RmtHitm LclHitm Peer L1 Hit L1 Miss N/A Off Node PA cnt Code address
>> 77 # ....... ....... ....... ....... ....... ...... ..... .... ...... ..................
>> 78 #
>> 79 -------------------------------------------------------------------------------
>> 80 0 0 4648 0 0 11572 0x422140
>> 81 -------------------------------------------------------------------------------
>> 82 0.00% 0.00% 0.00% 0.00% 0.00% 44.47% 0x0 N/A 0 0x400ce8
>> 83 0.00% 0.00% 10.26% 0.00% 0.00% 0.00% 0x0 N/A 0 0x400e48
>> 84 0.00% 0.00% 0.00% 0.00% 0.00% 55.53% 0x0 N/A 0 0x400e54
>> 85 0.00% 0.00% 89.74% 0.00% 0.00% 0.00% 0x8 N/A 0 0x401038
>
> Hmm‥. At my side, I used below command to output pareto view, but I
> cannot see the conlumn "CL", the conlumn "CL" is only shown for TUI
> mode but not for the mode "--stdio". Could you share the method for
> how to reproduce this issue?
Hi Leo:
I figured out why my output was different than yours.
I did not have the slang-devel rpm installed on the host system.
In my original perf build, I missed the this output in the build log:
> slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev
Once I installed slang-devel, rebuilt perf, and then reran my test, the pareto output looked fine.
When the TUI support is disabled, it shouldn't corrupt the resulting stdio output. I don't believe this has anything to do with your commits.
Last, it looks like you should update the help text for the display flag options to reflect your new peer option.
Currently it says:
-d, --display <Switch HITM output type>
lcl,rmt
But since you added the "peer" display, shouldn't the output for that help text state:
-d, --display <Switch HITM output type>
lcl,rmt,peer
Joe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Joe Mario <jmario@redhat.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ali Saidi <alisaidi@amazon.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, german.gomez@arm.com,
benh@kernel.crashing.org, Nick.Forrington@arm.com,
alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com,
james.clark@arm.com, john.garry@huawei.com,
Jiri Olsa <jolsa@kernel.org>,
kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com,
mathieu.poirier@linaro.org, mingo@redhat.com,
namhyung@kernel.org, peterz@infradead.org, will@kernel.org
Subject: Re: [PATCH v8 0/4] perf: arm-spe: Decode SPE source and use for perf c2c
Date: Mon, 23 May 2022 13:24:32 -0400 [thread overview]
Message-ID: <7bf021df-2755-6937-629f-b3ed9281804d@redhat.com> (raw)
In-Reply-To: <20220522061533.GA715382@leoy-ThinkPad-X240s>
On 5/22/22 2:15 AM, Leo Yan wrote:
> Hi Joe,
>
> On Thu, May 19, 2022 at 11:16:53AM -0400, Joe Mario wrote:
>
> [SNIP]
>
>> Last Comment:
>> There's a row in the Pareto table that has incorrect column alignment.
>> Look at row 80 below in the truncated snipit of output. It has an extra field inserted in it at the beginning.
>> I also show what the corrected output should look like.
>>
>> Incorrect row 80:
>> 71 =================================================
>> 72 Shared Cache Line Distribution Pareto
>> 73 =================================================
>> 74 #
>> 75 # ----- HITM ----- Snoop ------- Store Refs ------ ------- CL --------
>> 76 # RmtHitm LclHitm Peer L1 Hit L1 Miss N/A Off Node PA cnt Code address
>> 77 # ....... ....... ....... ....... ....... ....... ..... .... ...... ..................
>> 78 #
>> 79 -------------------------------------------------------------------------------
>> 80 0 0 0 4648 0 0 11572 0x422140
>> 81 -------------------------------------------------------------------------------
>> 82 0.00% 0.00% 0.00% 0.00% 0.00% 44.47% 0x0 N/A 0 0x400ce8
>> 83 0.00% 0.00% 10.26% 0.00% 0.00% 0.00% 0x0 N/A 0 0x400e48
>> 84 0.00% 0.00% 0.00% 0.00% 0.00% 55.53% 0x0 N/A 0 0x400e54
>> 85 0.00% 0.00% 89.74% 0.00% 0.00% 0.00% 0x8 N/A 0 0x401038
>>
>>
>> Corrected row 80:
>> 71 =================================================
>> 72 Shared Cache Line Distribution Pareto
>> 73 =================================================
>> 74 #
>> 75 # ----- HITM ----- Snoop ------- Store Refs ----- ------- CL --------
>> 76 # RmtHitm LclHitm Peer L1 Hit L1 Miss N/A Off Node PA cnt Code address
>> 77 # ....... ....... ....... ....... ....... ...... ..... .... ...... ..................
>> 78 #
>> 79 -------------------------------------------------------------------------------
>> 80 0 0 4648 0 0 11572 0x422140
>> 81 -------------------------------------------------------------------------------
>> 82 0.00% 0.00% 0.00% 0.00% 0.00% 44.47% 0x0 N/A 0 0x400ce8
>> 83 0.00% 0.00% 10.26% 0.00% 0.00% 0.00% 0x0 N/A 0 0x400e48
>> 84 0.00% 0.00% 0.00% 0.00% 0.00% 55.53% 0x0 N/A 0 0x400e54
>> 85 0.00% 0.00% 89.74% 0.00% 0.00% 0.00% 0x8 N/A 0 0x401038
>
> Hmm‥. At my side, I used below command to output pareto view, but I
> cannot see the conlumn "CL", the conlumn "CL" is only shown for TUI
> mode but not for the mode "--stdio". Could you share the method for
> how to reproduce this issue?
Hi Leo:
I figured out why my output was different than yours.
I did not have the slang-devel rpm installed on the host system.
In my original perf build, I missed the this output in the build log:
> slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev
Once I installed slang-devel, rebuilt perf, and then reran my test, the pareto output looked fine.
When the TUI support is disabled, it shouldn't corrupt the resulting stdio output. I don't believe this has anything to do with your commits.
Last, it looks like you should update the help text for the display flag options to reflect your new peer option.
Currently it says:
-d, --display <Switch HITM output type>
lcl,rmt
But since you added the "peer" display, shouldn't the output for that help text state:
-d, --display <Switch HITM output type>
lcl,rmt,peer
Joe
next prev parent reply other threads:[~2022-05-23 17:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 2:03 [PATCH v8 0/4] perf: arm-spe: Decode SPE source and use for perf c2c Ali Saidi
2022-05-17 2:03 ` Ali Saidi
2022-05-17 2:03 ` [PATCH v9 1/5] perf: Add SNOOP_PEER flag to perf mem data struct Ali Saidi
2022-05-17 2:03 ` Ali Saidi
2022-05-17 2:03 ` [PATCH v9 2/5] perf tools: sync addition of PERF_MEM_SNOOPX_PEER Ali Saidi
2022-05-17 2:03 ` Ali Saidi
2022-05-17 2:03 ` [PATCH v9 3/5] perf mem: Print snoop peer flag Ali Saidi
2022-05-17 2:03 ` Ali Saidi
2022-05-17 2:03 ` [PATCH v9 4/5] perf arm-spe: Don't set data source if it's not a memory operation Ali Saidi
2022-05-17 2:03 ` Ali Saidi
2022-06-17 19:41 ` Arnaldo Carvalho de Melo
2022-06-17 19:41 ` Arnaldo Carvalho de Melo
2022-05-17 2:03 ` [PATCH v9 5/5] perf arm-spe: Use SPE data source for neoverse cores Ali Saidi
2022-05-17 2:03 ` Ali Saidi
2022-05-17 21:20 ` [PATCH v8 0/4] perf: arm-spe: Decode SPE source and use for perf c2c Arnaldo Carvalho de Melo
2022-05-17 21:20 ` Arnaldo Carvalho de Melo
2022-05-18 1:06 ` Leo Yan
2022-05-18 1:06 ` Leo Yan
2022-05-18 4:16 ` Leo Yan
2022-05-18 4:16 ` Leo Yan
2022-05-19 15:16 ` Joe Mario
2022-05-19 15:16 ` Joe Mario
2022-05-22 6:15 ` Leo Yan
2022-05-22 6:15 ` Leo Yan
2022-05-23 17:24 ` Joe Mario [this message]
2022-05-23 17:24 ` Joe Mario
2022-05-26 14:44 ` Leo Yan
2022-05-26 14:44 ` Leo Yan
-- strict thread matches above, loose matches on Subject: below --
2022-05-04 18:48 Ali Saidi
2022-05-04 18:48 ` Ali Saidi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bf021df-2755-6937-629f-b3ed9281804d@redhat.com \
--to=jmario@redhat.com \
--cc=Nick.Forrington@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alisaidi@amazon.com \
--cc=andrew.kilroy@arm.com \
--cc=benh@kernel.crashing.org \
--cc=german.gomez@arm.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=lihuafei1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.