Re: [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap_resource()

From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap_resource()
Date: Wed, 1 Sep 2021 15:49:32 +0100	[thread overview]
Message-ID: <7c75aa3a-8b1f-2d63-4c30-2c638d60e2c6@ideasonboard.com> (raw)
In-Reply-To: <20210901114459.31493-1-caihuoqing@baidu.com>

On 01/09/2021 12:44, Cai Huoqing wrote:
> Use the devm_platform_get_and_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
> v1->v2:
> Use devm_platform_get_and_ioremap_resource() instead of
> devm_platform_ioremap_resource().
> v2->v3:
> Update commit message.
> v3->v4:
> Remove the change - "struct resource *res"
>  
>  drivers/media/platform/rcar_drif.c | 3 +--
>  1 file changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/rcar_drif.c b/drivers/media/platform/rcar_drif.c
> index a505d991548b..e50673276d93 100644
> --- a/drivers/media/platform/rcar_drif.c
> +++ b/drivers/media/platform/rcar_drif.c
> @@ -1395,8 +1395,7 @@ static int rcar_drif_probe(struct platform_device *pdev)
>  	}
>  
>  	/* Register map */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	ch->base = devm_ioremap_resource(&pdev->dev, res);
> +	ch->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>  	if (IS_ERR(ch->base))
>  		return PTR_ERR(ch->base);
>  
>