From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap_resource()
Date: Wed, 1 Sep 2021 12:22:40 +0000 [thread overview]
Message-ID: <OSAPR01MB2737C7CCB159F768EDA12ACDC2CD9@OSAPR01MB2737.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210901114459.31493-1-caihuoqing@baidu.com>
> From: Cai Huoqing <caihuoqing@baidu.com>
> Sent: 01 September 2021 12:45
> To: caihuoqing@baidu.com
> Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>; Mauro Carvalho
> Chehab <mchehab@kernel.org>; linux-media@vger.kernel.org; linux-renesas-
> soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH v4] media: rcar_drif: Make use of the helper function
> devm_platform_get_and_ioremap_resource()
>
> Use the devm_platform_get_and_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Acked-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
> v1->v2:
> Use devm_platform_get_and_ioremap_resource() instead of
> devm_platform_ioremap_resource().
> v2->v3:
> Update commit message.
> v3->v4:
> Remove the change - "struct resource *res"
>
> drivers/media/platform/rcar_drif.c | 3 +--
> 1 file changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/rcar_drif.c
> b/drivers/media/platform/rcar_drif.c
> index a505d991548b..e50673276d93 100644
> --- a/drivers/media/platform/rcar_drif.c
> +++ b/drivers/media/platform/rcar_drif.c
> @@ -1395,8 +1395,7 @@ static int rcar_drif_probe(struct platform_device
> *pdev)
> }
>
> /* Register map */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ch->base = devm_ioremap_resource(&pdev->dev, res);
> + ch->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(ch->base))
> return PTR_ERR(ch->base);
>
> --
> 2.25.1
next prev parent reply other threads:[~2021-09-01 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 11:44 [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap_resource() Cai Huoqing
2021-09-01 12:22 ` Fabrizio Castro [this message]
2021-09-01 14:49 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSAPR01MB2737C7CCB159F768EDA12ACDC2CD9@OSAPR01MB2737.jpnprd01.prod.outlook.com \
--to=fabrizio.castro.jz@renesas.com \
--cc=caihuoqing@baidu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.