From: Eric Blake <eblake@redhat.com>
To: Cleber Rosa <crosa@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-trivial@nongnu.org,
Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH 1/4] qemu-iotests: remove bash shebang from library files
Date: Fri, 27 Sep 2019 11:37:52 -0500 [thread overview]
Message-ID: <7ce7f9b7-a79e-21c5-18e2-f7f2ec85e575@redhat.com> (raw)
In-Reply-To: <20190927141728.7137-2-crosa@redhat.com>
On 9/27/19 9:17 AM, Cleber Rosa wrote:
> Due to not being able to find a reason to have shebangs on files that
> are not executable.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/qemu-iotests/common.config | 2 --
> tests/qemu-iotests/common.filter | 2 --
> tests/qemu-iotests/common.nbd | 1 -
> tests/qemu-iotests/common.pattern | 2 --
> tests/qemu-iotests/common.qemu | 2 --
> tests/qemu-iotests/common.rc | 2 --
> tests/qemu-iotests/common.tls | 2 --
> 7 files changed, 13 deletions(-)
>
Loss of the shebang changes the mode in which emacs opens the files
(from Shell-script[bash] to Conf[space] in my case). I agree that a #!
comment is not appropriate for a file that is not executable as a
standalone file, but it becomes harder to edit the file correctly unless
we replace it with some other way of letting editors realize that the
contents of each file is still meant to be consumed by bash.
Something like this would work:
# hey emacs, this file will be sourced by bash: -*- sh -*-
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-09-27 17:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 14:17 [PATCH 0/4] iotests: trivial cleanups Cleber Rosa
2019-09-27 14:17 ` [PATCH 1/4] qemu-iotests: remove bash shebang from library files Cleber Rosa
2019-09-27 16:37 ` Eric Blake [this message]
2019-10-09 16:26 ` Cleber Rosa
2019-10-09 18:38 ` Cleber Rosa
2019-09-27 14:17 ` [PATCH 2/4] qemu-iotests: remove forceful execution success " Cleber Rosa
2019-09-27 16:47 ` Eric Blake
2019-09-27 14:17 ` [PATCH 3/4] qemu-iotests: 044: pass is actually a noop, so remove it Cleber Rosa
2019-09-27 16:47 ` Eric Blake
2019-09-27 20:37 ` John Snow
2019-09-27 14:17 ` [PATCH 4/4] qemu-iotests: 044: remove inaccurate docstring class description Cleber Rosa
2019-09-27 16:48 ` Eric Blake
2019-09-27 20:38 ` John Snow
2019-10-07 13:09 ` [PATCH 0/4] iotests: trivial cleanups Max Reitz
2019-10-09 16:27 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ce7f9b7-a79e-21c5-18e2-f7f2ec85e575@redhat.com \
--to=eblake@redhat.com \
--cc=crosa@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.