From: Max Reitz <mreitz@redhat.com>
To: Cleber Rosa <crosa@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>,
qemu-block@nongnu.org
Subject: Re: [PATCH 0/4] iotests: trivial cleanups
Date: Mon, 7 Oct 2019 15:09:25 +0200 [thread overview]
Message-ID: <ac7839be-eea2-6fa7-eff5-146d2aedf059@redhat.com> (raw)
In-Reply-To: <20190927141728.7137-1-crosa@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 923 bytes --]
On 27.09.19 16:17, Cleber Rosa wrote:
> The most trivial set of cleanups to iotests common libraries and the
> 044 test.
>
> Cleber Rosa (4):
> qemu-iotests: remove bash shebang from library files
> qemu-iotests: remove forceful execution success from library files
> qemu-iotests: 044: pass is actually a noop, so remove it
> qemu-iotests: 044: remove inaccurate docstring class description
>
> tests/qemu-iotests/044 | 4 ----
> tests/qemu-iotests/common.config | 5 -----
> tests/qemu-iotests/common.filter | 5 -----
> tests/qemu-iotests/common.nbd | 1 -
> tests/qemu-iotests/common.pattern | 2 --
> tests/qemu-iotests/common.qemu | 2 --
> tests/qemu-iotests/common.rc | 5 -----
> tests/qemu-iotests/common.tls | 2 --
> 8 files changed, 26 deletions(-)
Looks OK to me, but I’d like to know what you think about Eric’s concern
on patch 1.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-07 13:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 14:17 [PATCH 0/4] iotests: trivial cleanups Cleber Rosa
2019-09-27 14:17 ` [PATCH 1/4] qemu-iotests: remove bash shebang from library files Cleber Rosa
2019-09-27 16:37 ` Eric Blake
2019-10-09 16:26 ` Cleber Rosa
2019-10-09 18:38 ` Cleber Rosa
2019-09-27 14:17 ` [PATCH 2/4] qemu-iotests: remove forceful execution success " Cleber Rosa
2019-09-27 16:47 ` Eric Blake
2019-09-27 14:17 ` [PATCH 3/4] qemu-iotests: 044: pass is actually a noop, so remove it Cleber Rosa
2019-09-27 16:47 ` Eric Blake
2019-09-27 20:37 ` John Snow
2019-09-27 14:17 ` [PATCH 4/4] qemu-iotests: 044: remove inaccurate docstring class description Cleber Rosa
2019-09-27 16:48 ` Eric Blake
2019-09-27 20:38 ` John Snow
2019-10-07 13:09 ` Max Reitz [this message]
2019-10-09 16:27 ` [PATCH 0/4] iotests: trivial cleanups Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac7839be-eea2-6fa7-eff5-146d2aedf059@redhat.com \
--to=mreitz@redhat.com \
--cc=crosa@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.