From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Elaine Zhang <zhangqing@rock-chips.com>,
mturquette@baylibre.com, sboyd@kernel.org,
kever.yang@rock-chips.com, heiko@sntech.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, huangtao@rock-chips.com,
andy.yan@rock-chips.com
Subject: Re: [PATCH v4 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id
Date: Wed, 18 Oct 2023 09:14:20 +0200 [thread overview]
Message-ID: <7d54a96e-17b0-4055-b546-a670d1536af5@linaro.org> (raw)
In-Reply-To: <20231018070144.8512-4-zhangqing@rock-chips.com>
On 18/10/2023 09:01, Elaine Zhang wrote:
> MBIST_MCLK_PDM1 is not used,
> Use PCLK_VO1GRF to replace it.
>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> ---
> include/dt-bindings/clock/rockchip,rk3588-cru.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> index 5790b1391201..5816cd71a4e3 100644
> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> @@ -36,7 +36,7 @@
> #define PCLK_DSU 21
> #define PCLK_S_DAPLITE 22
> #define PCLK_M_DAPLITE 23
> -#define MBIST_MCLK_PDM1 24
> +#define PCLK_VO1GRF 24
That's an ABI break without justification.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Elaine Zhang <zhangqing@rock-chips.com>,
mturquette@baylibre.com, sboyd@kernel.org,
kever.yang@rock-chips.com, heiko@sntech.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, huangtao@rock-chips.com,
andy.yan@rock-chips.com
Subject: Re: [PATCH v4 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id
Date: Wed, 18 Oct 2023 09:14:20 +0200 [thread overview]
Message-ID: <7d54a96e-17b0-4055-b546-a670d1536af5@linaro.org> (raw)
In-Reply-To: <20231018070144.8512-4-zhangqing@rock-chips.com>
On 18/10/2023 09:01, Elaine Zhang wrote:
> MBIST_MCLK_PDM1 is not used,
> Use PCLK_VO1GRF to replace it.
>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> ---
> include/dt-bindings/clock/rockchip,rk3588-cru.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> index 5790b1391201..5816cd71a4e3 100644
> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> @@ -36,7 +36,7 @@
> #define PCLK_DSU 21
> #define PCLK_S_DAPLITE 22
> #define PCLK_M_DAPLITE 23
> -#define MBIST_MCLK_PDM1 24
> +#define PCLK_VO1GRF 24
That's an ABI break without justification.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Elaine Zhang <zhangqing@rock-chips.com>,
mturquette@baylibre.com, sboyd@kernel.org,
kever.yang@rock-chips.com, heiko@sntech.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, huangtao@rock-chips.com,
andy.yan@rock-chips.com
Subject: Re: [PATCH v4 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id
Date: Wed, 18 Oct 2023 09:14:20 +0200 [thread overview]
Message-ID: <7d54a96e-17b0-4055-b546-a670d1536af5@linaro.org> (raw)
In-Reply-To: <20231018070144.8512-4-zhangqing@rock-chips.com>
On 18/10/2023 09:01, Elaine Zhang wrote:
> MBIST_MCLK_PDM1 is not used,
> Use PCLK_VO1GRF to replace it.
>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> ---
> include/dt-bindings/clock/rockchip,rk3588-cru.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> index 5790b1391201..5816cd71a4e3 100644
> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> @@ -36,7 +36,7 @@
> #define PCLK_DSU 21
> #define PCLK_S_DAPLITE 22
> #define PCLK_M_DAPLITE 23
> -#define MBIST_MCLK_PDM1 24
> +#define PCLK_VO1GRF 24
That's an ABI break without justification.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-18 7:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 7:01 [PATCH v4 0/4] rockchip: add GATE_LINK Elaine Zhang
2023-10-18 7:01 ` Elaine Zhang
2023-10-18 7:01 ` Elaine Zhang
2023-10-18 7:01 ` [PATCH v4 1/4] clk: gate: export clk_gate_endisable Elaine Zhang
2023-10-18 7:01 ` Elaine Zhang
2023-10-18 7:01 ` Elaine Zhang
2023-10-18 7:01 ` [PATCH v4 2/4] clk: rockchip: add support for gate link Elaine Zhang
2023-10-18 7:01 ` Elaine Zhang
2023-10-18 7:01 ` Elaine Zhang
2023-10-18 7:01 ` [PATCH v4 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id Elaine Zhang
2023-10-18 7:01 ` Elaine Zhang
2023-10-18 7:01 ` Elaine Zhang
2023-10-18 7:14 ` Krzysztof Kozlowski [this message]
2023-10-18 7:14 ` Krzysztof Kozlowski
2023-10-18 7:14 ` Krzysztof Kozlowski
2023-10-18 7:01 ` [PATCH v4 4/4] clk: rockchip: rk3588: Adjust the GATE_LINK parameter Elaine Zhang
2023-10-18 7:01 ` Elaine Zhang
2023-10-18 7:01 ` Elaine Zhang
2023-10-20 17:42 ` [PATCH v4 0/4] rockchip: add GATE_LINK Sebastian Reichel
2023-10-20 17:42 ` Sebastian Reichel
2023-10-20 17:42 ` Sebastian Reichel
2023-10-24 1:47 ` Stephen Boyd
2023-10-24 1:47 ` Stephen Boyd
2023-10-24 1:47 ` Stephen Boyd
2023-10-25 19:48 ` Sebastian Reichel
2023-10-25 19:48 ` Sebastian Reichel
2023-10-25 19:48 ` Sebastian Reichel
2023-10-25 21:40 ` Stephen Boyd
2023-10-25 21:40 ` Stephen Boyd
2023-10-25 21:40 ` Stephen Boyd
2023-10-26 2:25 ` zhangqing
2023-10-26 2:25 ` zhangqing
2023-10-26 2:25 ` zhangqing
2023-10-26 21:29 ` Stephen Boyd
2023-10-26 21:29 ` Stephen Boyd
2023-10-26 21:29 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d54a96e-17b0-4055-b546-a670d1536af5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.