From: Arnaud POULIQUEN <arnaud.pouliquen@st.com> To: Mathieu Poirier <mathieu.poirier@linaro.org>, "ohad@wizery.com" <ohad@wizery.com>, "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>, "mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>, Alexandre TORGUE <alexandre.torgue@st.com> Cc: "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>, "linux-stm32@st-md-mailman.stormreply.com" <linux-stm32@st-md-mailman.stormreply.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] remoteproc: stm32: Fix pointer assignement Date: Tue, 1 Sep 2020 09:23:02 +0200 [thread overview] Message-ID: <7d63d684-d675-3812-312f-d6b248e06700@st.com> (raw) In-Reply-To: <20200831213758.206690-1-mathieu.poirier@linaro.org> Hi Mathieu, On 8/31/20 11:37 PM, Mathieu Poirier wrote: > Fix the assignment of the @state pointer - it is obviously wrong. > > Fixes: 376ffdc04456 ("remoteproc: stm32: Properly set co-processor state when attaching") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> Thanks, Arnaud > --- > drivers/remoteproc/stm32_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index f4da42fc0eeb..d2414cc1d90d 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -685,7 +685,7 @@ static int stm32_rproc_get_m4_status(struct stm32_rproc *ddata, > * We couldn't get the coprocessor's state, assume > * it is not running. > */ > - state = M4_STATE_OFF; > + *state = M4_STATE_OFF; > return 0; > } > >
WARNING: multiple messages have this Message-ID (diff)
From: Arnaud POULIQUEN <arnaud.pouliquen@st.com> To: Mathieu Poirier <mathieu.poirier@linaro.org>, "ohad@wizery.com" <ohad@wizery.com>, "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>, "mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>, Alexandre TORGUE <alexandre.torgue@st.com> Cc: "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>, "linux-stm32@st-md-mailman.stormreply.com" <linux-stm32@st-md-mailman.stormreply.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] remoteproc: stm32: Fix pointer assignement Date: Tue, 1 Sep 2020 09:23:02 +0200 [thread overview] Message-ID: <7d63d684-d675-3812-312f-d6b248e06700@st.com> (raw) In-Reply-To: <20200831213758.206690-1-mathieu.poirier@linaro.org> Hi Mathieu, On 8/31/20 11:37 PM, Mathieu Poirier wrote: > Fix the assignment of the @state pointer - it is obviously wrong. > > Fixes: 376ffdc04456 ("remoteproc: stm32: Properly set co-processor state when attaching") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> Thanks, Arnaud > --- > drivers/remoteproc/stm32_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index f4da42fc0eeb..d2414cc1d90d 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -685,7 +685,7 @@ static int stm32_rproc_get_m4_status(struct stm32_rproc *ddata, > * We couldn't get the coprocessor's state, assume > * it is not running. > */ > - state = M4_STATE_OFF; > + *state = M4_STATE_OFF; > return 0; > } > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-01 7:23 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-31 21:37 [PATCH] remoteproc: stm32: Fix pointer assignement Mathieu Poirier 2020-08-31 21:37 ` Mathieu Poirier 2020-09-01 7:23 ` Arnaud POULIQUEN [this message] 2020-09-01 7:23 ` Arnaud POULIQUEN 2020-09-15 5:00 ` patchwork-bot+linux-remoteproc
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7d63d684-d675-3812-312f-d6b248e06700@st.com \ --to=arnaud.pouliquen@st.com \ --cc=alexandre.torgue@st.com \ --cc=bjorn.andersson@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mathieu.poirier@linaro.org \ --cc=mcoquelin.stm32@gmail.com \ --cc=ohad@wizery.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.