From: shuah <shuah@kernel.org>
To: "Daniel Díaz" <daniel.diaz@linaro.org>
Cc: Fathi Boudra <fathi.boudra@linaro.org>,
Denys Dmytriyenko <denys@ti.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
shuah <shuah@kernel.org>
Subject: Re: [PATCH 1/4] selftests: lib: allow to override CC in the top-level Makefile
Date: Wed, 16 Jan 2019 14:56:42 -0700 [thread overview]
Message-ID: <7d75f420-d624-d53d-4fa1-3827c90fa608@kernel.org> (raw)
In-Reply-To: <20190116174320.14938-1-daniel.diaz@linaro.org>
On 1/16/19 10:43 AM, Daniel Díaz wrote:
> From: Fathi Boudra <fathi.boudra@linaro.org>
>
> Relax CC assignment to allow to override CC in the top-level Makefile.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
> tools/testing/selftests/lib.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 8b0f16409ed7..0f9c47eaaa6f 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -1,6 +1,6 @@
> # This mimics the top-level Makefile. We do it explicitly here so that this
> # Makefile can operate with or without the kbuild infrastructure.
> -CC := $(CROSS_COMPILE)gcc
> +CC ?= $(CROSS_COMPILE)gcc
>
> ifeq (0,$(MAKELEVEL))
> OUTPUT := $(shell pwd)
>
What problem does this fix?
thanks,
-- Shuah
WARNING: multiple messages have this Message-ID (diff)
From: shuah at kernel.org (shuah)
Subject: [PATCH 1/4] selftests: lib: allow to override CC in the top-level Makefile
Date: Wed, 16 Jan 2019 14:56:42 -0700 [thread overview]
Message-ID: <7d75f420-d624-d53d-4fa1-3827c90fa608@kernel.org> (raw)
In-Reply-To: <20190116174320.14938-1-daniel.diaz@linaro.org>
On 1/16/19 10:43 AM, Daniel Díaz wrote:
> From: Fathi Boudra <fathi.boudra at linaro.org>
>
> Relax CC assignment to allow to override CC in the top-level Makefile.
>
> Signed-off-by: Denys Dmytriyenko <denys at ti.com>
> ---
> tools/testing/selftests/lib.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 8b0f16409ed7..0f9c47eaaa6f 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -1,6 +1,6 @@
> # This mimics the top-level Makefile. We do it explicitly here so that this
> # Makefile can operate with or without the kbuild infrastructure.
> -CC := $(CROSS_COMPILE)gcc
> +CC ?= $(CROSS_COMPILE)gcc
>
> ifeq (0,$(MAKELEVEL))
> OUTPUT := $(shell pwd)
>
What problem does this fix?
thanks,
-- Shuah
WARNING: multiple messages have this Message-ID (diff)
From: shuah@kernel.org (shuah)
Subject: [PATCH 1/4] selftests: lib: allow to override CC in the top-level Makefile
Date: Wed, 16 Jan 2019 14:56:42 -0700 [thread overview]
Message-ID: <7d75f420-d624-d53d-4fa1-3827c90fa608@kernel.org> (raw)
Message-ID: <20190116215642.ljEVq4amETTI8nLgswg5Z1CcwsLVoAOtbCNhMSqscBA@z> (raw)
In-Reply-To: <20190116174320.14938-1-daniel.diaz@linaro.org>
On 1/16/19 10:43 AM, Daniel Díaz wrote:
> From: Fathi Boudra <fathi.boudra at linaro.org>
>
> Relax CC assignment to allow to override CC in the top-level Makefile.
>
> Signed-off-by: Denys Dmytriyenko <denys at ti.com>
> ---
> tools/testing/selftests/lib.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 8b0f16409ed7..0f9c47eaaa6f 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -1,6 +1,6 @@
> # This mimics the top-level Makefile. We do it explicitly here so that this
> # Makefile can operate with or without the kbuild infrastructure.
> -CC := $(CROSS_COMPILE)gcc
> +CC ?= $(CROSS_COMPILE)gcc
>
> ifeq (0,$(MAKELEVEL))
> OUTPUT := $(shell pwd)
>
What problem does this fix?
thanks,
-- Shuah
next prev parent reply other threads:[~2019-01-16 21:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 17:43 [PATCH 1/4] selftests: lib: allow to override CC in the top-level Makefile Daniel Díaz
2019-01-16 17:43 ` Daniel Díaz
2019-01-16 17:43 `
2019-01-16 17:43 ` [PATCH 2/4] selftests: net: use LDLIBS instead of LDFLAGS Daniel Díaz
2019-01-16 17:43 ` Daniel Díaz
2019-01-16 17:43 `
2019-01-16 17:43 ` [PATCH 3/4] selftests: seccomp: " Daniel Díaz
2019-01-16 17:43 ` Daniel Díaz
2019-01-16 17:43 `
2019-01-16 18:13 ` Kees Cook
2019-01-16 18:13 ` Kees Cook
2019-01-16 18:13 ` keescook
2019-01-16 18:26 ` shuah
2019-01-16 18:26 ` shuah
2019-01-16 18:26 ` shuah
2019-01-16 17:43 ` [PATCH 4/4] selftests: timers: " Daniel Díaz
2019-01-16 17:43 ` Daniel Díaz
2019-01-16 17:43 `
2019-01-16 21:56 ` shuah [this message]
2019-01-16 21:56 ` [PATCH 1/4] selftests: lib: allow to override CC in the top-level Makefile shuah
2019-01-16 21:56 ` shuah
2019-01-18 17:54 ` Daniel Díaz
2019-01-18 17:54 ` Daniel Díaz
2019-01-18 17:54 `
2019-01-28 15:01 ` shuah
2019-01-28 15:01 ` shuah
2019-01-28 15:01 ` shuah
2019-01-28 15:42 ` Denys Dmytriyenko
2019-01-28 15:42 ` Denys Dmytriyenko
2019-01-28 15:42 ` denys
2019-01-28 16:28 ` shuah
2019-01-28 16:28 ` shuah
2019-01-28 16:28 ` shuah
2019-01-28 17:01 ` Daniel Díaz
2019-01-28 17:01 ` Daniel Díaz
2019-01-28 17:01 `
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d75f420-d624-d53d-4fa1-3827c90fa608@kernel.org \
--to=shuah@kernel.org \
--cc=daniel.diaz@linaro.org \
--cc=denys@ti.com \
--cc=fathi.boudra@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.