Re: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning

From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Deng, Emily" <Emily.Deng-5C7GfCeVMHo@public.gmane.org>,
	"Grodzovsky,
	Andrey" <Andrey.Grodzovsky-5C7GfCeVMHo@public.gmane.org>,
	"dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org"
	<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
Date: Mon, 4 Nov 2019 13:15:34 +0100	[thread overview]
Message-ID: <7e09156c-db05-ca46-08f0-c871c2ada43f@gmail.com> (raw)
In-Reply-To: <MN2PR12MB29755DDF54361142B8340FEF8F7F0-rweVpJHSKToFlvJWC7EAqwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>

Reviewed-by: Christian König <christian.koenig@amd.com>

Am 04.11.19 um 04:37 schrieb Deng, Emily:
> Reviewed-by: Emily Deng <Emily.Deng@amd.com>
>
>> -----Original Message-----
>> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
>> Andrey Grodzovsky
>> Sent: Wednesday, October 30, 2019 2:08 AM
>> To: dan.carpenter@oracle.com
>> Cc: Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com>; amd-
>> gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
>> Subject: [PATCH v2] drm/sched: Fix passing zero to 'PTR_ERR' warning
>>
>> Fix a static code checker warning.
>>
>> v2: Drop PTR_ERR_OR_ZERO.
>>
>> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>> ---
>> drivers/gpu/drm/scheduler/sched_main.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/scheduler/sched_main.c
>> b/drivers/gpu/drm/scheduler/sched_main.c
>> index f39b97e..dba4390 100644
>> --- a/drivers/gpu/drm/scheduler/sched_main.c
>> +++ b/drivers/gpu/drm/scheduler/sched_main.c
>> @@ -496,8 +496,10 @@ void drm_sched_resubmit_jobs(struct
>> drm_gpu_scheduler *sched)
>> 		fence = sched->ops->run_job(s_job);
>>
>> 		if (IS_ERR_OR_NULL(fence)) {
>> +			if (IS_ERR(fence))
>> +				dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>> +
>> 			s_job->s_fence->parent = NULL;
>> -			dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>> 		} else {
>> 			s_job->s_fence->parent = fence;
>> 		}
>> @@ -741,8 +743,9 @@ static int drm_sched_main(void *param)
>> 					  r);
>> 			dma_fence_put(fence);
>> 		} else {
>> +			if (IS_ERR(fence))
>> +				dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>>
>> -			dma_fence_set_error(&s_fence->finished,
>> PTR_ERR(fence));
>> 			drm_sched_process_job(NULL, &sched_job->cb);
>> 		}
>>
>> --
>> 2.7.4
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx