From: Steven Price <steven.price@arm.com> To: Zou Wei <zou_wei@huawei.com>, robh@kernel.org, tomeu.vizoso@collabora.com, airlied@linux.ie, daniel@ffwll.ch, alyssa.rosenzweig@collabora.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] drm/panfrost: Fix PM reference leak in panfrost_job_hw_submit() Date: Wed, 12 May 2021 16:23:48 +0100 [thread overview] Message-ID: <7ebf35ef-58c3-7bc7-f0e9-ad487bae6686@arm.com> (raw) In-Reply-To: <1620714551-106976-1-git-send-email-zou_wei@huawei.com> On 11/05/2021 07:29, Zou Wei wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com> Thanks for the patch, but this is actually incorrect. panfrost_job_hw_submit() is expected to unconditionally increment the pm usage counter. This is because panfrost_job_hw_submit() can (currently) never fail, so in this case the job is considered "submitted" (even though it never reaches the hardware) and it's handled by the job timeout. However this is at least the second time[1] this phantom "reference leak" has been raised, so perhaps it's time to handle this better. I'll post a patch reworking panfrost_job_hw_submit() so it can fail. Thanks, Steve [1] https://lore.kernel.org/r/20200520110504.24388-1-dinghao.liu%40zju.edu.cn > --- > drivers/gpu/drm/panfrost/panfrost_job.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c > index 6003cfe..42d8dbc 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_job.c > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c > @@ -157,7 +157,7 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js) > > panfrost_devfreq_record_busy(&pfdev->pfdevfreq); > > - ret = pm_runtime_get_sync(pfdev->dev); > + ret = pm_runtime_resume_and_get(pfdev->dev); > if (ret < 0) > return; > >
WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com> To: Zou Wei <zou_wei@huawei.com>, robh@kernel.org, tomeu.vizoso@collabora.com, airlied@linux.ie, daniel@ffwll.ch, alyssa.rosenzweig@collabora.com Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH -next] drm/panfrost: Fix PM reference leak in panfrost_job_hw_submit() Date: Wed, 12 May 2021 16:23:48 +0100 [thread overview] Message-ID: <7ebf35ef-58c3-7bc7-f0e9-ad487bae6686@arm.com> (raw) In-Reply-To: <1620714551-106976-1-git-send-email-zou_wei@huawei.com> On 11/05/2021 07:29, Zou Wei wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com> Thanks for the patch, but this is actually incorrect. panfrost_job_hw_submit() is expected to unconditionally increment the pm usage counter. This is because panfrost_job_hw_submit() can (currently) never fail, so in this case the job is considered "submitted" (even though it never reaches the hardware) and it's handled by the job timeout. However this is at least the second time[1] this phantom "reference leak" has been raised, so perhaps it's time to handle this better. I'll post a patch reworking panfrost_job_hw_submit() so it can fail. Thanks, Steve [1] https://lore.kernel.org/r/20200520110504.24388-1-dinghao.liu%40zju.edu.cn > --- > drivers/gpu/drm/panfrost/panfrost_job.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c > index 6003cfe..42d8dbc 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_job.c > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c > @@ -157,7 +157,7 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js) > > panfrost_devfreq_record_busy(&pfdev->pfdevfreq); > > - ret = pm_runtime_get_sync(pfdev->dev); > + ret = pm_runtime_resume_and_get(pfdev->dev); > if (ret < 0) > return; > >
next prev parent reply other threads:[~2021-05-12 15:50 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-11 6:29 [PATCH -next] drm/panfrost: Fix PM reference leak in panfrost_job_hw_submit() Zou Wei 2021-05-11 6:29 ` Zou Wei 2021-05-12 15:23 ` Steven Price [this message] 2021-05-12 15:23 ` Steven Price 2021-05-13 2:07 ` Samuel Zou 2021-05-13 2:07 ` Samuel Zou
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7ebf35ef-58c3-7bc7-f0e9-ad487bae6686@arm.com \ --to=steven.price@arm.com \ --cc=airlied@linux.ie \ --cc=alyssa.rosenzweig@collabora.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh@kernel.org \ --cc=tomeu.vizoso@collabora.com \ --cc=zou_wei@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.