From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: mail@conchuod.ie, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Andrew Lunn <andrew@lunn.ch>, Support Opensource <support.opensource@diasemi.com>, Lee Jones <lee.jones@linaro.org>, Ulf Hansson <ulf.hansson@linaro.org>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Steve Twiss <stwiss.opensource@diasemi.com> Cc: Conor Dooley <conor.dooley@microchip.com>, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-riscv@lists.infradead.org, Atul Khare <atulkhare@rivosinc.com> Subject: Re: [PATCH v1 1/6] dt-bindings: mmc: convert mmc-spi-slot to yaml Date: Mon, 6 Jun 2022 09:34:19 +0200 [thread overview] Message-ID: <7f1a684c-5677-995c-1391-0a6033d62b23@linaro.org> (raw) In-Reply-To: <20220605133300.376161-2-mail@conchuod.ie> On 05/06/2022 15:32, mail@conchuod.ie wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > Convert the mmc-spi-slot text based binding doc to yaml, > with the side effect of cleaning up some of the riscv > dtbs_check warnings. > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > .../devicetree/bindings/mmc/mmc-spi-slot.txt | 29 ------- > .../devicetree/bindings/mmc/mmc-spi-slot.yaml | 76 +++++++++++++++++++ > 2 files changed, 76 insertions(+), 29 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt > create mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt > deleted file mode 100644 > index 5e74db69f581..000000000000 > --- a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt > +++ /dev/null > @@ -1,29 +0,0 @@ > -MMC/SD/SDIO slot directly connected to a SPI bus > - > -This file documents differences between the core properties described > -by mmc.txt and the properties used by the mmc_spi driver. > - > -Required properties: > -- spi-max-frequency : maximum frequency for this device (Hz). > - > -Optional properties: > -- voltage-ranges : two cells are required, first cell specifies minimum > - slot voltage (mV), second cell specifies maximum slot voltage (mV). > - Several ranges could be specified. If not provided, 3.2v..3.4v is assumed. > -- gpios : may specify GPIOs in this order: Card-Detect GPIO, > - Write-Protect GPIO. Note that this does not follow the > - binding from mmc.txt, for historical reasons. > - > -Example: > - > - mmc-slot@0 { > - compatible = "fsl,mpc8323rdb-mmc-slot", > - "mmc-spi-slot"; > - reg = <0>; > - gpios = <&qe_pio_d 14 1 > - &qe_pio_d 15 0>; > - voltage-ranges = <3300 3300>; > - spi-max-frequency = <50000000>; > - interrupts = <42>; > - interrupt-parent = <&PIC>; > - }; > diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml > new file mode 100644 > index 000000000000..a5fd723140c9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/mmc-spi-slot.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MMC/SD/SDIO slot directly connected to a SPI bus > + > +maintainers: > + - Ulf Hansson <ulf.hansson@linaro.org> > + > +allOf: > + - $ref: "mmc-controller.yaml" > + > +description: | > + The extra properties used by an mmc connected via spi. s/spi/SPI/ > + > +properties: > + compatible: > + const: "mmc-spi-slot" No quotes, please. > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: true I think instead you should reference: /schemas/spi/spi-peripheral-props.yaml (because also other properties might be needed for different SPI controllers) > + > + interrupts: > + maxItems: 1 > + > + voltage-ranges: > + $ref: '/schemas/types.yaml#/definitions/uint32-matrix' Here as well - quotes are not needed. Some schemas have it, some not, but I guess shorter is preferred :) > + description: | > + Two cells are required, first cell specifies minimum slot voltage (mV), > + second cell specifies maximum slot voltage (mV). > + items: > + items: > + - description: | > + value for minimum slot voltage > + default: 3200 > + - description: | > + value for maximum slot voltage > + default: 3400 > + maxItems: 1 > + > + gpios: > + description: | > + For historical reasons, this does not follow the generic mmc-controller binding. > + minItems: 1 > + items: > + - description: Card-Detect GPIO > + - description: Write-Protect GPIO > + > +required: > + - compatible > + - reg > + - spi-max-frequency > + > +unevaluatedProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + mmc@0 { > + compatible = "mmc-spi-slot"; > + reg = <0>; > + gpios = <&qe_pio_d 14 1>, <&qe_pio_d 15 0>; The GPIO flags should be common defines instead. > + voltage-ranges = <3300 3300>; > + spi-max-frequency = <50000000>; > + interrupts = <42>; > + interrupt-parent = <&PIC>; > + }; > + }; > + > +... Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: mail@conchuod.ie, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Andrew Lunn <andrew@lunn.ch>, Support Opensource <support.opensource@diasemi.com>, Lee Jones <lee.jones@linaro.org>, Ulf Hansson <ulf.hansson@linaro.org>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Steve Twiss <stwiss.opensource@diasemi.com> Cc: Conor Dooley <conor.dooley@microchip.com>, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-riscv@lists.infradead.org, Atul Khare <atulkhare@rivosinc.com> Subject: Re: [PATCH v1 1/6] dt-bindings: mmc: convert mmc-spi-slot to yaml Date: Mon, 6 Jun 2022 09:34:19 +0200 [thread overview] Message-ID: <7f1a684c-5677-995c-1391-0a6033d62b23@linaro.org> (raw) In-Reply-To: <20220605133300.376161-2-mail@conchuod.ie> On 05/06/2022 15:32, mail@conchuod.ie wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > Convert the mmc-spi-slot text based binding doc to yaml, > with the side effect of cleaning up some of the riscv > dtbs_check warnings. > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > .../devicetree/bindings/mmc/mmc-spi-slot.txt | 29 ------- > .../devicetree/bindings/mmc/mmc-spi-slot.yaml | 76 +++++++++++++++++++ > 2 files changed, 76 insertions(+), 29 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt > create mode 100644 Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt > deleted file mode 100644 > index 5e74db69f581..000000000000 > --- a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt > +++ /dev/null > @@ -1,29 +0,0 @@ > -MMC/SD/SDIO slot directly connected to a SPI bus > - > -This file documents differences between the core properties described > -by mmc.txt and the properties used by the mmc_spi driver. > - > -Required properties: > -- spi-max-frequency : maximum frequency for this device (Hz). > - > -Optional properties: > -- voltage-ranges : two cells are required, first cell specifies minimum > - slot voltage (mV), second cell specifies maximum slot voltage (mV). > - Several ranges could be specified. If not provided, 3.2v..3.4v is assumed. > -- gpios : may specify GPIOs in this order: Card-Detect GPIO, > - Write-Protect GPIO. Note that this does not follow the > - binding from mmc.txt, for historical reasons. > - > -Example: > - > - mmc-slot@0 { > - compatible = "fsl,mpc8323rdb-mmc-slot", > - "mmc-spi-slot"; > - reg = <0>; > - gpios = <&qe_pio_d 14 1 > - &qe_pio_d 15 0>; > - voltage-ranges = <3300 3300>; > - spi-max-frequency = <50000000>; > - interrupts = <42>; > - interrupt-parent = <&PIC>; > - }; > diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml > new file mode 100644 > index 000000000000..a5fd723140c9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/mmc-spi-slot.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MMC/SD/SDIO slot directly connected to a SPI bus > + > +maintainers: > + - Ulf Hansson <ulf.hansson@linaro.org> > + > +allOf: > + - $ref: "mmc-controller.yaml" > + > +description: | > + The extra properties used by an mmc connected via spi. s/spi/SPI/ > + > +properties: > + compatible: > + const: "mmc-spi-slot" No quotes, please. > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: true I think instead you should reference: /schemas/spi/spi-peripheral-props.yaml (because also other properties might be needed for different SPI controllers) > + > + interrupts: > + maxItems: 1 > + > + voltage-ranges: > + $ref: '/schemas/types.yaml#/definitions/uint32-matrix' Here as well - quotes are not needed. Some schemas have it, some not, but I guess shorter is preferred :) > + description: | > + Two cells are required, first cell specifies minimum slot voltage (mV), > + second cell specifies maximum slot voltage (mV). > + items: > + items: > + - description: | > + value for minimum slot voltage > + default: 3200 > + - description: | > + value for maximum slot voltage > + default: 3400 > + maxItems: 1 > + > + gpios: > + description: | > + For historical reasons, this does not follow the generic mmc-controller binding. > + minItems: 1 > + items: > + - description: Card-Detect GPIO > + - description: Write-Protect GPIO > + > +required: > + - compatible > + - reg > + - spi-max-frequency > + > +unevaluatedProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + mmc@0 { > + compatible = "mmc-spi-slot"; > + reg = <0>; > + gpios = <&qe_pio_d 14 1>, <&qe_pio_d 15 0>; The GPIO flags should be common defines instead. > + voltage-ranges = <3300 3300>; > + spi-max-frequency = <50000000>; > + interrupts = <42>; > + interrupt-parent = <&PIC>; > + }; > + }; > + > +... Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-06-06 7:34 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-05 13:32 [PATCH v1 0/6] clear riscv dtbs_check errors mail 2022-06-05 13:32 ` mail 2022-06-05 13:32 ` [PATCH v1 1/6] dt-bindings: mmc: convert mmc-spi-slot to yaml mail 2022-06-05 13:32 ` mail 2022-06-06 7:34 ` Krzysztof Kozlowski [this message] 2022-06-06 7:34 ` Krzysztof Kozlowski 2022-06-05 13:32 ` [PATCH v1 2/6] dt-bindings: i2c: convert ocores binding " mail 2022-06-05 13:32 ` mail 2022-06-06 8:02 ` Krzysztof Kozlowski 2022-06-06 8:02 ` Krzysztof Kozlowski 2022-06-06 14:41 ` Conor.Dooley 2022-06-06 14:41 ` Conor.Dooley 2022-06-06 12:53 ` Rob Herring 2022-06-06 12:53 ` Rob Herring 2022-06-05 13:32 ` [PATCH v1 3/6] MAINTAINERS: convert ocores i2c dt-binding " mail 2022-06-05 13:32 ` mail 2022-06-05 13:32 ` [PATCH v1 4/6] dt-bindings: mfd: convert da9063 " mail 2022-06-05 13:32 ` mail 2022-06-06 13:11 ` Krzysztof Kozlowski 2022-06-06 13:11 ` Krzysztof Kozlowski 2022-06-05 13:33 ` [PATCH v1 5/6] MAINTAINERS: " mail 2022-06-05 13:33 ` mail 2022-06-05 13:33 ` [PATCH v1 6/6] riscv: dts: sifive: "fix" pmic watchdog node name mail 2022-06-05 13:33 ` mail 2022-06-06 8:07 ` Krzysztof Kozlowski 2022-06-06 8:07 ` Krzysztof Kozlowski 2022-06-06 7:34 ` [PATCH v1 0/6] clear riscv dtbs_check errors Krzysztof Kozlowski 2022-06-06 7:34 ` Krzysztof Kozlowski 2022-06-06 8:56 ` Conor.Dooley 2022-06-06 8:56 ` Conor.Dooley 2022-06-08 22:27 ` Atul Khare 2022-06-08 22:27 ` Atul Khare 2022-06-08 22:42 ` Conor Dooley 2022-06-08 22:42 ` Conor Dooley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7f1a684c-5677-995c-1391-0a6033d62b23@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=andrew@lunn.ch \ --cc=aou@eecs.berkeley.edu \ --cc=atulkhare@rivosinc.com \ --cc=conor.dooley@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lee.jones@linaro.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=mail@conchuod.ie \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh+dt@kernel.org \ --cc=stwiss.opensource@diasemi.com \ --cc=support.opensource@diasemi.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.