From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>, balbi@kernel.org
Cc: Neil Armstrong <narmstrong@baylibre.com>,
linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: meson-g12a: fix suspend resume regulator unbalanced disables
Date: Wed, 21 Aug 2019 11:02:12 -0700 [thread overview]
Message-ID: <7h7e76bdnf.fsf@baylibre.com> (raw)
In-Reply-To: <20190821133518.9671-1-narmstrong@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> When going in suspend, in Device mode, then resuming back leads
> to the following:
>
> unbalanced disables for USB_PWR_EN
> WARNING: CPU: 0 PID: 163 at ../drivers/regulator/core.c:2590 _regulator_disable+0x104/0x180
> Hardware name: Amlogic Meson G12A U200 Development Board (DT)
> [...]
> pc : _regulator_disable+0x104/0x180
> lr : _regulator_disable+0x104/0x180
> [...]
> Call trace:
> _regulator_disable+0x104/0x180
> regulator_disable+0x40/0x78
> dwc3_meson_g12a_otg_mode_set+0x84/0xb0
> dwc3_meson_g12a_irq_thread+0x58/0xb8
> irq_thread_fn+0x28/0x80
> irq_thread+0x118/0x1b8
> kthread+0xf4/0x120
> ret_from_fork+0x10/0x18
>
> This disables the regulator if enabled on suspend, and the reverse on
> resume.
>
> Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue")
> Reported-by: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>, balbi@kernel.org
Cc: linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH] usb: dwc3: meson-g12a: fix suspend resume regulator unbalanced disables
Date: Wed, 21 Aug 2019 11:02:12 -0700 [thread overview]
Message-ID: <7h7e76bdnf.fsf@baylibre.com> (raw)
In-Reply-To: <20190821133518.9671-1-narmstrong@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> When going in suspend, in Device mode, then resuming back leads
> to the following:
>
> unbalanced disables for USB_PWR_EN
> WARNING: CPU: 0 PID: 163 at ../drivers/regulator/core.c:2590 _regulator_disable+0x104/0x180
> Hardware name: Amlogic Meson G12A U200 Development Board (DT)
> [...]
> pc : _regulator_disable+0x104/0x180
> lr : _regulator_disable+0x104/0x180
> [...]
> Call trace:
> _regulator_disable+0x104/0x180
> regulator_disable+0x40/0x78
> dwc3_meson_g12a_otg_mode_set+0x84/0xb0
> dwc3_meson_g12a_irq_thread+0x58/0xb8
> irq_thread_fn+0x28/0x80
> irq_thread+0x118/0x1b8
> kthread+0xf4/0x120
> ret_from_fork+0x10/0x18
>
> This disables the regulator if enabled on suspend, and the reverse on
> resume.
>
> Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue")
> Reported-by: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>, balbi@kernel.org
Cc: linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH] usb: dwc3: meson-g12a: fix suspend resume regulator unbalanced disables
Date: Wed, 21 Aug 2019 11:02:12 -0700 [thread overview]
Message-ID: <7h7e76bdnf.fsf@baylibre.com> (raw)
In-Reply-To: <20190821133518.9671-1-narmstrong@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> When going in suspend, in Device mode, then resuming back leads
> to the following:
>
> unbalanced disables for USB_PWR_EN
> WARNING: CPU: 0 PID: 163 at ../drivers/regulator/core.c:2590 _regulator_disable+0x104/0x180
> Hardware name: Amlogic Meson G12A U200 Development Board (DT)
> [...]
> pc : _regulator_disable+0x104/0x180
> lr : _regulator_disable+0x104/0x180
> [...]
> Call trace:
> _regulator_disable+0x104/0x180
> regulator_disable+0x40/0x78
> dwc3_meson_g12a_otg_mode_set+0x84/0xb0
> dwc3_meson_g12a_irq_thread+0x58/0xb8
> irq_thread_fn+0x28/0x80
> irq_thread+0x118/0x1b8
> kthread+0xf4/0x120
> ret_from_fork+0x10/0x18
>
> This disables the regulator if enabled on suspend, and the reverse on
> resume.
>
> Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue")
> Reported-by: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-08-21 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 13:35 [PATCH] usb: dwc3: meson-g12a: fix suspend resume regulator unbalanced disables Neil Armstrong
2019-08-21 13:35 ` Neil Armstrong
2019-08-21 13:35 ` Neil Armstrong
2019-08-21 18:02 ` Kevin Hilman [this message]
2019-08-21 18:02 ` Kevin Hilman
2019-08-21 18:02 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h7e76bdnf.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=balbi@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.